Skip to content

Minor documentation for LangSmith tracing#1075

Merged
rapids-bot[bot] merged 2 commits intoNVIDIA:release/1.3from
dagardner-nv:david-langsmith-docs
Oct 22, 2025
Merged

Minor documentation for LangSmith tracing#1075
rapids-bot[bot] merged 2 commits intoNVIDIA:release/1.3from
dagardner-nv:david-langsmith-docs

Conversation

@dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Oct 22, 2025

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Summary by CodeRabbit

  • Documentation
    • Clarified that the workflow uses the default LangSmith project ("default") with an optional override via configuration or command-line.
    • Removed the separate project setup step for simpler onboarding.
    • Added a warning that enabling tracing alongside LangChain may produce duplicate traces.
    • Made minor formatting and spacing improvements across the guide.

…ent tracing to a different to a different project, and avoiding duplicate traces

Signed-off-by: David Gardner <dagardner@nvidia.com>
@dagardner-nv dagardner-nv self-assigned this Oct 22, 2025
@dagardner-nv dagardner-nv added the doc Improvements or additions to documentation label Oct 22, 2025
@dagardner-nv dagardner-nv requested a review from a team as a code owner October 22, 2025 18:21
@dagardner-nv dagardner-nv added the non-breaking Non-breaking change label Oct 22, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 22, 2025

Walkthrough

Updated the simple calculator observability README to remove the explicit LangSmith "Project Name" setup and example LANGSMITH_PROJECT export, note that the workflow uses the default LangSmith project with an override option, and warn about possible duplicate traces when using LANGSMITH_TRACING with LangChain.

Changes

Cohort / File(s) Change Summary
Documentation updates
examples/observability/simple_calculator_observability/README.md
Removed the explicit "Project Name" setup block and LANGSMITH_PROJECT export. Added note that the workflow uses the default LangSmith project ("default") and can be overridden via config or --override general.telemetry.tracing.langsmith.project <your_project_name>. Added warning that LANGSMITH_TRACING with LangChain may produce duplicate traces. Minor formatting and whitespace adjustments.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Pre-merge checks and finishing touches

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)
Check name Status Explanation Resolution
Title Check ❌ Error The pull request title "Minor documentation for LangSmith tracing" is concise (41 characters), well within the 72-character limit, and clearly relevant to the changeset, which contains documentation updates to the README for LangSmith tracing configuration and notes. However, the title does not follow the imperative mood requirement specified in the guidelines. The title uses a noun phrase structure rather than an imperative verb form that would command an action (e.g., "Update", "Add", "Document"). Revise the title to use imperative mood by starting with an action verb, such as "Update documentation for LangSmith tracing" or "Document LangSmith tracing configuration and notes". This will align with the requirement for imperative mood while maintaining the conciseness and clarity of the current title.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5fe30e1 and 7c454cb.

📒 Files selected for processing (1)
  • examples/observability/simple_calculator_observability/README.md (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • examples/observability/simple_calculator_observability/README.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
examples/observability/simple_calculator_observability/README.md (1)

1-285: Inconsistent capitalization of "toolkit" throughout the file.

The file uses both "toolkit" (lowercase) and "Toolkit" (uppercase). Per the coding guidelines, "NeMo Agent Toolkit" should use capital T in headings and references. Review the file for consistency:

  • Line 20: "NVIDIA NeMo Agent toolkit" (lowercase)
  • Line 42: "NeMo Agent Toolkit" (uppercase)

This can be corrected in a follow-up if preferred, but aligning with the guideline would improve consistency.

As per coding guidelines for README files.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5d088eb and 5fe30e1.

📒 Files selected for processing (1)
  • examples/observability/simple_calculator_observability/README.md (3 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/README.@(md|ipynb)

📄 CodeRabbit inference engine (.cursor/rules/general.mdc)

Ensure READMEs follow the naming convention; avoid deprecated names; use “NeMo Agent Toolkit” (capital T) in headings

Files:

  • examples/observability/simple_calculator_observability/README.md
**/*

⚙️ CodeRabbit configuration file

**/*: # Code Review Instructions

  • Ensure the code follows best practices and coding standards. - For Python code, follow
    PEP 20 and
    PEP 8 for style guidelines.
  • Check for security vulnerabilities and potential issues. - Python methods should use type hints for all parameters and return values.
    Example:
    def my_function(param1: int, param2: str) -> bool:
        pass
  • For Python exception handling, ensure proper stack trace preservation:
    • When re-raising exceptions: use bare raise statements to maintain the original stack trace,
      and use logger.error() (not logger.exception()) to avoid duplicate stack trace output.
    • When catching and logging exceptions without re-raising: always use logger.exception()
      to capture the full stack trace information.

Documentation Review Instructions - Verify that documentation and comments are clear and comprehensive. - Verify that the documentation doesn't contain any TODOs, FIXMEs or placeholder text like "lorem ipsum". - Verify that the documentation doesn't contain any offensive or outdated terms. - Verify that documentation and comments are free of spelling mistakes, ensure the documentation doesn't contain any

words listed in the ci/vale/styles/config/vocabularies/nat/reject.txt file, words that might appear to be
spelling mistakes but are listed in the ci/vale/styles/config/vocabularies/nat/accept.txt file are OK.

Misc. - All code (except .mdc files that contain Cursor rules) should be licensed under the Apache License 2.0,

and should contain an Apache License 2.0 header comment at the top of each file.

  • Confirm that copyright years are up-to date whenever a file is changed.

Files:

  • examples/observability/simple_calculator_observability/README.md
examples/**/*

⚙️ CodeRabbit configuration file

examples/**/*: - This directory contains example code and usage scenarios for the toolkit, at a minimum an example should
contain a README.md or file README.ipynb.

  • If an example contains Python code, it should be placed in a subdirectory named src/ and should
    contain a pyproject.toml file. Optionally, it might also contain scripts in a scripts/ directory.
  • If an example contains YAML files, they should be placed in a subdirectory named configs/. - If an example contains sample data files, they should be placed in a subdirectory named data/, and should
    be checked into git-lfs.

Files:

  • examples/observability/simple_calculator_observability/README.md
🔇 Additional comments (1)
examples/observability/simple_calculator_observability/README.md (1)

155-158: Helpful documentation additions for LangSmith configuration.

The new guidance about default project behavior, override capability, and the duplicate-trace warning is clear and well-positioned. It directly addresses common user questions about project configuration and potential side effects with LangChain integration.

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Signed-off-by: David Gardner <96306125+dagardner-nv@users.noreply.github.com>
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit ffa3cfa into NVIDIA:release/1.3 Oct 22, 2025
17 checks passed
@dagardner-nv dagardner-nv deleted the david-langsmith-docs branch October 22, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Improvements or additions to documentation non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants