Minor documentation for LangSmith tracing#1075
Minor documentation for LangSmith tracing#1075rapids-bot[bot] merged 2 commits intoNVIDIA:release/1.3from
Conversation
…ent tracing to a different to a different project, and avoiding duplicate traces Signed-off-by: David Gardner <dagardner@nvidia.com>
WalkthroughUpdated the simple calculator observability README to remove the explicit LangSmith "Project Name" setup and example Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Pre-merge checks and finishing touchesImportant Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
examples/observability/simple_calculator_observability/README.md (1)
1-285: Inconsistent capitalization of "toolkit" throughout the file.The file uses both "toolkit" (lowercase) and "Toolkit" (uppercase). Per the coding guidelines, "NeMo Agent Toolkit" should use capital T in headings and references. Review the file for consistency:
- Line 20: "NVIDIA NeMo Agent toolkit" (lowercase)
- Line 42: "NeMo Agent Toolkit" (uppercase)
This can be corrected in a follow-up if preferred, but aligning with the guideline would improve consistency.
As per coding guidelines for README files.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
examples/observability/simple_calculator_observability/README.md(3 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/README.@(md|ipynb)
📄 CodeRabbit inference engine (.cursor/rules/general.mdc)
Ensure READMEs follow the naming convention; avoid deprecated names; use “NeMo Agent Toolkit” (capital T) in headings
Files:
examples/observability/simple_calculator_observability/README.md
**/*
⚙️ CodeRabbit configuration file
**/*: # Code Review Instructions
- Ensure the code follows best practices and coding standards. - For Python code, follow
PEP 20 and
PEP 8 for style guidelines.- Check for security vulnerabilities and potential issues. - Python methods should use type hints for all parameters and return values.
Example:def my_function(param1: int, param2: str) -> bool: pass- For Python exception handling, ensure proper stack trace preservation:
- When re-raising exceptions: use bare
raisestatements to maintain the original stack trace,
and uselogger.error()(notlogger.exception()) to avoid duplicate stack trace output.- When catching and logging exceptions without re-raising: always use
logger.exception()
to capture the full stack trace information.Documentation Review Instructions - Verify that documentation and comments are clear and comprehensive. - Verify that the documentation doesn't contain any TODOs, FIXMEs or placeholder text like "lorem ipsum". - Verify that the documentation doesn't contain any offensive or outdated terms. - Verify that documentation and comments are free of spelling mistakes, ensure the documentation doesn't contain any
words listed in the
ci/vale/styles/config/vocabularies/nat/reject.txtfile, words that might appear to be
spelling mistakes but are listed in theci/vale/styles/config/vocabularies/nat/accept.txtfile are OK.Misc. - All code (except .mdc files that contain Cursor rules) should be licensed under the Apache License 2.0,
and should contain an Apache License 2.0 header comment at the top of each file.
- Confirm that copyright years are up-to date whenever a file is changed.
Files:
examples/observability/simple_calculator_observability/README.md
examples/**/*
⚙️ CodeRabbit configuration file
examples/**/*: - This directory contains example code and usage scenarios for the toolkit, at a minimum an example should
contain a README.md or file README.ipynb.
- If an example contains Python code, it should be placed in a subdirectory named
src/and should
contain apyproject.tomlfile. Optionally, it might also contain scripts in ascripts/directory.- If an example contains YAML files, they should be placed in a subdirectory named
configs/. - If an example contains sample data files, they should be placed in a subdirectory nameddata/, and should
be checked into git-lfs.
Files:
examples/observability/simple_calculator_observability/README.md
🔇 Additional comments (1)
examples/observability/simple_calculator_observability/README.md (1)
155-158: Helpful documentation additions for LangSmith configuration.The new guidance about default project behavior, override capability, and the duplicate-trace warning is clear and well-positioned. It directly addresses common user questions about project configuration and potential side effects with LangChain integration.
examples/observability/simple_calculator_observability/README.md
Outdated
Show resolved
Hide resolved
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: David Gardner <96306125+dagardner-nv@users.noreply.github.com>
|
/merge |
By Submitting this PR I confirm:
Summary by CodeRabbit