Added summary and made doc changes to align with standards#1085
Added summary and made doc changes to align with standards#1085rapids-bot[bot] merged 3 commits intoNVIDIA:release/1.3from
Conversation
|
Warning Rate limit exceeded@willkill07 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 24 minutes and 0 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (3)
WalkthroughMultiple documentation files updated with wording and formatting changes: headings converted from gerund to imperative form, added brief introductory sentences in quick-start, release-notes, and tutorials, tutorial index converted to labeled-link syntax, and a few cross-reference link updates. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Pre-merge checks and finishing touchesImportant Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 6
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (10)
docs/source/quick-start/index.md(1 hunks)docs/source/quick-start/installing.md(1 hunks)docs/source/quick-start/launching-ui.md(1 hunks)docs/source/release-notes.md(1 hunks)docs/source/tutorials/add-tools-to-a-workflow.md(1 hunks)docs/source/tutorials/create-a-new-workflow.md(1 hunks)docs/source/tutorials/customize-a-workflow.md(1 hunks)docs/source/tutorials/index.md(1 hunks)docs/source/tutorials/test-with-nat-test-llm.md(1 hunks)docs/source/workflows/llms/index.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (5)
{docs/source/**/*.md,**/README.@(md|ipynb)}
📄 CodeRabbit inference engine (.cursor/rules/general.mdc)
{docs/source/**/*.md,**/README.@(md|ipynb)}: Use the full name “NVIDIA NeMo Agent toolkit” on first use in documentation, then “NeMo Agent toolkit”; in headings use “NeMo Agent Toolkit” (capital T)
Do not use deprecated names (Agent Intelligence toolkit, aiqtoolkit, AgentIQ, AIQ/aiq) in documentation unless explicitly referring to deprecated names
Never use “NAT”/“nat” abbreviations in documentation
Documentation must be clear/comprehensive; avoid TODOs/FIXMEs/placeholders; avoid offensive/outdated terms; ensure spelling is correct
Files:
docs/source/quick-start/launching-ui.mddocs/source/workflows/llms/index.mddocs/source/release-notes.mddocs/source/tutorials/create-a-new-workflow.mddocs/source/quick-start/index.mddocs/source/quick-start/installing.mddocs/source/tutorials/index.mddocs/source/tutorials/test-with-nat-test-llm.mddocs/source/tutorials/customize-a-workflow.mddocs/source/tutorials/add-tools-to-a-workflow.md
docs/source/**/*.md
📄 CodeRabbit inference engine (.cursor/rules/general.mdc)
docs/source/**/*.md: Documentation sources are Markdown files under docs/source
Surround code entities with backticks in docs to avoid Vale false positives
Do not use words listed in ci/vale/styles/config/vocabularies/nat/reject.txt; accepted words in accept.txt are allowed
Files:
docs/source/quick-start/launching-ui.mddocs/source/workflows/llms/index.mddocs/source/release-notes.mddocs/source/tutorials/create-a-new-workflow.mddocs/source/quick-start/index.mddocs/source/quick-start/installing.mddocs/source/tutorials/index.mddocs/source/tutorials/test-with-nat-test-llm.mddocs/source/tutorials/customize-a-workflow.mddocs/source/tutorials/add-tools-to-a-workflow.md
{**/*.py,**/*.sh,**/*.md,**/*.toml,**/*.y?(a)ml,**/*.json,**/*.txt,**/*.ini,**/*.cfg,**/*.ipynb}
📄 CodeRabbit inference engine (.cursor/rules/general.mdc)
{**/*.py,**/*.sh,**/*.md,**/*.toml,**/*.y?(a)ml,**/*.json,**/*.txt,**/*.ini,**/*.cfg,**/*.ipynb}: Every file must start with the standard SPDX Apache-2.0 header
Confirm copyright years are up to date when a file is changed
All source files must include the SPDX Apache-2.0 header template (copy from an existing file)
Files:
docs/source/quick-start/launching-ui.mddocs/source/workflows/llms/index.mddocs/source/release-notes.mddocs/source/tutorials/create-a-new-workflow.mddocs/source/quick-start/index.mddocs/source/quick-start/installing.mddocs/source/tutorials/index.mddocs/source/tutorials/test-with-nat-test-llm.mddocs/source/tutorials/customize-a-workflow.mddocs/source/tutorials/add-tools-to-a-workflow.md
**/*
⚙️ CodeRabbit configuration file
**/*: # Code Review Instructions
- Ensure the code follows best practices and coding standards. - For Python code, follow
PEP 20 and
PEP 8 for style guidelines.- Check for security vulnerabilities and potential issues. - Python methods should use type hints for all parameters and return values.
Example:def my_function(param1: int, param2: str) -> bool: pass- For Python exception handling, ensure proper stack trace preservation:
- When re-raising exceptions: use bare
raisestatements to maintain the original stack trace,
and uselogger.error()(notlogger.exception()) to avoid duplicate stack trace output.- When catching and logging exceptions without re-raising: always use
logger.exception()
to capture the full stack trace information.Documentation Review Instructions - Verify that documentation and comments are clear and comprehensive. - Verify that the documentation doesn't contain any TODOs, FIXMEs or placeholder text like "lorem ipsum". - Verify that the documentation doesn't contain any offensive or outdated terms. - Verify that documentation and comments are free of spelling mistakes, ensure the documentation doesn't contain any
words listed in the
ci/vale/styles/config/vocabularies/nat/reject.txtfile, words that might appear to be
spelling mistakes but are listed in theci/vale/styles/config/vocabularies/nat/accept.txtfile are OK.Misc. - All code (except .mdc files that contain Cursor rules) should be licensed under the Apache License 2.0,
and should contain an Apache License 2.0 header comment at the top of each file.
- Confirm that copyright years are up-to date whenever a file is changed.
Files:
docs/source/quick-start/launching-ui.mddocs/source/workflows/llms/index.mddocs/source/release-notes.mddocs/source/tutorials/create-a-new-workflow.mddocs/source/quick-start/index.mddocs/source/quick-start/installing.mddocs/source/tutorials/index.mddocs/source/tutorials/test-with-nat-test-llm.mddocs/source/tutorials/customize-a-workflow.mddocs/source/tutorials/add-tools-to-a-workflow.md
docs/source/**/*
⚙️ CodeRabbit configuration file
This directory contains the source code for the documentation. All documentation should be written in Markdown format. Any image files should be placed in the
docs/source/_staticdirectory.
Files:
docs/source/quick-start/launching-ui.mddocs/source/workflows/llms/index.mddocs/source/release-notes.mddocs/source/tutorials/create-a-new-workflow.mddocs/source/quick-start/index.mddocs/source/quick-start/installing.mddocs/source/tutorials/index.mddocs/source/tutorials/test-with-nat-test-llm.mddocs/source/tutorials/customize-a-workflow.mddocs/source/tutorials/add-tools-to-a-workflow.md
🧠 Learnings (1)
📚 Learning: 2025-10-22T22:02:12.883Z
Learnt from: CR
PR: NVIDIA/NeMo-Agent-Toolkit#0
File: .cursor/rules/general.mdc:0-0
Timestamp: 2025-10-22T22:02:12.883Z
Learning: Applies to {docs/source/**/*.md,**/README.@(md|ipynb)} : Use the full name “NVIDIA NeMo Agent toolkit” on first use in documentation, then “NeMo Agent toolkit”; in headings use “NeMo Agent Toolkit” (capital T)
Applied to files:
docs/source/quick-start/launching-ui.mddocs/source/release-notes.mddocs/source/tutorials/create-a-new-workflow.mddocs/source/quick-start/index.mddocs/source/quick-start/installing.mddocs/source/tutorials/index.mddocs/source/tutorials/test-with-nat-test-llm.mddocs/source/tutorials/add-tools-to-a-workflow.md
🔇 Additional comments (1)
docs/source/workflows/llms/index.md (1)
175-176: Link update aligns with renamed tutorial.Text and target now match the updated tutorial slug; no further changes needed.
babd330 to
8a170ba
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Signed-off-by: Linette Tang <lvojtku@lvojtku-mlt.client.nvidia.com> Signed-off-by: Will Killian <wkillian@nvidia.com>
Signed-off-by: Linette Tang <lvojtku@lvojtku-mlt.client.nvidia.com> Signed-off-by: Will Killian <wkillian@nvidia.com>
8a170ba to
98253ff
Compare
Signed-off-by: Will Killian <wkillian@nvidia.com>
95a55b5 to
190b4ae
Compare
|
/merge |
Description
Closes
By Submitting this PR I confirm:
Summary by CodeRabbit