Add E2E test for simple auth example#1148
Conversation
…to the test services Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
…the beautifulsoup4 name and not the deprecated bs4 name Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
… the real handler would Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
…into david-simple-auth-e2e Signed-off-by: David Gardner <dagardner@nvidia.com>
dagardner-nv
added
improvement
WalkthroughThe PR integrates OAuth2 server infrastructure into CI/CD and testing environments, updates HTML parsing dependencies across example projects, and extends the workflow execution API to support custom session parameters for authentication scenarios. Changes
Sequence Diagram(s)sequenceDiagram
actor Test
participant workflow as Workflow Engine
participant session as SessionManager
participant oauth2 as OAuth2 Server
participant api as Target API
Test->>+workflow: run_workflow(config, session_kwargs)
workflow->>workflow: Load config & build Workflow
workflow->>+session: Create SessionManager
session->>+oauth2: Open session with session_kwargs
oauth2-->>-session: Session established
workflow->>+api: Perform workflow operations
api-->>-workflow: Results
workflow->>session: Execute within session context
session-->>-workflow: Session result
workflow-->>-Test: Return typed result
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
…into david-simple-auth-e2e Signed-off-by: David Gardner <dagardner@nvidia.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
src/nat/utils/__init__.py (1)
28-33: Document the newsession_kwargsparameter in the docstring.The function signature now includes a
session_kwargsparameter, but the docstring's Parameters section (lines 38-47) doesn't document it. Users need to understand what session arguments are supported.Add documentation for the new parameter:
to_type : type[_T] The type to convert the result to. Default is str. + session_kwargs : dict[str, typing.Any] | None + Optional keyword arguments to pass to the SessionManager.session() method. Supports parameters like + user_authentication_callback, http_connection, user_input_callback, etc. Default is None. Returnspackages/nvidia_nat_test/src/nat/test/utils.py (1)
71-89: Update docstring to document new parameters.The function signature now includes
assert_expected_answerand**kwargsparameters, but the docstring doesn't document them. Per coding guidelines, all parameters should be documented in Google-style docstrings.As per coding guidelines.
""" Test specific wrapper for `nat.utils.run_workflow` to run a workflow with a question and validate the expected answer. This variant always sets the result type to `str`. + + Parameters + ---------- + config : Config | None + The configuration object to use for the workflow. If None, config_file must be provided. + config_file : StrPath | None + The path to the configuration file. If None, config must be provided. + question : str + The question/prompt to run the workflow with. + expected_answer : str + The expected answer to validate against the workflow result. + assert_expected_answer : bool + Whether to assert that the expected answer is present in the result. Default is True. + **kwargs + Additional keyword arguments forwarded to `nat.utils.run_workflow` (e.g., session_kwargs). + + Returns + ------- + str + The result of the workflow as a string. """
🧹 Nitpick comments (2)
packages/nvidia_nat_test/src/nat/test/plugin.py (1)
654-724: Consider improving exception handling and documenting the return value structure.The fixture implementation works but has a few areas for improvement:
Docstring: The return value structure should be documented, especially the dict keys:
id,secret,username,url,cookies.Exception handling: The broad
except Exceptioncatches all errors. While acceptable for test fixtures that skip on failure, static analysis flags this pattern (ruff BLE001, B904).Improvement 1: Document return value:
@pytest.fixture(name="oauth2_client_credentials", scope="session") def oauth2_client_credentials_fixture(oauth2_server_url: str, fail_missing: bool) -> dict[str, typing.Any]: """ Fixture to provide OAuth2 client credentials for testing Simulates the steps a user would take in a web browser to create a new OAuth2 client as documented in: examples/front_ends/simple_auth/README.md + + Returns + ------- + dict[str, typing.Any] + A dictionary containing: + - id: The OAuth2 client ID + - secret: The OAuth2 client secret + - username: The username used to create the client + - url: The OAuth2 server base URL + - cookies: Session cookies for authenticated requests """Improvement 2: Be more specific with exception handling:
except Exception as e: reason = f"Unable to create OAuth2 client: {e}" if fail_missing: - raise RuntimeError(reason) + raise RuntimeError(reason) from e pytest.skip(reason=reason)examples/front_ends/simple_auth/tests/test_simple_auth.py (1)
59-59: Use descriptive variable name instead of___.The triple underscore
___is unclear. Use a descriptive name likestate_paramor simply_if the value is intentionally unused.- auth_url, ___ = oauth_client.create_authorization_url(url=config.authorization_url, state=state) + auth_url, _ = oauth_client.create_authorization_url(url=config.authorization_url, state=state)
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (10)
.gitlab-ci.yml(2 hunks)examples/documentation_guides/workflows/text_file_ingest/pyproject.toml(1 hunks)examples/evaluation_and_profiling/email_phishing_analyzer/pyproject.toml(1 hunks)examples/frameworks/multi_frameworks/pyproject.toml(1 hunks)examples/front_ends/simple_auth/tests/test_simple_auth.py(1 hunks)packages/nvidia_nat_test/src/nat/test/plugin.py(1 hunks)packages/nvidia_nat_test/src/nat/test/utils.py(1 hunks)pyproject.toml(1 hunks)src/nat/utils/__init__.py(2 hunks)tests/test_data/docker-compose.services.yml(1 hunks)
🧰 Additional context used
📓 Path-based instructions (9)
{**/*.py,**/*.sh,**/*.md,**/*.toml,**/*.y?(a)ml,**/*.json,**/*.txt,**/*.ini,**/*.cfg,**/*.ipynb}
📄 CodeRabbit inference engine (.cursor/rules/general.mdc)
{**/*.py,**/*.sh,**/*.md,**/*.toml,**/*.y?(a)ml,**/*.json,**/*.txt,**/*.ini,**/*.cfg,**/*.ipynb}: Every file must start with the standard SPDX Apache-2.0 header
Confirm copyright years are up to date when a file is changed
All source files must include the SPDX Apache-2.0 header template (copy from an existing file)
Files:
pyproject.tomlexamples/documentation_guides/workflows/text_file_ingest/pyproject.tomlexamples/evaluation_and_profiling/email_phishing_analyzer/pyproject.tomlpackages/nvidia_nat_test/src/nat/test/plugin.pytests/test_data/docker-compose.services.ymlsrc/nat/utils/__init__.pyexamples/frameworks/multi_frameworks/pyproject.tomlpackages/nvidia_nat_test/src/nat/test/utils.pyexamples/front_ends/simple_auth/tests/test_simple_auth.py
{**/pyproject.toml,uv.lock}
📄 CodeRabbit inference engine (.cursor/rules/general.mdc)
New dependencies must be added to both pyproject.toml (alphabetically) and uv.lock via ‘uv pip install --sync’
Files:
pyproject.tomlexamples/documentation_guides/workflows/text_file_ingest/pyproject.tomlexamples/evaluation_and_profiling/email_phishing_analyzer/pyproject.tomlexamples/frameworks/multi_frameworks/pyproject.toml
**/*
⚙️ CodeRabbit configuration file
**/*: # Code Review Instructions
- Ensure the code follows best practices and coding standards. - For Python code, follow
PEP 20 and
PEP 8 for style guidelines.- Check for security vulnerabilities and potential issues. - Python methods should use type hints for all parameters and return values.
Example:def my_function(param1: int, param2: str) -> bool: pass- For Python exception handling, ensure proper stack trace preservation:
- When re-raising exceptions: use bare
raisestatements to maintain the original stack trace,
and uselogger.error()(notlogger.exception()) to avoid duplicate stack trace output.- When catching and logging exceptions without re-raising: always use
logger.exception()
to capture the full stack trace information.Documentation Review Instructions - Verify that documentation and comments are clear and comprehensive. - Verify that the documentation doesn't contain any TODOs, FIXMEs or placeholder text like "lorem ipsum". - Verify that the documentation doesn't contain any offensive or outdated terms. - Verify that documentation and comments are free of spelling mistakes, ensure the documentation doesn't contain any
words listed in the
ci/vale/styles/config/vocabularies/nat/reject.txtfile, words that might appear to be
spelling mistakes but are listed in theci/vale/styles/config/vocabularies/nat/accept.txtfile are OK.Misc. - All code (except .mdc files that contain Cursor rules) should be licensed under the Apache License 2.0,
and should contain an Apache License 2.0 header comment at the top of each file.
- Confirm that copyright years are up-to date whenever a file is changed.
Files:
pyproject.tomlexamples/documentation_guides/workflows/text_file_ingest/pyproject.tomlexamples/evaluation_and_profiling/email_phishing_analyzer/pyproject.tomlpackages/nvidia_nat_test/src/nat/test/plugin.pytests/test_data/docker-compose.services.ymlsrc/nat/utils/__init__.pyexamples/frameworks/multi_frameworks/pyproject.tomlpackages/nvidia_nat_test/src/nat/test/utils.pyexamples/front_ends/simple_auth/tests/test_simple_auth.py
examples/**/*
⚙️ CodeRabbit configuration file
examples/**/*: - This directory contains example code and usage scenarios for the toolkit, at a minimum an example should
contain a README.md or file README.ipynb.
- If an example contains Python code, it should be placed in a subdirectory named
src/and should
contain apyproject.tomlfile. Optionally, it might also contain scripts in ascripts/directory.- If an example contains YAML files, they should be placed in a subdirectory named
configs/. - If an example contains sample data files, they should be placed in a subdirectory nameddata/, and should
be checked into git-lfs.
Files:
examples/documentation_guides/workflows/text_file_ingest/pyproject.tomlexamples/evaluation_and_profiling/email_phishing_analyzer/pyproject.tomlexamples/frameworks/multi_frameworks/pyproject.tomlexamples/front_ends/simple_auth/tests/test_simple_auth.py
**/*.py
📄 CodeRabbit inference engine (.cursor/rules/general.mdc)
**/*.py: In code comments use the abbreviations: nat (API namespace/CLI), nvidia-nat (package), NAT (env var prefixes); never use these abbreviations in documentation
Follow PEP 20 and PEP 8 for Python style
Run yapf with column_limit=120; yapf is used for formatting (run second)
Indent with 4 spaces (no tabs) and end each file with a single trailing newline
Use ruff (ruff check --fix) as a linter (not formatter) per pyproject.toml; fix warnings unless explicitly ignored
Respect Python naming schemes: snake_case for functions/variables, PascalCase for classes, UPPER_CASE for constants
When re-raising exceptions, use bare raise to preserve stack trace; log with logger.error(), not logger.exception()
When catching and logging without re-raising, use logger.exception() to capture full stack trace
Provide Google-style docstrings for every public module, class, function, and CLI command
Docstring first line must be a concise description ending with a period
Validate and sanitize all user input, especially in web or CLI interfaces
Prefer httpx with SSL verification enabled by default and follow OWASP Top-10 recommendations
Use async/await for I/O-bound work (HTTP, DB, file I/O)
Cache expensive computations with functools.lru_cache or an external cache when appropriate
Leverage NumPy vectorized operations when beneficial and feasible
Files:
packages/nvidia_nat_test/src/nat/test/plugin.pysrc/nat/utils/__init__.pypackages/nvidia_nat_test/src/nat/test/utils.pyexamples/front_ends/simple_auth/tests/test_simple_auth.py
{src/**/*.py,packages/*/src/**/*.py}
📄 CodeRabbit inference engine (.cursor/rules/general.mdc)
{src/**/*.py,packages/*/src/**/*.py}: All importable Python code must live under src/ or packages//src/
All public APIs must have Python 3.11+ type hints on parameters and return values
Prefer typing/collections.abc abstractions (e.g., Sequence over list)
Use typing.Annotated for units or metadata when useful
Treat pyright warnings as errors during development
Files:
packages/nvidia_nat_test/src/nat/test/plugin.pysrc/nat/utils/__init__.pypackages/nvidia_nat_test/src/nat/test/utils.py
packages/*/src/**/*.py
📄 CodeRabbit inference engine (.cursor/rules/general.mdc)
If a package contains Python code, it must have tests in a tests/ directory at the same level as pyproject.toml
Files:
packages/nvidia_nat_test/src/nat/test/plugin.pypackages/nvidia_nat_test/src/nat/test/utils.py
packages/**/*
⚙️ CodeRabbit configuration file
packages/**/*: - This directory contains optional plugin packages for the toolkit, each should contain apyproject.tomlfile. - Thepyproject.tomlfile should declare a dependency onnvidia-nator another package with a name starting
withnvidia-nat-. This dependency should be declared using~=<version>, and the version should be a two
digit version (ex:~=1.0).
- Not all packages contain Python code, if they do they should also contain their own set of tests, in a
tests/directory at the same level as thepyproject.tomlfile.
Files:
packages/nvidia_nat_test/src/nat/test/plugin.pypackages/nvidia_nat_test/src/nat/test/utils.py
src/nat/**/*
📄 CodeRabbit inference engine (.cursor/rules/general.mdc)
src/nat/**/* contains core functionality; changes should prioritize backward compatibility
Files:
src/nat/utils/__init__.py
⚙️ CodeRabbit configuration file
This directory contains the core functionality of the toolkit. Changes should prioritize backward compatibility.
Files:
src/nat/utils/__init__.py
🧠 Learnings (5)
📚 Learning: 2025-10-22T22:02:12.903Z
Learnt from: CR
Repo: NVIDIA/NeMo-Agent-Toolkit PR: 0
File: .cursor/rules/general.mdc:0-0
Timestamp: 2025-10-22T22:02:12.903Z
Learning: Applies to packages/*/pyproject.toml : packages/*/pyproject.toml must declare a dependency on nvidia-nat or a package starting with nvidia-nat-
Applied to files:
examples/documentation_guides/workflows/text_file_ingest/pyproject.tomlexamples/evaluation_and_profiling/email_phishing_analyzer/pyproject.tomlexamples/frameworks/multi_frameworks/pyproject.toml
📚 Learning: 2025-10-22T22:02:12.903Z
Learnt from: CR
Repo: NVIDIA/NeMo-Agent-Toolkit PR: 0
File: .cursor/rules/general.mdc:0-0
Timestamp: 2025-10-22T22:02:12.903Z
Learning: Applies to packages/*/pyproject.toml : Dependencies in pyproject.toml should use ~=<version> with two-digit versions (e.g., ~=1.0)
Applied to files:
examples/documentation_guides/workflows/text_file_ingest/pyproject.tomlexamples/evaluation_and_profiling/email_phishing_analyzer/pyproject.toml
📚 Learning: 2025-10-22T22:02:12.903Z
Learnt from: CR
Repo: NVIDIA/NeMo-Agent-Toolkit PR: 0
File: .cursor/rules/general.mdc:0-0
Timestamp: 2025-10-22T22:02:12.903Z
Learning: Applies to {tests/**/*.py,examples/*/tests/**/*.py,packages/*/tests/**/*.py} : Extract frequently repeated test code into pytest fixtures
Applied to files:
packages/nvidia_nat_test/src/nat/test/plugin.py
📚 Learning: 2025-10-22T22:02:12.903Z
Learnt from: CR
Repo: NVIDIA/NeMo-Agent-Toolkit PR: 0
File: .cursor/rules/general.mdc:0-0
Timestamp: 2025-10-22T22:02:12.903Z
Learning: Applies to {tests/**/*.py,examples/*/tests/**/*.py,packages/*/tests/**/*.py} : Mock external services with pytest_httpserver or unittest.mock; avoid live endpoints
Applied to files:
packages/nvidia_nat_test/src/nat/test/plugin.py
📚 Learning: 2025-10-22T22:02:12.903Z
Learnt from: CR
Repo: NVIDIA/NeMo-Agent-Toolkit PR: 0
File: .cursor/rules/general.mdc:0-0
Timestamp: 2025-10-22T22:02:12.903Z
Learning: Applies to {docs/source/**/*.md,**/README.@(md|ipynb)} : Use the full name “NVIDIA NeMo Agent toolkit” on first use in documentation, then “NeMo Agent toolkit”; in headings use “NeMo Agent Toolkit” (capital T)
Applied to files:
examples/frameworks/multi_frameworks/pyproject.toml
🧬 Code graph analysis (3)
src/nat/utils/__init__.py (2)
src/nat/builder/workflow_builder.py (1)
build(263-378)src/nat/runtime/session.py (1)
SessionManager(46-219)
packages/nvidia_nat_test/src/nat/test/utils.py (1)
src/nat/utils/__init__.py (1)
run_workflow(28-76)
examples/front_ends/simple_auth/tests/test_simple_auth.py (4)
src/nat/authentication/oauth2/oauth2_auth_code_flow_provider_config.py (1)
OAuth2AuthCodeFlowProviderConfig(22-40)src/nat/data_models/authentication.py (2)
AuthenticatedContext(66-77)AuthFlowType(53-63)tests/nat/front_ends/auth_flow_handlers/mock_oauth2_server.py (3)
token_url(143-144)authorization_url(140-141)token(250-274)packages/nvidia_nat_test/src/nat/test/utils.py (1)
locate_example_config(57-68)
🪛 Ruff (0.14.3)
packages/nvidia_nat_test/src/nat/test/plugin.py
646-646: Consider moving this statement to an else block
(TRY300)
647-647: Do not catch blind exception: Exception
(BLE001)
650-650: Within an except clause, raise exceptions with raise ... from err or raise ... from None to distinguish them from errors in exception handling
(B904)
712-718: Consider moving this statement to an else block
(TRY300)
720-720: Do not catch blind exception: Exception
(BLE001)
723-723: Within an except clause, raise exceptions with raise ... from err or raise ... from None to distinguish them from errors in exception handling
(B904)
🔇 Additional comments (14)
examples/evaluation_and_profiling/email_phishing_analyzer/pyproject.toml (1)
14-14: LGTM! Correct dependency update.The migration from
bs4==0.0.2tobeautifulsoup4~=4.13is appropriate. Thebs4package is deprecated, andbeautifulsoup4is the correct package name for Beautiful Soup 4. The version specifier follows the coding guidelines by using~=with a two-digit version.examples/documentation_guides/workflows/text_file_ingest/pyproject.toml (1)
14-14: LGTM! Correct dependency update.The migration from
bs4==0.0.2tobeautifulsoup4~=4.13is appropriate, replacing the deprecated package name with the correct one.src/nat/utils/__init__.py (1)
70-76: LGTM! Clean session-based workflow execution.The refactor to use
SessionManagerwith explicit session scope is well-structured. Normalizingsession_kwargsto an empty dict whenNoneis a clean pattern, and forwarding it to the session enables custom authentication and other session-level configuration.pyproject.toml (1)
226-226: LGTM! Appropriate dev dependency addition.Adding
beautifulsoup4~=4.13to the dev dependency group supports the new OAuth2 test fixtures that parse HTML responses. The version specifier follows coding guidelines.tests/test_data/docker-compose.services.yml (1)
167-181: LGTM! OAuth2 test service properly configured.The new
oauth2-serverservice is well-configured for integration testing:
AUTHLIB_INSECURE_TRANSPORT=1appropriately allows HTTP for test environments- Port mapping
5001:5000avoids conflicts- Healthcheck validates service availability before tests run
- Build context correctly points to the simple_auth example
.gitlab-ci.yml (2)
56-57: LGTM! OAuth2 CI variables properly defined.The environment variables correctly point to the OAuth2 service that will be available in the test stage, using the service alias and internal container port.
140-146: Verify the OAuth2 server image is built and pushed to the registry.The service references
$CI_REGISTRY_IMAGE/oauth2_server, but there's no apparent build stage in this CI configuration that creates and pushes this image to the registry.Run the following script to check if there's a separate CI job or workflow that builds the OAuth2 server image:
examples/frameworks/multi_frameworks/pyproject.toml (1)
15-16: LGTM! Correct dependency update.The migration from
bs4==0.0.2tobeautifulsoup4~=4.13is appropriate. The dependency reordering maintains alphabetical sorting.packages/nvidia_nat_test/src/nat/test/plugin.py (2)
693-710: HTML parsing is fragile but acceptable for test fixtures.The HTML parsing logic (lines 693-710) relies on the specific structure of the OAuth2 server's HTML response. This could break if the HTML format changes. However, for test fixtures where both the server and client are controlled within the same repository, this trade-off is acceptable.
If the HTML structure changes frequently, consider having the OAuth2 server provide a JSON API endpoint for client creation as an alternative to HTML scraping.
632-651: Add return type hint for the fixture.The function is missing a return type hint. Python 3.11+ type hints are required for all public APIs per coding guidelines.
Apply this diff:
@pytest.fixture(name="oauth2_server_url", scope="session") -def oauth2_server_url_fixture(fail_missing: bool) -> str: +def oauth2_server_url_fixture(fail_missing: bool) -> str: """ To run these tests, an oauth2 server must be running. """Wait, I see the return type IS present (-> str on line 633). Let me re-check... Yes, the return type is there. So this is fine.
LGTM! OAuth2 server URL fixture follows established patterns.
The fixture correctly follows the same pattern as other service fixtures in this file (etcd_url, phoenix_url, etc.), checking connectivity and skipping or failing based on the
fail_missingflag.⛔ Skipped due to learnings
Learnt from: CR Repo: NVIDIA/NeMo-Agent-Toolkit PR: 0 File: .cursor/rules/general.mdc:0-0 Timestamp: 2025-10-22T22:02:12.903Z Learning: Applies to {tests/**/*.py,examples/*/tests/**/*.py,packages/*/tests/**/*.py} : Mock external services with pytest_httpserver or unittest.mock; avoid live endpointsexamples/front_ends/simple_auth/tests/test_simple_auth.py (3)
1-14: LGTM: License header is correct.The SPDX Apache-2.0 header with 2025 copyright is properly formatted.
76-81: Investigate and resolve type mismatch instead of usingtype: ignore.The
type: ignore[arg-type]comment suggests a type mismatch that should be properly resolved. Please investigate the underlying type issue and fix it rather than suppressing the warning.Can you verify what type mismatch is being suppressed here and whether it can be resolved by proper typing or if there's a legitimate reason to ignore it? If legitimate, add a comment explaining why.
104-132: LGTM: Test logic is well-structured.The integration test appropriately:
- Configures environment variables with test credentials
- Overrides OAuth endpoints to point to the test server
- Uses
functools.partialto bind test cookies to the auth callback- Validates the workflow result against expected credentials
The use of
session_kwargsto inject the authentication callback is clean and aligns well with the PR's objective to support custom session parameters.packages/nvidia_nat_test/src/nat/test/utils.py (1)
84-84: LGTM: Correctly forwards kwargs to underlying function.The addition of
**kwargsforwarding enables tests to pass additional parameters likesession_kwargsto the underlying workflow execution, which aligns with the PR objective to support custom session parameters.
|
/merge |
* Add the ability to optionally pass session keyword arguments with `run_workflow` * Add Oauth example service to `tests/test_data/docker-compose.services.yml` * Change Beautiful Soup dependency to use the `beautifulsoup4` name and not the deprecated `bs4` package name. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. ## Summary by CodeRabbit ## Release Notes * **Tests** * Introduced OAuth2 Authorization Code flow testing infrastructure with new fixtures for server connectivity and client credential management. * **New Features** * Added session configuration support to workflow execution through new optional parameters. * **Chores** * Updated HTML parsing dependencies to current versions across packages. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - https://github.com/Salonijain27 - Eric Evans II (https://github.com/ericevans-nv) URL: NVIDIA#1148 Signed-off-by: Sangharsh Aglave <aglave@synopsys.com>
3 participants
Description
run_workflowtests/test_data/docker-compose.services.ymlbeautifulsoup4name and not the deprecatedbs4package name.By Submitting this PR I confirm:
Summary by CodeRabbit
Release Notes
Tests
New Features
Chores