Forward-merge release/1.4 into develop#1275
Conversation
This PR adds a registration of a per-user `ReAct` agent to enable creating per-user workflow. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing/index.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. ## Summary by CodeRabbit * **New Features** * New per-user agent workflow configuration enabling ReAct-based multi-user agent support with enhanced behavioral controls including logging, retry policies, and token accounting. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> Authors: - Yuchen Zhang (https://github.com/yczhang-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: #1274
|
FAILURE - Unable to forward-merge due to an error, manual merge is necessary. Do not use the IMPORTANT: When merging this PR, do not use the auto-merger (i.e. the |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Note Free review on us!CodeRabbit is offering free reviews until Wed Dec 17 2025 to showcase some of the refinements we've made. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1275 +/- ##
===========================================
+ Coverage 75.99% 76.01% +0.01%
===========================================
Files 507 509 +2
Lines 34247 34406 +159
===========================================
+ Hits 26026 26152 +126
- Misses 8221 8254 +33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… routers (#1242) This is an initial integration between the NVIDIA NAT and [Dynamo](https://github.com/ai-dynamo/dynamo) SDKs. The scope of this PR is around establishing key integrations and a robust evaluation harness, that will allow the NAT team to explore agentic inference acceleration using Dynamo servers. There are a few key components for review: - [dynamo components] (./external/dynamo): startup and shutdown scripts for three variates of dyanmo servers - unified server with KV aware routing, unified server with predictive KV aware routing (thompson sampling), and disaggregated serving with KV aware routing - [dynamo LLM provider] (./src/nat/llm/dynamo_llm.py): a new llm provider that enabled custom request prefix headers which can be optimized for the predictive kv aware cache router (thompson). Framework integration in place for langchain and google ADK - [dynamo integration example agents] (./examples/dynamo_integration) - example project for running nat workflows (run, eval, optimize, profile) and compare performance between difference inference endpoints. Analysis and visualization scripts included. ### Musings - tool calling for the Galileo-V2 dataset used here is not parameterized by the agent in order to help normalize the OSL. - post-processing of experiment data is not integrated with profiler yet. There are currently two sets of plotting tools with _histograms_ being the newer. - After internal discussion, we opted to build a new dynamo llm provider (dynamo_llm.py), rather than implementing this as a mixin. It keeps development isolated to the dynamo components so that we can be more agile moving forward with development. - Features in this PR are largely experimental and non-breaking to the core library - There is an additional evaluator defined in `action_completion_evaluator.py`, its not used in current evaluations but im going to leave it here for completeness and possible extension. Closes ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. ## Summary by CodeRabbit * **New Features** * Dynamo LLM provider and end-to-end Dynamo backend integration with prefix-hint support and streaming/non-streaming API. * **New Agents & Tools** * React benchmark agent, decision-only tool stubs, banking tools group, self-evaluating agent with feedback/retry loop, and intent-buffer utilities. * **New Evaluators** * Tool Selection Quality (TSQ) and Action Completion (AC) evaluators. * **Documentation** * Comprehensive Dynamo integration guides, architecture docs, and READMEs. * **Tools & Scripts** * Deployment, start/stop, monitoring, benchmarking, plotting, dataset utilities, and env templates. * **Tests** * Extensive unit and integration tests across LLMs, agents, evaluators, and analysis tools. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> Authors: - Bryan Bednarski (https://github.com/bbednarski9) Approvers: - Dhruv Nandakumar (https://github.com/dnandakumar-nv) URL: #1242
|
Hi Team, as rebasing our beta release is risky the day of release, but there is some issues with 2 commits not having proper signoffs, we are going to manually pass this DCO check for now but rebase later and fix properly from develop. The commits in question are the following: Commit sha: 3126f75, Author: @bbednarski9 , Committer: GitHub; The sign-off is missing. As per our DCO check instructions: To avoid having PRs blocked in the future, always include Signed-off-by: Author Name authoremail@example.com in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s). Note: This PR contains "NAT" references in docstrings that predate the new naming guidelines shard by David. This can be addressed in a follow-up. |
mnajafian-nv
left a comment
mnajafian-nv
left a comment
There was a problem hiding this comment.
While there are 2 commits without signoffs, we are passing them and everything else has been reviewed prior.
|
🍾 |
3 participants
Forward-merge triggered by push to release/1.4 that creates a PR to keep develop up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.