Skip to content

Add code owners for example data directories#1379

Merged
rapids-bot[bot] merged 3 commits intoNVIDIA:release/1.4from
dagardner-nv:david-data-codeowner
Jan 10, 2026
Merged

Add code owners for example data directories#1379
rapids-bot[bot] merged 3 commits intoNVIDIA:release/1.4from
dagardner-nv:david-data-codeowner

Conversation

@dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Jan 9, 2026

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Summary by CodeRabbit

  • Chores
    • Updated internal code ownership assignments for dataset files.

Note: This release contains internal governance updates with no user-visible changes.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: David Gardner <dagardner@nvidia.com>
@dagardner-nv dagardner-nv self-assigned this Jan 9, 2026
@dagardner-nv dagardner-nv added the improvement Improvement to existing functionality label Jan 9, 2026
@dagardner-nv dagardner-nv requested a review from a team as a code owner January 9, 2026 22:36
@dagardner-nv dagardner-nv added the non-breaking Non-breaking change label Jan 9, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 9, 2026

Walkthrough

Adds a CODEOWNERS entry assigning ownership of dataset files under examples/**/data/**/* to @nvidia/nat-dep-approvers alongside existing uv.lock dependency management coverage.

Changes

Cohort / File(s) Summary
CODEOWNERS Configuration
.github/CODEOWNERS
Added ownership rule for dataset files in examples/**/data/**/* and expanded coverage for dependency files

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding code owners for example data directories, which aligns with the PR objectives and CODEOWNERS file modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 495f7e9 and c875431.

📒 Files selected for processing (1)
  • .github/CODEOWNERS
🧰 Additional context used
🧠 Learnings (5)
📓 Common learnings
Learnt from: CR
Repo: NVIDIA/NeMo-Agent-Toolkit PR: 0
File: .cursor/rules/general.mdc:0-0
Timestamp: 2026-01-05T15:46:49.676Z
Learning: Applies to packages/*/pyproject.toml : Each package in 'packages/' should contain a 'pyproject.toml' file with a dependency on 'nvidia-nat' or another package with name starting with 'nvidia-nat-'
📚 Learning: 2026-01-05T15:46:49.676Z
Learnt from: CR
Repo: NVIDIA/NeMo-Agent-Toolkit PR: 0
File: .cursor/rules/general.mdc:0-0
Timestamp: 2026-01-05T15:46:49.676Z
Learning: Applies to packages/*/pyproject.toml : Each package in 'packages/' should contain a 'pyproject.toml' file with a dependency on 'nvidia-nat' or another package with name starting with 'nvidia-nat-'

Applied to files:

  • .github/CODEOWNERS
📚 Learning: 2026-01-05T15:46:49.677Z
Learnt from: CR
Repo: NVIDIA/NeMo-Agent-Toolkit PR: 0
File: .cursor/rules/general.mdc:0-0
Timestamp: 2026-01-05T15:46:49.677Z
Learning: Applies to {pyproject.toml,uv.lock} : New dependencies must be added to both 'pyproject.toml' (alphabetically) and 'uv.lock' via 'uv pip install <pkg> --sync'

Applied to files:

  • .github/CODEOWNERS
📚 Learning: 2026-01-05T16:32:00.641Z
Learnt from: mnajafian-nv
Repo: NVIDIA/NeMo-Agent-Toolkit PR: 1324
File: examples/config_inheritance/pyproject.toml:15-15
Timestamp: 2026-01-05T16:32:00.641Z
Learning: In the NVIDIA/NeMo-Agent-Toolkit repository, the develop branch may reference unreleased versions of nvidia-nat (e.g., 1.5) in pyproject.toml dependency specifications even before those versions are published to PyPI. This is intentional pre-release version management, and the workspace dependencies use editable local installs (e.g., `nvidia-nat = { path = "../..", editable = true }`) to ensure development works correctly with the local sources.

Applied to files:

  • .github/CODEOWNERS
📚 Learning: 2025-11-10T21:26:35.059Z
Learnt from: jiaxiangr
Repo: NVIDIA/NeMo-Agent-Toolkit PR: 974
File: packages/nvidia_nat_all/pyproject.toml:39-39
Timestamp: 2025-11-10T21:26:35.059Z
Learning: In packages/nvidia_nat_all/pyproject.toml, workspace dependencies (nvidia-nat-* plugin packages) should NOT have version constraints because they are managed as workspace dependencies. Version constraints are only applied to the base nvidia-nat package and external dependencies, not to internal workspace packages.

Applied to files:

  • .github/CODEOWNERS
🔇 Additional comments (1)
.github/CODEOWNERS (1)

7-8: Clear and consistent addition to code ownership rules.

The new entry assigns ownership of example data directories to the same team already responsible for dependency changes (line 5). The pattern syntax and structure align well with the existing file organization.

Please verify that the GitHub team @nvidia/nat-dep-approvers exists in the NVIDIA organization and has appropriate permissions to review/approve PRs affecting example data paths. Since this team is already assigned to uv.lock on line 5, it's likely already configured correctly, but worth confirming the team has the necessary repository access.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: David Gardner <dagardner@nvidia.com>
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 19a1a02 into NVIDIA:release/1.4 Jan 10, 2026
17 checks passed
@dagardner-nv dagardner-nv deleted the david-data-codeowner branch January 10, 2026 00:23
Jerryguan777 pushed a commit to Jerryguan777/NeMo-Agent-Toolkit that referenced this pull request Jan 28, 2026
## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing/index.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.




## Summary by CodeRabbit

* **Chores**
  * Updated internal code ownership assignments for dataset files.

---

**Note:** This release contains internal governance updates with no user-visible changes.

<sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub>

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Will Killian (https://github.com/willkill07)

URL: NVIDIA#1379
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement to existing functionality non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants