Update help string and doc for "nat run --input_file"#1390
Conversation
Clarify that nat run --input_file accepts single plain text inputs only, distinguishing it from nat eval --dataset for batch evaluation. Signed-off-by: Anuradha Karuppiah <anuradhak@nvidia.com>
mnajafian-nv
left a comment
There was a problem hiding this comment.
LGTM!
Great fix, addresses the confusion and implements the explicit f.read() as discussed.
Note on CLI reference doc:
docs/source/reference/cli.md still shows the old help text, but this will auto-update once the code changes are merged (it reflects the actual CLI --help output).
Minor suggestion (non-blocking):
The help string could be slightly more concise by removing the "Intended for verbose inputs..." line (it's implied).
Signed-off-by: Anuradha Karuppiah <anuradhak@nvidia.com>
WalkthroughThe changes update the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
🧰 Additional context used📓 Path-based instructions (9)**/*.{md,mdx}📄 CodeRabbit inference engine (.cursor/rules/general.mdc)
Files:
**/*.{md,mdx,rst}📄 CodeRabbit inference engine (.cursor/rules/general.mdc)
Files:
**/*.{py,js,ts,tsx,jsx,sh,yaml,yml,json,toml,md,mdx,rst}📄 CodeRabbit inference engine (.cursor/rules/general.mdc)
Files:
**/*.{py,md,mdx,rst}📄 CodeRabbit inference engine (.cursor/rules/general.mdc)
Files:
**/*⚙️ CodeRabbit configuration file
Files:
docs/source/**/*⚙️ CodeRabbit configuration file
Files:
**/*.py📄 CodeRabbit inference engine (.cursor/rules/general.mdc)
Files:
**/*.{py,yaml,yml,json,toml}📄 CodeRabbit inference engine (.cursor/rules/general.mdc)
Files:
src/nat/**/*⚙️ CodeRabbit configuration file
Files:
🔇 Additional comments (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/merge |
1. Docs update to clarify that "nat run --input_file" accepts single plain text inputs only, distinguishing it from "nat eval" for batch evaluation. 2. Fixed file handling in console_front_end_plugin.py to read content immediately and pass string instead of file object ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing/index.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. ## Summary by CodeRabbit * **Documentation** * Clarified that `--input_file` accepts a single plain text input file instead of multiple inputs * Updated guidance to use `nat eval` for batch evaluation of multiple inputs * Enhanced documentation with explicit notes on single-input usage and batch evaluation scenarios <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> Authors: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - https://github.com/mnajafian-nv URL: NVIDIA#1390
Description
By Submitting this PR I confirm:
Summary by CodeRabbit
--input_fileaccepts a single plain text input file instead of multiple inputsnat evalfor batch evaluation of multiple inputs✏️ Tip: You can customize this high-level summary in your review settings.