Skip to content

docs: Restore Llama config docs in simple_web_query_eval README#1472

Merged
rapids-bot[bot] merged 1 commit intoNVIDIA:release/1.4from
mnajafian-nv:fix/restore-llama-readme-references
Jan 23, 2026
Merged

docs: Restore Llama config docs in simple_web_query_eval README#1472
rapids-bot[bot] merged 1 commit intoNVIDIA:release/1.4from
mnajafian-nv:fix/restore-llama-readme-references

Conversation

@mnajafian-nv
Copy link
Contributor

@mnajafian-nv mnajafian-nv commented Jan 23, 2026

Llama configs still exist and are used. Restores their documentation.

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Summary by CodeRabbit

  • Documentation
    • Updated evaluation and profiling documentation to include support for Llama 3.1 and Llama 3.3 models.
    • Added configuration references and evaluation commands for the new model variants.
    • Clarified default configuration details for improved user guidance.

✏️ Tip: You can customize this high-level summary in your review settings.

Llama configs still exist and are used. Restores their documentation.

Signed-off-by: mnajafian-nv <mnajafian@nvidia.com>
@mnajafian-nv mnajafian-nv requested a review from a team as a code owner January 23, 2026 21:29
@mnajafian-nv mnajafian-nv added improvement Improvement to existing functionality non-breaking Non-breaking change labels Jan 23, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 23, 2026

Walkthrough

Documentation updates to the simple web query evaluation example, adding references to Llama 3.1 and Llama 3.3 model support throughout the README, including new configuration files and evaluation commands.

Changes

Cohort / File(s) Summary
Documentation Updates
examples/evaluation_and_profiling/simple_web_query_eval/README.md
Updated "Key Features" and "What You'll Learn" sections to reference Llama 3.1 and Llama 3.3 support; added eval\_config\_llama31.yml and eval\_config\_llama33.yml to configuration references; included new instructional blocks for Llama 3.1 and 3.3 evaluation commands; annotated eval\_config.yml as default NVIDIA Nemotron-based configuration

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: restoring Llama configuration documentation in a specific README file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@willkill07
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit a370ce5 into NVIDIA:release/1.4 Jan 23, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement to existing functionality non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants