Skip to content

Remove the task_timeout from the a2a sample config files#1508

Merged
rapids-bot[bot] merged 1 commit intoNVIDIA:release/1.4from
AnuradhaKaruppiah:ak-increase-a2a-tout
Jan 29, 2026
Merged

Remove the task_timeout from the a2a sample config files#1508
rapids-bot[bot] merged 1 commit intoNVIDIA:release/1.4from
AnuradhaKaruppiah:ak-increase-a2a-tout

Conversation

@AnuradhaKaruppiah
Copy link
Contributor

@AnuradhaKaruppiah AnuradhaKaruppiah commented Jan 28, 2026

The default a2a task timeout is 300s. The sample config was unnecessarily lowering it to 60s resulting in timeouts for slower agents.

Description

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Summary by CodeRabbit

  • Chores
    • Simplified timeout configurations by removing explicit settings to rely on default system behavior across agent examples.

✏️ Tip: You can customize this high-level summary in your review settings.

The default a2a task timeout is 300s. The config was unnecessarily
lowering it to 60s result in timeouts for slower agents.

Signed-off-by: Anuradha Karuppiah <anuradhak@nvidia.com>
@AnuradhaKaruppiah AnuradhaKaruppiah self-assigned this Jan 28, 2026
@AnuradhaKaruppiah AnuradhaKaruppiah requested a review from a team as a code owner January 28, 2026 23:50
@AnuradhaKaruppiah AnuradhaKaruppiah added bug Something isn't working non-breaking Non-breaking change labels Jan 28, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 28, 2026

Walkthrough

Three A2A example configuration files have been modified to remove the explicit task_timeout: 60 setting from their respective a2a_client configurations, allowing the system to rely on default timeout behavior instead.

Changes

Cohort / File(s) Summary
A2A Configuration Updates
examples/A2A/currency_agent_a2a/configs/config.yml, examples/A2A/math_assistant_a2a/src/nat_math_assistant_a2a/configs/config.yml, examples/A2A/math_assistant_a2a_protected/configs/config-client.yml
Removed task_timeout: 60 setting from a2a_client configurations across three separate A2A examples. System will now use default timeout behavior.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing task_timeout settings from a2a sample configuration files across three files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AnuradhaKaruppiah
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit d106ad8 into NVIDIA:release/1.4 Jan 29, 2026
17 checks passed
@AnuradhaKaruppiah AnuradhaKaruppiah deleted the ak-increase-a2a-tout branch March 13, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants