Skip to content

Remove NASSE naming#1632

Merged
rapids-bot[bot] merged 2 commits intoNVIDIA:release/1.5from
ericevans-nv:docs/remove-nasse-branding
Feb 25, 2026
Merged

Remove NASSE naming#1632
rapids-bot[bot] merged 2 commits intoNVIDIA:release/1.5from
ericevans-nv:docs/remove-nasse-branding

Conversation

@ericevans-nv
Copy link
Contributor

@ericevans-nv ericevans-nv commented Feb 23, 2026

Description

Remove all references to "NASSE" (NeMo Agent Safety and Security Engine) from documentation and replace with descriptive language that presents safety and security as a built-in capability of NeMo Agent Toolkit rather than a separately branded feature.

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Summary by CodeRabbit

  • Documentation
    • Updated multiple docs (examples, READMEs, CHANGELOG, release notes) to use "NeMo Agent Toolkit Safety and Security" branding and terminology.
    • Renamed headings, table-of-contents entries, anchors and links to match the new label.
    • Reworded Retail Agent and safety sections to emphasize toolkit safety and security capabilities rather than NASSE-specific framing.
    • Minor grammar and style edits; no functional changes.

@ericevans-nv ericevans-nv self-assigned this Feb 23, 2026
@ericevans-nv ericevans-nv requested a review from a team as a code owner February 23, 2026 22:43
@ericevans-nv ericevans-nv added improvement Improvement to existing functionality non-breaking Non-breaking change labels Feb 23, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 23, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

Renamed occurrences of "Safety and Security" and "NASSE" to "NeMo Agent Toolkit Safety and Security" across documentation and examples, updated anchors/headings and some descriptive text, and adjusted a pre-commit markdown-link-check exclude pattern. No code, API, or behavioral changes.

Changes

Cohort / File(s) Summary
Top-level docs
CHANGELOG.md, README.md, docs/source/release-notes.md
Renamed entries and labels from "Safety and Security Engine" / NASSE to "NeMo Agent Toolkit Safety and Security"; preserved links/URLs; update is textual only.
Examples index
examples/README.md
Updated section heading and anchor from "Safety and Security"/#safety-and-security to "NeMo Agent Toolkit Safety and Security"/#nemo-agent-toolkit-safety-and-security and reworded one bullet to reference toolkit capabilities.
Example: retail agent README
examples/safety_and_security/retail_agent/README.md
Replaced NASSE terminology with "NeMo Agent Toolkit" across title, TOC anchors, headings, and body; simplified phrasing and adjusted component descriptions and warnings.
Repo tooling
.pre-commit-config.yaml
Changed markdown-link-check exclude pattern path to ^packages/nvidia_nat_core/src/nat/meta/pypi\.md$ (was ^src/nat/meta/pypi\.md$).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Remove NASSE naming' clearly and accurately describes the main objective of the PR: removing all NASSE references from documentation and replacing them with NeMo Agent Toolkit terminology.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@examples/safety_and_security/retail_agent/README.md`:
- Line 59: Replace the possessive phrase "an agent's end-to-end security
posture" with a non-possessive construction such as "the end-to-end security
posture of an agent" (or "the end-to-end security posture of an AI agent") in
the sentence that begins "This guide demonstrates the safety and security
capabilities..."; update the phrase wherever "agent's" is used with an inanimate
possessive in this README to follow the documentation guideline.

ℹ️ Review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bd6f4cf and 3a59062.

📒 Files selected for processing (2)
  • examples/README.md
  • examples/safety_and_security/retail_agent/README.md

@ericevans-nv ericevans-nv force-pushed the docs/remove-nasse-branding branch 2 times, most recently from 4193cd4 to 9d87a85 Compare February 23, 2026 22:53
@ericevans-nv ericevans-nv added the DO NOT MERGE PR should not be merged; see PR for details label Feb 24, 2026
@ericevans-nv ericevans-nv force-pushed the docs/remove-nasse-branding branch from 9d87a85 to 1d56261 Compare February 25, 2026 00:40
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@CHANGELOG.md`:
- Line 38: The PR illegally modifies historical content in CHANGELOG.md by
renaming the existing 1.4.0 entry; revert the change to the original 1.4.0 line
and instead add a new forward-looking entry (e.g., a new "Unreleased" or
next-version section) that contains the NASSE branding update; specifically undo
edits to the existing CHANGELOG.md line that contained the "NeMo Agent Toolkit
Safety and Security" entry and place the new branding text under a new
upcoming-release header so historical changelog content remains unchanged.

ℹ️ Review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9d87a85 and 26604b1.

📒 Files selected for processing (5)
  • CHANGELOG.md
  • README.md
  • docs/source/release-notes.md
  • examples/README.md
  • examples/safety_and_security/retail_agent/README.md
✅ Files skipped from review due to trivial changes (1)
  • README.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • examples/safety_and_security/retail_agent/README.md

@ericevans-nv ericevans-nv removed the DO NOT MERGE PR should not be merged; see PR for details label Feb 25, 2026
@ericevans-nv ericevans-nv changed the base branch from develop to release/1.5 February 25, 2026 15:36
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ericevans-nv ericevans-nv force-pushed the docs/remove-nasse-branding branch 3 times, most recently from 24c8821 to e136aab Compare February 25, 2026 17:26
Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
@ericevans-nv ericevans-nv force-pushed the docs/remove-nasse-branding branch from e136aab to 12aa0e3 Compare February 25, 2026 17:27
Co-authored-by: Will Killian <2007799+willkill07@users.noreply.github.com>
Signed-off-by: Eric Evans II <194135482+ericevans-nv@users.noreply.github.com>
@ericevans-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 58c7842 into NVIDIA:release/1.5 Feb 25, 2026
17 checks passed
Charlie-Yi-2002 pushed a commit to Charlie-Yi-2002/NeMo-Agent-Toolkit that referenced this pull request Mar 5, 2026
Remove all references to "NASSE" (NeMo Agent Safety and Security Engine) from documentation and replace with descriptive language that presents safety and security as a built-in capability of NeMo Agent Toolkit rather than a separately branded feature.

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing/index.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.


## Summary by CodeRabbit

* **Documentation**
  * Updated multiple docs (examples, READMEs, CHANGELOG, release notes) to use "NeMo Agent Toolkit Safety and Security" branding and terminology.
  * Renamed headings, table-of-contents entries, anchors and links to match the new label.
  * Reworded Retail Agent and safety sections to emphasize toolkit safety and security capabilities rather than NASSE-specific framing.
  * Minor grammar and style edits; no functional changes.

Authors:
  - Eric Evans II (https://github.com/ericevans-nv)

Approvers:
  - Will Killian (https://github.com/willkill07)

URL: NVIDIA#1632
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement to existing functionality non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants