Remove NASSE naming#1632
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughRenamed occurrences of "Safety and Security" and "NASSE" to "NeMo Agent Toolkit Safety and Security" across documentation and examples, updated anchors/headings and some descriptive text, and adjusted a pre-commit markdown-link-check exclude pattern. No code, API, or behavioral changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@examples/safety_and_security/retail_agent/README.md`:
- Line 59: Replace the possessive phrase "an agent's end-to-end security
posture" with a non-possessive construction such as "the end-to-end security
posture of an agent" (or "the end-to-end security posture of an AI agent") in
the sentence that begins "This guide demonstrates the safety and security
capabilities..."; update the phrase wherever "agent's" is used with an inanimate
possessive in this README to follow the documentation guideline.
4193cd4 to
9d87a85
Compare
9d87a85 to
1d56261
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@CHANGELOG.md`:
- Line 38: The PR illegally modifies historical content in CHANGELOG.md by
renaming the existing 1.4.0 entry; revert the change to the original 1.4.0 line
and instead add a new forward-looking entry (e.g., a new "Unreleased" or
next-version section) that contains the NASSE branding update; specifically undo
edits to the existing CHANGELOG.md line that contained the "NeMo Agent Toolkit
Safety and Security" entry and place the new branding text under a new
upcoming-release header so historical changelog content remains unchanged.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
CHANGELOG.mdREADME.mddocs/source/release-notes.mdexamples/README.mdexamples/safety_and_security/retail_agent/README.md
✅ Files skipped from review due to trivial changes (1)
- README.md
🚧 Files skipped from review as they are similar to previous changes (1)
- examples/safety_and_security/retail_agent/README.md
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
24c8821 to
e136aab
Compare
Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
e136aab to
12aa0e3
Compare
Co-authored-by: Will Killian <2007799+willkill07@users.noreply.github.com> Signed-off-by: Eric Evans II <194135482+ericevans-nv@users.noreply.github.com>
|
/merge |
Remove all references to "NASSE" (NeMo Agent Safety and Security Engine) from documentation and replace with descriptive language that presents safety and security as a built-in capability of NeMo Agent Toolkit rather than a separately branded feature. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing/index.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. ## Summary by CodeRabbit * **Documentation** * Updated multiple docs (examples, READMEs, CHANGELOG, release notes) to use "NeMo Agent Toolkit Safety and Security" branding and terminology. * Renamed headings, table-of-contents entries, anchors and links to match the new label. * Reworded Retail Agent and safety sections to emphasize toolkit safety and security capabilities rather than NASSE-specific framing. * Minor grammar and style edits; no functional changes. Authors: - Eric Evans II (https://github.com/ericevans-nv) Approvers: - Will Killian (https://github.com/willkill07) URL: NVIDIA#1632
Description
Remove all references to "NASSE" (NeMo Agent Safety and Security Engine) from documentation and replace with descriptive language that presents safety and security as a built-in capability of NeMo Agent Toolkit rather than a separately branded feature.
By Submitting this PR I confirm:
Summary by CodeRabbit