Skip to content

Ensure that we allways spell vLLM with the same casing that the proje…#1644

Merged
rapids-bot[bot] merged 1 commit intoNVIDIA:developfrom
dagardner-nv:david-fix-vllm-spelling
Feb 24, 2026
Merged

Ensure that we allways spell vLLM with the same casing that the proje…#1644
rapids-bot[bot] merged 1 commit intoNVIDIA:developfrom
dagardner-nv:david-fix-vllm-spelling

Conversation

@dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Feb 24, 2026

Description

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Summary by CodeRabbit

  • Chores
    • Updated spell-check vocabulary configuration to enforce standardized terminology capitalization, restricting accepted spellings to the canonical form only.

@dagardner-nv dagardner-nv self-assigned this Feb 24, 2026
@dagardner-nv dagardner-nv requested a review from a team as a code owner February 24, 2026 21:48
@dagardner-nv dagardner-nv added doc Improvements or additions to documentation non-breaking Non-breaking change labels Feb 24, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6619a88 and e7242db.

📒 Files selected for processing (1)
  • ci/vale/styles/config/vocabularies/nat/accept.txt

Walkthrough

A vocabulary configuration update in the Vale linting style that replaces two regex patterns matching various capitalizations of "vllm" with a single standardized entry for the exact term "vLLM".

Changes

Cohort / File(s) Summary
Vocabulary Configuration
ci/vale/styles/config/vocabularies/nat/accept.txt
Replaced two regex entries ([Vv]llm and [Vv]LLM) with a single standardized entry vLLM, narrowing accepted term variants from multiple capitalization patterns to only the exact casing vLLM.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main objective of the PR: ensuring consistent vLLM casing across the repository, which matches the changeset that updates vocabulary entries.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 1f875ce into NVIDIA:develop Feb 24, 2026
15 checks passed
@dagardner-nv dagardner-nv deleted the david-fix-vllm-spelling branch February 24, 2026 22:46
Charlie-Yi-2002 pushed a commit to Charlie-Yi-2002/NeMo-Agent-Toolkit that referenced this pull request Mar 5, 2026
NVIDIA#1644)

* Remove alternate casing for vLLM, ensuring that we always spell the name the same way the project does https://docs.vllm.ai/en/latest/


## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing/index.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.




## Summary by CodeRabbit

* **Chores**
  * Updated spell-check vocabulary configuration to enforce standardized terminology capitalization, restricting accepted spellings to the canonical form only.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Bryan Bednarski (https://github.com/bbednarski9)

URL: NVIDIA#1644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Improvements or additions to documentation non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants