Skip to content

chore: remove all unnecessary docker deployment guides from examples#1655

Merged
rapids-bot[bot] merged 1 commit intoNVIDIA:release/1.5from
willkill07:wkk_remove-dockerfiles-from-examples
Feb 25, 2026
Merged

chore: remove all unnecessary docker deployment guides from examples#1655
rapids-bot[bot] merged 1 commit intoNVIDIA:release/1.5from
willkill07:wkk_remove-dockerfiles-from-examples

Conversation

@willkill07
Copy link
Member

@willkill07 willkill07 commented Feb 25, 2026

Description

  • Docker deployment is not needed for simple agents
  • Remove docker deployment + instructions for these simple agents
  • Remove outdated prerequisites

Closes

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Summary by CodeRabbit

  • Documentation

    • Removed Docker deployment instructions from example guides
    • Simplified installation workflows and setup procedures
    • Added API key configuration guidance to examples
  • Chores

    • Removed Docker container configuration files from example projects

Signed-off-by: Will Killian <wkillian@nvidia.com>
@willkill07 willkill07 self-assigned this Feb 25, 2026
@willkill07 willkill07 requested a review from a team as a code owner February 25, 2026 17:37
@willkill07 willkill07 added improvement Improvement to existing functionality non-breaking Non-breaking change labels Feb 25, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 25, 2026

Walkthrough

The PR removes Dockerfile configurations and Docker deployment documentation from four example projects (email_phishing_analyzer, agno_personal_finance, simple_calculator, simple_web_query), eliminating containerized build instructions and related deployment guidance while updating associated README files.

Changes

Cohort / File(s) Summary
Dockerfiles Removal
examples/evaluation_and_profiling/email_phishing_analyzer/Dockerfile, examples/frameworks/agno_personal_finance/Dockerfile, examples/getting_started/simple_calculator/Dockerfile, examples/getting_started/simple_web_query/Dockerfile
Removed entire Dockerfile configurations that previously defined multi-stage container builds with virtual environment setup, package installation, configuration file mapping, and NAT server entrypoints.
Docker Deployment Documentation Removal
examples/evaluation_and_profiling/email_phishing_analyzer/README.md, examples/frameworks/agno_personal_finance/README.md, examples/getting_started/simple_calculator/README.md
Removed Deployment-Oriented Setup sections including Build the Docker Image, Run the Docker Container, Test the API, and Expected API Output subsections; eliminated Docker prerequisites and related guidance.
Installation and API Key Setup Updates
examples/getting_started/simple_web_query/README.md
Restructured table of contents; replaced Prerequisites and Deployment-Oriented Setup entries with Install this Workflow and Set Up API Keys; removed Docker Quickstart section; added instructions for package installation and NVIDIA API key configuration.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title clearly and concisely describes the main change: removing unnecessary Docker deployment guides from examples, which aligns with all file modifications shown in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
examples/getting_started/simple_web_query/README.md (1)

54-55: Add a blank line after the ### Set Up API Keys heading for consistency and compatibility.

You should put blank lines before and after a heading for compatibility. The ### Install this Workflow heading (Line 46) correctly has a blank line before its content, but ### Set Up API Keys jumps straight to the paragraph on the next line.

✏️ Proposed fix
 ### Set Up API Keys
+
 If you have not already done so, follow the [Obtaining API Keys](../../../docs/source/get-started/quick-start.md#obtaining-api-keys) instructions to obtain an NVIDIA API key.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@examples/getting_started/simple_web_query/README.md` around lines 54 - 55,
The "### Set Up API Keys" heading lacks a blank line after it, breaking
consistency; edit the README so that the "### Set Up API Keys" heading has an
empty line after the heading (and ensure there is a blank line before the
heading if missing) so the paragraph below starts after a blank line—look for
the literal heading "### Set Up API Keys" and insert the missing blank line to
match the other headings like "### Install this Workflow".
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@examples/getting_started/simple_web_query/README.md`:
- Around line 54-55: The "### Set Up API Keys" heading lacks a blank line after
it, breaking consistency; edit the README so that the "### Set Up API Keys"
heading has an empty line after the heading (and ensure there is a blank line
before the heading if missing) so the paragraph below starts after a blank
line—look for the literal heading "### Set Up API Keys" and insert the missing
blank line to match the other headings like "### Install this Workflow".

ℹ️ Review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 290cece and 652c2f6.

📒 Files selected for processing (8)
  • examples/evaluation_and_profiling/email_phishing_analyzer/Dockerfile
  • examples/evaluation_and_profiling/email_phishing_analyzer/README.md
  • examples/frameworks/agno_personal_finance/Dockerfile
  • examples/frameworks/agno_personal_finance/README.md
  • examples/getting_started/simple_calculator/Dockerfile
  • examples/getting_started/simple_calculator/README.md
  • examples/getting_started/simple_web_query/Dockerfile
  • examples/getting_started/simple_web_query/README.md
💤 Files with no reviewable changes (7)
  • examples/evaluation_and_profiling/email_phishing_analyzer/README.md
  • examples/frameworks/agno_personal_finance/README.md
  • examples/evaluation_and_profiling/email_phishing_analyzer/Dockerfile
  • examples/getting_started/simple_calculator/README.md
  • examples/getting_started/simple_calculator/Dockerfile
  • examples/getting_started/simple_web_query/Dockerfile
  • examples/frameworks/agno_personal_finance/Dockerfile

@AnuradhaKaruppiah
Copy link
Contributor

/merge

1 similar comment
@willkill07
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 2d6ace6 into NVIDIA:release/1.5 Feb 25, 2026
17 checks passed
Charlie-Yi-2002 pushed a commit to Charlie-Yi-2002/NeMo-Agent-Toolkit that referenced this pull request Mar 5, 2026
…VIDIA#1655)

- Docker deployment is not needed for simple agents
- Remove docker deployment + instructions for these simple agents
- Remove outdated prerequisites

Closes

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing/index.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.




## Summary by CodeRabbit

* **Documentation**
  * Removed Docker deployment instructions from example guides
  * Simplified installation workflows and setup procedures
  * Added API key configuration guidance to examples

* **Chores**
  * Removed Docker container configuration files from example projects

Authors:
  - Will Killian (https://github.com/willkill07)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

URL: NVIDIA#1655
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement to existing functionality non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants