Skip to content

Add missing dependency for nvidia-nat-opentelemetry to nvidia-nat-langchain#1670

Merged
rapids-bot[bot] merged 4 commits intoNVIDIA:release/1.5from
dagardner-nv:david-langchain-opentelemetry-dep
Feb 26, 2026
Merged

Add missing dependency for nvidia-nat-opentelemetry to nvidia-nat-langchain#1670
rapids-bot[bot] merged 4 commits intoNVIDIA:release/1.5from
dagardner-nv:david-langchain-opentelemetry-dep

Conversation

@dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Feb 26, 2026

Description

  • The langsmith integration in nvidia-nat-langchain requires code in nvidia-nat-opentelemetry
  • Update examples/notebooks documentation to explicitly choose a supported version of Python (unrelated drive-by fix).

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Summary by CodeRabbit

  • Documentation

    • Updated Python environment setup instructions to specify Python 3.13.
  • Chores

    • Added opentelemetry dependency to package configuration.

Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
@dagardner-nv dagardner-nv self-assigned this Feb 26, 2026
@dagardner-nv dagardner-nv requested review from a team as code owners February 26, 2026 18:15
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels Feb 26, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 26, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)
  • packages/nvidia_nat_langchain/uv.lock is excluded by !**/*.lock
  • packages/nvidia_nat_vanna/uv.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

Documentation update specifying Python 3.13 for virtual environment setup and configuration of the nvidia-nat-opentelemetry dependency with local source mapping in the pyproject.toml file.

Changes

Cohort / File(s) Summary
Documentation
examples/notebooks/README.md
Updated Jupyter/Colab environment setup instructions to explicitly specify Python 3.13 version (-p 3.13) when creating virtual environment with uv venv.
Dependency Configuration
packages/nvidia_nat_langchain/pyproject.toml
Added nvidia-nat-opentelemetry as a dynamic dependency and configured it as a local editable source pointing to the sibling nvidia_nat_opentelemetry package directory.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change (adding missing dependency) but exceeds the recommended ~72 character limit at 79 characters.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: David Gardner <dagardner@nvidia.com>
Copy link

@Salonijain27 Salonijain27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from a dependency point of view

@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit a6b1a51 into NVIDIA:release/1.5 Feb 26, 2026
15 checks passed
@dagardner-nv dagardner-nv deleted the david-langchain-opentelemetry-dep branch February 26, 2026 19:05
Charlie-Yi-2002 pushed a commit to Charlie-Yi-2002/NeMo-Agent-Toolkit that referenced this pull request Mar 5, 2026
…langchain` (NVIDIA#1670)

* The langsmith integration in `nvidia-nat-langchain` requires code in `nvidia-nat-opentelemetry`
* Update `examples/notebooks` documentation to explicitly choose a supported version of Python (unrelated drive-by fix).

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing/index.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.




## Summary by CodeRabbit

* **Documentation**
  * Updated Python environment setup instructions to specify Python 3.13.

* **Chores**
  * Added opentelemetry dependency to package configuration.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)
  - https://github.com/Salonijain27

URL: NVIDIA#1670
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants