Add missing dependency for nvidia-nat-opentelemetry to nvidia-nat-langchain#1670
Conversation
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (2)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughDocumentation update specifying Python 3.13 for virtual environment setup and configuration of the nvidia-nat-opentelemetry dependency with local source mapping in the pyproject.toml file. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: David Gardner <dagardner@nvidia.com>
Salonijain27
left a comment
There was a problem hiding this comment.
Approved from a dependency point of view
|
/merge |
…langchain` (NVIDIA#1670) * The langsmith integration in `nvidia-nat-langchain` requires code in `nvidia-nat-opentelemetry` * Update `examples/notebooks` documentation to explicitly choose a supported version of Python (unrelated drive-by fix). ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing/index.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. ## Summary by CodeRabbit * **Documentation** * Updated Python environment setup instructions to specify Python 3.13. * **Chores** * Added opentelemetry dependency to package configuration. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) - https://github.com/Salonijain27 URL: NVIDIA#1670
Description
nvidia-nat-langchainrequires code innvidia-nat-opentelemetryexamples/notebooksdocumentation to explicitly choose a supported version of Python (unrelated drive-by fix).By Submitting this PR I confirm:
Summary by CodeRabbit
Documentation
Chores