Fix incorrect CLI flag in auto_memory_wrapper README#1692
Merged
rapids-bot[bot] merged 3 commits intoNVIDIA:release/1.5from Mar 2, 2026
Merged
Conversation
Replace --config with --config_file in nat run commands. Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
WalkthroughDocumentation update in the auto memory wrapper README, replacing CLI flag references from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
willkill07
approved these changes
Mar 2, 2026
Contributor
Author
|
/merge |
Charlie-Yi-2002
pushed a commit
to Charlie-Yi-2002/NeMo-Agent-Toolkit
that referenced
this pull request
Mar 5, 2026
The auto_memory_wrapper README uses `--config` in the `nat run` commands, but the correct CLI flag is `--config_file`. This was a pre-existing issue from the original contribution. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing/index.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. ## Summary by CodeRabbit * **Documentation** * Updated CLI parameter examples in documentation to reflect the new parameter naming convention. Authors: - Eric Evans II (https://github.com/ericevans-nv) - Will Killian (https://github.com/willkill07) Approvers: - Will Killian (https://github.com/willkill07) URL: NVIDIA#1692
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The auto_memory_wrapper README uses
--configin thenat runcommands, but the correctCLI flag is
--config_file. This was a pre-existing issue from the original contribution.By Submitting this PR I confirm:
Summary by CodeRabbit