examples(mcp): make example more robust to LLM hallucination#1695
Conversation
Signed-off-by: Will Killian <wkillian@nvidia.com>
WalkthroughThe changes update documentation and configuration descriptions for the MCP time tool to clarify that the timezone should always be set to America/Los_Angeles when calling the function. No functional modifications or new features are introduced. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Comment |
AnuradhaKaruppiah
left a comment
There was a problem hiding this comment.
Looks great. ty for taking care of it.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@examples/MCP/simple_calculator_mcp/README.md`:
- Line 92: The README's mcp_time description and the YAML config descriptions
are inconsistent about timezone handling; update the YAML descriptions (the
entries that currently read "Always pass in the timezone as
America/Los_Angeles") to match the README's accurate server-configured wording
by changing them to indicate the timezone is assumed/forced to
America/Los_Angeles (e.g., "Timezone is assumed to be America/Los_Angeles"), and
ensure the mcp_time description in the README remains aligned with that phrasing
so both README and YAML convey the same "assumed" behavior.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
examples/MCP/simple_calculator_mcp/README.mdexamples/MCP/simple_calculator_mcp/configs/config-mcp-client.ymlexamples/MCP/simple_calculator_mcp/configs/config-per-user-mcp-client.yml
|
/merge |
…1695) - Explicitly specify timezone in MCP tool description. - Add note in example README. Closes ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing/index.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. ## Summary by CodeRabbit * **Documentation** * Clarified timezone handling guidance for the MCP time tool to explicitly indicate America/Los_Angeles timezone usage across related configuration materials. Authors: - Will Killian (https://github.com/willkill07) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#1695
Description
Closes
By Submitting this PR I confirm:
Summary by CodeRabbit