Skip to content

examples(mcp): make example more robust to LLM hallucination#1695

Merged
rapids-bot[bot] merged 1 commit intoNVIDIA:release/1.5from
willkill07:wkk_clarify-mcp-example-release-1.5
Mar 2, 2026
Merged

examples(mcp): make example more robust to LLM hallucination#1695
rapids-bot[bot] merged 1 commit intoNVIDIA:release/1.5from
willkill07:wkk_clarify-mcp-example-release-1.5

Conversation

@willkill07
Copy link
Member

@willkill07 willkill07 commented Mar 2, 2026

Description

  • Explicitly specify timezone in MCP tool description.
  • Add note in example README.

Closes

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Summary by CodeRabbit

  • Documentation
    • Clarified timezone handling guidance for the MCP time tool to explicitly indicate America/Los_Angeles timezone usage across related configuration materials.

Signed-off-by: Will Killian <wkillian@nvidia.com>
@willkill07 willkill07 self-assigned this Mar 2, 2026
@willkill07 willkill07 requested a review from a team as a code owner March 2, 2026 17:34
@willkill07 willkill07 added bug Something isn't working non-breaking Non-breaking change labels Mar 2, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 2, 2026

Walkthrough

The changes update documentation and configuration descriptions for the MCP time tool to clarify that the timezone should always be set to America/Los_Angeles when calling the function. No functional modifications or new features are introduced.

Changes

Cohort / File(s) Summary
Configuration Files
examples/MCP/simple_calculator_mcp/configs/config-mcp-client.yml, examples/MCP/simple_calculator_mcp/configs/config-per-user-mcp-client.yml
Updated the description for the get_current_time tool override under mcp_time function group to include guidance: "Always pass in the timezone as America/Los_Angeles".
Documentation
examples/MCP/simple_calculator_mcp/README.md
Updated the narrative to reflect that the mcp_time tool description now includes the timezone assumption of America/Los_Angeles.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main objective of the PR: making the MCP example more robust by reducing LLM hallucination through explicit timezone specification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@AnuradhaKaruppiah AnuradhaKaruppiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. ty for taking care of it.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@examples/MCP/simple_calculator_mcp/README.md`:
- Line 92: The README's mcp_time description and the YAML config descriptions
are inconsistent about timezone handling; update the YAML descriptions (the
entries that currently read "Always pass in the timezone as
America/Los_Angeles") to match the README's accurate server-configured wording
by changing them to indicate the timezone is assumed/forced to
America/Los_Angeles (e.g., "Timezone is assumed to be America/Los_Angeles"), and
ensure the mcp_time description in the README remains aligned with that phrasing
so both README and YAML convey the same "assumed" behavior.

ℹ️ Review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3f27f98 and fa04ce0.

📒 Files selected for processing (3)
  • examples/MCP/simple_calculator_mcp/README.md
  • examples/MCP/simple_calculator_mcp/configs/config-mcp-client.yml
  • examples/MCP/simple_calculator_mcp/configs/config-per-user-mcp-client.yml

@willkill07
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit d40eb32 into NVIDIA:release/1.5 Mar 2, 2026
17 checks passed
Charlie-Yi-2002 pushed a commit to Charlie-Yi-2002/NeMo-Agent-Toolkit that referenced this pull request Mar 5, 2026
…1695)

- Explicitly specify timezone in MCP tool description.
- Add note in example README.

Closes

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing/index.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.




## Summary by CodeRabbit

* **Documentation**
  * Clarified timezone handling guidance for the MCP time tool to explicitly indicate America/Los_Angeles timezone usage across related configuration materials.

Authors:
  - Will Killian (https://github.com/willkill07)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

URL: NVIDIA#1695
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants