Skip to content

fix: toplevel pyproject.toml should specify tool.uv.managed=true#1783

Merged
rapids-bot[bot] merged 1 commit intoNVIDIA:release/1.5from
willkill07:wkk_fix-uv-managed-true
Mar 11, 2026
Merged

fix: toplevel pyproject.toml should specify tool.uv.managed=true#1783
rapids-bot[bot] merged 1 commit intoNVIDIA:release/1.5from
willkill07:wkk_fix-uv-managed-true

Conversation

@willkill07
Copy link
Member

@willkill07 willkill07 commented Mar 11, 2026

Description

Our internal scanning system seems to need this explicitly specified in order for scans to come back without error. During the package restructuring, the top-level added pyproject.toml omitted this stanza.

Closes

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Summary by CodeRabbit

  • Chores
    • Updated project configuration for virtual environment management.

Signed-off-by: Will Killian <wkillian@nvidia.com>
@willkill07 willkill07 requested a review from a team as a code owner March 11, 2026 00:40
@willkill07 willkill07 added bug Something isn't working non-breaking Non-breaking change labels Mar 11, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c1faf07b-0a8b-4f99-9dcd-628fe332a443

📥 Commits

Reviewing files that changed from the base of the PR and between 52e2103 and 29aab70.

📒 Files selected for processing (1)
  • pyproject.toml

Walkthrough

A single configuration line was added to pyproject.toml under the [tool.uv] section, introducing a managed = true flag to control virtual environment management behavior.

Changes

Cohort / File(s) Summary
UV Configuration
pyproject.toml
Added managed = true configuration entry under the [tool.uv] section to enable virtual environment management control.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise, descriptive, uses imperative mood with 'fix:', and clearly summarizes the main change of adding the missing tool.uv.managed=true configuration to pyproject.toml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@willkill07
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 69b3b46 into NVIDIA:release/1.5 Mar 11, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants