Skip to content

Treat a tagged commit the same as a nightly build#217

Merged
rapids-bot[bot] merged 8 commits intoNVIDIA:developfrom
dagardner-nv:david-rc-pipelines
May 6, 2025
Merged

Treat a tagged commit the same as a nightly build#217
rapids-bot[bot] merged 8 commits intoNVIDIA:developfrom
dagardner-nv:david-rc-pipelines

Conversation

@dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented May 6, 2025 •
edited
Loading

Description

  • Ensure that tagged (presumably rc tags) commits are marked as ready
  • Ensure that tagged commits on the develop branch are treated the same as nightly builds and internal dependencies are fully specified (aiqtoolkit==1.1.0rc2 rather than aiqtoolkit~=1.1)
  • Fix handling of the version for nightly builds
  • Fix out of date/incorrect/misleading comment

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv
Fix out of date/incorrect/misleading comment
4d95fb1 
Signed-off-by: David Gardner <dagardner@nvidia.com>
@dagardner-nv
Treat a tagged commit the same as a nightly build
cf5320c 
Signed-off-by: David Gardner <dagardner@nvidia.com>
@dagardner-nv
Exclude using full version for main branch builds
ceb3dd3 
Signed-off-by: David Gardner <dagardner@nvidia.com>
@dagardner-nv dagardner-nv self-assigned this May 6, 2025
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels May 6, 2025
@dagardner-nv dagardner-nv marked this pull request as draft May 6, 2025 18:29
@dagardner-nv
The most recent tag in the develop branch could be either a -dev or a…
825288e 
… -rc tag, adjust sed to match anything after a dash

Signed-off-by: David Gardner <dagardner@nvidia.com>
@AnuradhaKaruppiah AnuradhaKaruppiah requested a review from Copilot May 6, 2025 18:45
Copilot AI reviewed May 6, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (3)
  • ci/scripts/gitlab/artifactory_upload.sh: Language not supported
  • ci/scripts/gitlab/build_wheel.sh: Language not supported
  • ci/scripts/gitlab/common.sh: Language not supported

@dagardner-nv
Convert the unix return code into a boolean
93cda32 
Signed-off-by: David Gardner <dagardner@nvidia.com>
@dagardner-nv
Run upload on tags
00ca2cf 
Signed-off-by: David Gardner <dagardner@nvidia.com>
@dagardner-nv
Fix issue where SCRIPT_DIR was already defined by the build_wheel script
f623e66 
Signed-off-by: David Gardner <dagardner@nvidia.com>
@dagardner-nv
Install the dev packages ensuring that tomlkit and click are installe…
b1a8bdb 
…d both of which are needed for the ci/release/update_toml_dep.py script

Signed-off-by: David Gardner <dagardner@nvidia.com>
@dagardner-nv dagardner-nv marked this pull request as ready for review May 6, 2025 20:22
@dagardner-nv
Copy link
Contributor Author

dagardner-nv commented May 6, 2025

/merge

@rapids-bot rapids-bot bot merged commit 33fa5de into NVIDIA:develop May 6, 2025
10 checks passed
@dagardner-nv dagardner-nv deleted the david-rc-pipelines branch May 6, 2025 23:09
yczhang-nv pushed a commit to yczhang-nv/NeMo-Agent-Toolkit that referenced this pull request May 8, 2025
@dagardner-nv @yczhang-nv
Treat a tagged commit the same as a nightly build (NVIDIA#217)
9757fbe 
* Ensure that tagged (presumably rc tags) commits are marked as `ready`
* Ensure that tagged commits on the develop branch are treated the same as nightly builds and internal dependencies are fully specified (`aiqtoolkit==1.1.0rc2` rather than `aiqtoolkit~=1.1`)
* Fix handling of the version for nightly builds
* Fix out of date/incorrect/misleading comment

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

URL: NVIDIA#217
Signed-off-by: Yuchen Zhang <134643420+yczhang-nv@users.noreply.github.com>
yczhang-nv pushed a commit to yczhang-nv/NeMo-Agent-Toolkit that referenced this pull request May 9, 2025
@dagardner-nv @yczhang-nv
Treat a tagged commit the same as a nightly build (NVIDIA#217)
3e23ab6 
* Ensure that tagged (presumably rc tags) commits are marked as `ready`
* Ensure that tagged commits on the develop branch are treated the same as nightly builds and internal dependencies are fully specified (`aiqtoolkit==1.1.0rc2` rather than `aiqtoolkit~=1.1`)
* Fix handling of the version for nightly builds
* Fix out of date/incorrect/misleading comment

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

URL: NVIDIA#217
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
ericevans-nv pushed a commit to ericevans-nv/agent-iq that referenced this pull request Jun 3, 2025
@dagardner-nv @ericevans-nv
Treat a tagged commit the same as a nightly build (NVIDIA#217)
6117933 
* Ensure that tagged (presumably rc tags) commits are marked as `ready`
* Ensure that tagged commits on the develop branch are treated the same as nightly builds and internal dependencies are fully specified (`aiqtoolkit==1.1.0rc2` rather than `aiqtoolkit~=1.1`)
* Fix handling of the version for nightly builds
* Fix out of date/incorrect/misleading comment

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

URL: NVIDIA#217
Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
ericevans-nv pushed a commit to ericevans-nv/agent-iq that referenced this pull request Jun 3, 2025
@dagardner-nv @ericevans-nv
Treat a tagged commit the same as a nightly build (NVIDIA#217)
40f4f06 
* Ensure that tagged (presumably rc tags) commits are marked as `ready`
* Ensure that tagged commits on the develop branch are treated the same as nightly builds and internal dependencies are fully specified (`aiqtoolkit==1.1.0rc2` rather than `aiqtoolkit~=1.1`)
* Fix handling of the version for nightly builds
* Fix out of date/incorrect/misleading comment

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

URL: NVIDIA#217
Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
AnuradhaKaruppiah pushed a commit to AnuradhaKaruppiah/oss-agentiq that referenced this pull request Aug 4, 2025
@dagardner-nv
Treat a tagged commit the same as a nightly build (NVIDIA#217)
03da791 
* Ensure that tagged (presumably rc tags) commits are marked as `ready`
* Ensure that tagged commits on the develop branch are treated the same as nightly builds and internal dependencies are fully specified (`aiqtoolkit==1.1.0rc2` rather than `aiqtoolkit~=1.1`)
* Fix handling of the version for nightly builds
* Fix out of date/incorrect/misleading comment

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

URL: NVIDIA#217
scheckerNV pushed a commit to scheckerNV/aiq-factory-reset that referenced this pull request Aug 22, 2025
@dagardner-nv
Treat a tagged commit the same as a nightly build (NVIDIA#217)
c5aa0b2 
* Ensure that tagged (presumably rc tags) commits are marked as `ready`
* Ensure that tagged commits on the develop branch are treated the same as nightly builds and internal dependencies are fully specified (`aiqtoolkit==1.1.0rc2` rather than `aiqtoolkit~=1.1`)
* Fix handling of the version for nightly builds
* Fix out of date/incorrect/misleading comment

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

URL: NVIDIA#217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@AnuradhaKaruppiah AnuradhaKaruppiah AnuradhaKaruppiah approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dagardner-nv @AnuradhaKaruppiah