simple-calculator: Additional input validation#259
Merged
rapids-bot[bot] merged 6 commits intoNVIDIA:developfrom May 14, 2025
Merged
simple-calculator: Additional input validation#259rapids-bot[bot] merged 6 commits intoNVIDIA:developfrom
rapids-bot[bot] merged 6 commits intoNVIDIA:developfrom
Conversation
…eived
In some cases the tools are receiving more than 2xnumbers which causing
the workflow to spin.
Example:
[AGENT]
Calling tools: calculator_multiply
Tool's input: {"text": "60 * 39"}
Tool's response:
The product of 60 * 39 is 2340
------------------------------
2025-05-13 09:39:52,286 - aiq.agent.react_agent.agent - INFO -
------------------------------
[AGENT]
Agent input: What is 9 times 7, and is it greater than the current number of seconds since midnight?
Agent's thoughts:
Thought: Now that I have the product of 60 and 39, I can continue with the calculation to get the total number of seconds since midnight. I will add 2340 to 32400, then add 32.
Action: calculator_subtract
Action Input: {'text': '32400 + 2340 + 32'}
------------------------------
2025-05-13 09:39:52,291 - aiq.agent.react_agent.agent - INFO -
------------------------------
[AGENT]
Calling tools: calculator_subtract
Tool's input: {"text": "32400 + 2340 + 32"}
Tool's response:
The result of 32400 - 2340 is 30060
------------------------------
2025-05-13 09:39:56,498 - aiq.agent.react_agent.agent - INFO -
------------------------------
[AGENT]
Agent input: What is 9 times 7, and is it greater than the current number of seconds since midnight?
Agent's thoughts:
Thought: It seems there was an error in the previous calculation. The correct calculation should be 32400 + 2340 + 32. I will redo the calculation.
Signed-off-by: Anuradha Karuppiah <anuradhak@nvidia.com>
AnuradhaKaruppiah
added
bug
Signed-off-by: Anuradha Karuppiah <anuradhak@nvidia.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds input validation to the simple calculator tools to ensure they only operate on exactly two numbers, avoiding issues with extraneous inputs.
- Added validation for inequality, multiplication, division, and subtraction tools.
- Returns specific error messages when the number of provided numeric inputs is not exactly two.
examples/simple_calculator/src/aiq_simple_calculator/register.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Anuradha Karuppiah <anuradhak@nvidia.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Anuradha Karuppiah <anuradha.karuppiah@gmail.com>
Signed-off-by: Anuradha Karuppiah <anuradhak@nvidia.com>
dnandakumar-nv
approved these changes
May 14, 2025
Contributor
Author
|
/merge |
ericevans-nv
pushed a commit
to ericevans-nv/agent-iq
that referenced
this pull request
Jun 3, 2025
Closes ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Dhruv Nandakumar (https://github.com/dnandakumar-nv) URL: NVIDIA#259 Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
ericevans-nv
pushed a commit
to ericevans-nv/agent-iq
that referenced
this pull request
Jun 3, 2025
Closes ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Dhruv Nandakumar (https://github.com/dnandakumar-nv) URL: NVIDIA#259 Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
AnuradhaKaruppiah
added a commit
to AnuradhaKaruppiah/oss-agentiq
that referenced
this pull request
Aug 4, 2025
Closes ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Dhruv Nandakumar (https://github.com/dnandakumar-nv) URL: NVIDIA#259
scheckerNV
pushed a commit
to scheckerNV/aiq-factory-reset
that referenced
this pull request
Aug 22, 2025
Closes ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Dhruv Nandakumar (https://github.com/dnandakumar-nv) URL: NVIDIA#259
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes two changes:
In some cases the tools are receiving more than 2xnumbers which is causing the workflow to spin.
Example:
This PR validates the number of "numbers" received
Description
Closes
By Submitting this PR I confirm: