Run tests on all supported versions of Python#283
Merged
rapids-bot[bot] merged 6 commits intoNVIDIA:developfrom May 15, 2025
Merged
Run tests on all supported versions of Python#283rapids-bot[bot] merged 6 commits intoNVIDIA:developfrom
rapids-bot[bot] merged 6 commits intoNVIDIA:developfrom
Conversation
Signed-off-by: David Gardner <dagardner@nvidia.com>
dagardner-nv
added
improvement
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
willkill07
approved these changes
May 15, 2025
Member
willkill07
left a comment
willkill07
left a comment
There was a problem hiding this comment.
One minor nit but otherwise LGTM
Co-authored-by: Will Killian <2007799+willkill07@users.noreply.github.com> Signed-off-by: David Gardner <96306125+dagardner-nv@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR expands the test matrix to run tests on Python 3.11 and 3.12 by updating the CI configuration and enhancing test logging.
- Updated test logging in ci/scripts/github/tests.sh to display the Python and pytest versions along with architecture.
- Enhanced GitHub workflow configurations in .github/workflows/pr.yaml and .github/workflows/ci_pipe.yml to include separate container parameters and matrix entries for Python 3.11 and 3.12.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ci/scripts/github/tests.sh | Enhanced test logging to include Python and pytest version information. |
| .github/workflows/pr.yaml | Added container parameters for Python 3.11 and Python 3.12. |
| .github/workflows/ci_pipe.yml | Updated workflow inputs and matrix to support dual Python version testing. |
Comments suppressed due to low confidence (1)
.github/workflows/ci_pipe.yml:104
- [nitpick] Consider using a consistent naming convention for Python version keys (for example, 'python_version' in snake_case) to align with the container input names, which may improve overall readability.
python-version: ["3.11", "3.12"]
AnuradhaKaruppiah
approved these changes
May 15, 2025
Contributor
Author
|
/merge |
ericevans-nv
pushed a commit
to ericevans-nv/agent-iq
that referenced
this pull request
Jun 3, 2025
* Adds Python version to the matrix for the test stage Closes NVIDIA#199 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Will Killian (https://github.com/willkill07) - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#283 Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
ericevans-nv
pushed a commit
to ericevans-nv/agent-iq
that referenced
this pull request
Jun 3, 2025
* Adds Python version to the matrix for the test stage Closes NVIDIA#199 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Will Killian (https://github.com/willkill07) - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#283 Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
AnuradhaKaruppiah
pushed a commit
to AnuradhaKaruppiah/oss-agentiq
that referenced
this pull request
Aug 4, 2025
* Adds Python version to the matrix for the test stage Closes NVIDIA#199 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Will Killian (https://github.com/willkill07) - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#283
scheckerNV
pushed a commit
to scheckerNV/aiq-factory-reset
that referenced
this pull request
Aug 22, 2025
* Adds Python version to the matrix for the test stage Closes NVIDIA#199 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Will Killian (https://github.com/willkill07) - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#283
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #199
By Submitting this PR I confirm: