Skip to content

Toolcalling prompt#617

Merged
rapids-bot[bot] merged 2 commits intoNVIDIA:developfrom
gfreeman-nvidia:toolcalling_prompt
Aug 19, 2025
Merged

Toolcalling prompt#617
rapids-bot[bot] merged 2 commits intoNVIDIA:developfrom
gfreeman-nvidia:toolcalling_prompt

Conversation

@gfreeman-nvidia
Copy link
Contributor

Description

Add system_prompt and additional instructions to toolcalling_agent.
Log the tool calling information in LLM outputs when it is included.

Closes #150

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 11, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yczhang-nv yczhang-nv added bug Something isn't working non-breaking Non-breaking change labels Aug 19, 2025
@yczhang-nv
Copy link
Contributor

/ok to test 86d6345

@yczhang-nv
Copy link
Contributor

/ok to test e0fd808

Log langchain tool calls in llm output when included.

Signed-off-by: Greg Freeman <gfreeman@nvidia.com>
@yczhang-nv
Copy link
Contributor

/ok to test defda82

Signed-off-by: Greg Freeman <gfreeman@nvidia.com>
@yczhang-nv
Copy link
Contributor

/ok to test 44ad005

@yczhang-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 9e84463 into NVIDIA:develop Aug 19, 2025
12 checks passed
saglave pushed a commit to snps-scm13/SNPS-NeMo-Agent-Toolkit that referenced this pull request Sep 2, 2025
Add system_prompt and additional instructions to toolcalling_agent.
Log the tool calling information in LLM outputs when it is included.

Closes NVIDIA#150

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - https://github.com/gfreeman-nvidia

Approvers:
  - Yuchen Zhang (https://github.com/yczhang-nv)

URL: NVIDIA#617
Signed-off-by: Sangharsh Aglave <aglave@synopsys.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEA]: tool_calling_agent with system_prompt

2 participants