Skip to content

Configure coderabbit not to apply conflicting labels#714

Merged
rapids-bot[bot] merged 2 commits intoNVIDIA:developfrom
dagardner-nv:david-label-conflict
Aug 25, 2025
Merged

Configure coderabbit not to apply conflicting labels#714
rapids-bot[bot] merged 2 commits intoNVIDIA:developfrom
dagardner-nv:david-label-conflict

Conversation

@dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Aug 25, 2025

Description

  • Tell coderabbit not to apply conflicting labels if they already exist on a PR

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Summary by CodeRabbit

  • Chores
    • Tightened PR labeling rules to enforce mutual exclusivity:
      • “Breaking” vs “Non-breaking” cannot co-exist; duplicates are prevented.
      • “Bug,” “Doc,” “Feature request,” and “Improvement” are mutually exclusive and won’t duplicate.
    • Improves label consistency and avoids conflicting states during triage.
    • No changes to other moderation labels (e.g., DO NOT MERGE, invalid).

… on a PR

Signed-off-by: David Gardner <dagardner@nvidia.com>
@dagardner-nv dagardner-nv self-assigned this Aug 25, 2025
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels Aug 25, 2025
@coderabbitai
Copy link

coderabbitai bot commented Aug 25, 2025

Warning

Rate limit exceeded

@dagardner-nv has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 8 minutes and 31 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 7e70624 and 3e0c6b5.

📒 Files selected for processing (1)
  • .coderabbit.yaml (4 hunks)

Walkthrough

The PR updates .coderabbit.yaml label instructions to enforce mutual exclusivity. It adds explicit “do not apply if already present” checks for the breaking/non-breaking pair and for the bug/doc/feature request/improvement group. No other label blocks are changed.

Changes

Cohort / File(s) Summary of Changes
Label rules updates
\.coderabbit.yaml
Updated instructions for labels: breaking, non-breaking, bug, doc, feature request, improvement to add explicit mutual-exclusivity checks within their respective groups. No content change for duplicate label noted.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant PR as PR
    participant Bot as Labeler Bot (.coderabbit.yaml rules)
    participant GH as GitHub Labels

    rect rgba(225,245,254,0.6)
    note over Bot: Apply breaking/non-breaking labels
    PR->>Bot: Request label: breaking or non-breaking
    Bot->>GH: Check existing labels (breaking/non-breaking)
    alt existing in {breaking, non-breaking}
        Bot-->>PR: Do not apply label
    else no conflicting label
        Bot->>GH: Apply requested label
        GH-->>PR: Label applied
    end
    end

    rect rgba(232,245,233,0.6)
    note over Bot: Apply bug/doc/feature request/improvement labels
    PR->>Bot: Request label: bug/doc/feature request/improvement
    Bot->>GH: Check existing labels in group
    alt existing in {bug, doc, feature request, improvement}
        Bot-->>PR: Do not apply label
    else no conflicting label
        Bot->>GH: Apply requested label
        GH-->>PR: Label applied
    end
    end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Add Coderabbit config #710 — Also modifies .coderabbit.yaml label definitions/instructions for the same label groups, indicating a closely related configuration change.

Suggested labels

improvement

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dagardner-nv
Copy link
Contributor Author

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Aug 25, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai coderabbitai bot added the improvement Improvement to existing functionality label Aug 25, 2025
@dagardner-nv dagardner-nv removed the improvement Improvement to existing functionality label Aug 25, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (5)
.coderabbit.yaml (5)

129-131: Tighten phrasing and fix minor grammar for multi-category exclusivity

Use “any of … labels” (plural) for clarity with 4-way exclusivity and add a missing comma after “apply this label”. This keeps instructions concise and LLM-friendly without changing intent.

Apply this diff:

-        apply this label do not apply the "doc", "feature request", or "improvement" labels. If the PR already has
-        either the "bug", "doc", "feature request", or "improvement" label, do not apply this label.
+        apply this label, do not apply the "doc", "feature request", or "improvement" labels. If the PR already has
+        any of the "bug", "doc", "feature request", or "improvement" labels, do not apply this label.

139-141: Normalize spacing and wording; remove double space and pluralize “labels”

Same suggestion as for “bug”; also remove the double space before “If the PR…”.

Apply this diff:

-        apply this label do not apply the "bug", "feature request", or "improvement" labels.  If the PR already has
-        either the "bug", "doc", "feature request", or "improvement" label, do not apply this label.
+        apply this label, do not apply the "bug", "feature request", or "improvement" labels. If the PR already has
+        any of the "bug", "doc", "feature request", or "improvement" labels, do not apply this label.

152-154: Consistent exclusivity phrasing across the 4-way group

Align wording with the other entries for consistency and readability.

Apply this diff:

-        to the toolkit. If you apply this label do not apply the "bug", "doc", or "improvement" labels. If the PR
-        already has either the "bug", "doc", "feature request", or "improvement" label, do not apply this label.
+        to the toolkit. If you apply this label, do not apply the "bug", "doc", or "improvement" labels. If the PR
+        already has any of the "bug", "doc", "feature request", or "improvement" labels, do not apply this label.

158-159: Fix punctuation and pluralization; remove double space

Keep copy uniform with the other mutually exclusive labels.

Apply this diff:

-        the "bug", "doc", or "feature request" labels.  If the PR already has either the "bug", "doc",
-        "feature request", or "improvement" label, do not apply this label.
+        the "bug", "doc", or "feature request" labels. If the PR already has any of the "bug", "doc",
+        "feature request", or "improvement" labels, do not apply this label.

168-169: Minor copy edit: remove double space and simplify label mentions

For two-way exclusivity, “either … or …” is fine; also drop redundant trailing “label” and the extra space.

Apply this diff:

-        apply the "breaking" label.  If the PR already has either the "breaking" or "non-breaking" label, do not apply
-        this label.
+        apply the "breaking" label. If the PR already has either "breaking" or "non-breaking", do not apply this label.
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between b716b7d and 7e70624.

📒 Files selected for processing (1)
  • .coderabbit.yaml (4 hunks)
🔇 Additional comments (1)
.coderabbit.yaml (1)

121-126: Mutual exclusivity for breaking/non-breaking — LGTM

The added guard against re-applying or cross-applying breaking vs non-breaking matches the PR objective and should reduce label flip-flops when auto-apply is enabled.

Signed-off-by: David Gardner <dagardner@nvidia.com>
@dagardner-nv
Copy link
Contributor Author

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Aug 25, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 993bde7 into NVIDIA:develop Aug 25, 2025
15 checks passed
@dagardner-nv dagardner-nv deleted the david-label-conflict branch August 25, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants