Skip to content

Remove conflicting/redundant langchain-milvus deps#754

Merged
rapids-bot[bot] merged 1 commit intoNVIDIA:developfrom
dagardner-nv:david-just-one-milvus
Sep 4, 2025
Merged

Remove conflicting/redundant langchain-milvus deps#754
rapids-bot[bot] merged 1 commit intoNVIDIA:developfrom
dagardner-nv:david-just-one-milvus

Conversation

@dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Sep 4, 2025

Description

Closes #753

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Summary by CodeRabbit

  • Chores
    • Removed an outdated langchain-milvus dependency version to standardize on the newer release.
    • Simplifies installation and reduces potential version conflicts; no functional changes expected for end-users.

Signed-off-by: David Gardner <dagardner@nvidia.com>
@dagardner-nv dagardner-nv self-assigned this Sep 4, 2025
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels Sep 4, 2025
@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 4, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai
Copy link

coderabbitai bot commented Sep 4, 2025

Walkthrough

Removed duplicate/conflicting dependency entry for langchain-milvus by deleting version ~=0.1.5 from packages/nvidia_nat_langchain/pyproject.toml, leaving ~=0.1.8 intact. No other files or settings were changed.

Changes

Cohort / File(s) Summary
Dependency cleanup
packages/nvidia_nat_langchain/pyproject.toml
Removed langchain-milvus~=0.1.5 from dependencies; retained langchain-milvus~=0.1.8.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Assessment against linked issues

Objective Addressed Explanation
Resolve conflicting dependencies for langchain-milvus [#753]

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 6cf8a06 and 3f87458.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • packages/nvidia_nat_langchain/pyproject.toml (0 hunks)
💤 Files with no reviewable changes (1)
  • packages/nvidia_nat_langchain/pyproject.toml
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dagardner-nv
Copy link
Contributor Author

/ok to test 3f87458

@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit cb9ab0e into NVIDIA:develop Sep 4, 2025
15 checks passed
@dagardner-nv dagardner-nv deleted the david-just-one-milvus branch September 4, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conflicting dependencies for langchain-milvus

2 participants