Skip to content

Remove issue #72 from list of known issues#779

Merged
rapids-bot[bot] merged 1 commit intoNVIDIA:developfrom
dagardner-nv:david-remove-72-known-issue
Sep 9, 2025
Merged

Remove issue #72 from list of known issues#779
rapids-bot[bot] merged 1 commit intoNVIDIA:developfrom
dagardner-nv:david-remove-72-known-issue

Conversation

@dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Sep 9, 2025

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Summary by CodeRabbit

  • Documentation
    • Updated release notes by removing the outdated Known Issue stating Faiss is broken on Arm64. The rest of the Known Issues section remains unchanged.
    • Clarifies current platform status and reduces confusion for Arm64 users.
    • No changes to application behavior, configuration, or compatibility.
    • No code or public API modifications included in this update.

Signed-off-by: David Gardner <dagardner@nvidia.com>
@dagardner-nv dagardner-nv self-assigned this Sep 9, 2025
@dagardner-nv dagardner-nv added doc Improvements or additions to documentation non-breaking Non-breaking change labels Sep 9, 2025
@coderabbitai
Copy link

coderabbitai bot commented Sep 9, 2025

Walkthrough

Removed a single bullet from the Known Issues section in docs/source/release-notes.md referring to Faiss being broken on Arm64. No code or API changes.

Changes

Cohort / File(s) Summary of Changes
Documentation
docs/source/release-notes.md
Removed the Known Issues bullet about Faiss being broken on Arm64 (linking to issue #72). No other content changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks (2 passed, 1 warning)

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The description consists solely of a generic contributor checklist and does not mention the actual change of removing issue #72 from the Known Issues section in the release notes. This makes it unrelated to the documented modification and leaves out any summary of the actual update. Please update the description to clearly state that this PR removes the reference to issue #72 from the Known Issues section in docs/source/release-notes.md and note that it is a documentation-only change without any code or API modifications.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title “Remove issue #72 from list of known issues” succinctly and accurately summarizes the primary documentation change by stating the action in the imperative mood. At 42 characters it stays well under the 72-character limit and clearly communicates that a specific known-issues entry is being removed. It meets the concise, descriptive, and imperative requirements for a pull request title.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c0e7ba2 and fcded66.

📒 Files selected for processing (1)
  • docs/source/release-notes.md (0 hunks)
💤 Files with no reviewable changes (1)
  • docs/source/release-notes.md
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@willkill07 willkill07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, i thought this was under the Release 1.0.0 header

@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 5852d3a into NVIDIA:develop Sep 9, 2025
17 checks passed
@dagardner-nv dagardner-nv deleted the david-remove-72-known-issue branch September 9, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Improvements or additions to documentation non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants