Require approval from the nat-dep-approvers group for dependency changes

[dagardner-nv]

By Submitting this PR I confirm:

• I am familiar with the Contributing Guidelines.
• We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  • Any contribution which contains commits that are not Signed-Off will not be accepted.
• When the PR is ready for review, new or existing tests cover these changes.
• When the PR is ready for review, the documentation is up to date with these changes.

Summary by CodeRabbit

• Chores
  • Updated default reviewer team for approvals to @nvidia/nat-developers.
  • Added a dedicated dependency-change section that routes lockfile approvals to @nvidia/nat-dep-approvers.
  • No other approval rules changed.
  • No user-facing behavior or API changes.

[coderabbitai]

Walkthrough

Updated .github/CODEOWNERS: changed the default approval group from @nvidia/aiqtoolkit-developers to @nvidia/nat-developers and added a new "Dependency changes" entry assigning uv.lock approvals to @nvidia/nat-dep-approvers.

Changes

Cohort / File(s)	Summary of changes
CODEOWNERS — default approver change .github/CODEOWNERS	Replaced default approval group: @nvidia/aiqtoolkit-developers → @nvidia/nat-developers.
CODEOWNERS — dependency approvals .github/CODEOWNERS	Added a "Dependency changes" section mapping uv.lock to @nvidia/nat-dep-approvers.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks (2 passed, 1 warning)

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title Check	⚠️ Warning	The current title clearly describes the change and uses the imperative mood but exceeds the recommended maximum of approximately 72 characters by two, so it does not fully comply with the length requirement.	Please shorten the title to under 72 characters—for example by removing the backticks around nat-dep-approvers—resulting in something like: "Require approval from the nat-dep-approvers group for dependency changes".

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9c793cb and af16ce1.

📒 Files selected for processing (1)

• .github/CODEOWNERS (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-08-28T23:22:41.742Z

Learnt from: CR
PR: NVIDIA/NeMo-Agent-Toolkit#0
File: .cursor/rules/general.mdc:0-0
Timestamp: 2025-08-28T23:22:41.742Z
Learning: Applies to packages/*/pyproject.toml : Package pyproject.toml must depend on nvidia-nat or a package starting with nvidia-nat- using ~=<two-digit> versions (e.g., ~=1.0)

Applied to files:

• .github/CODEOWNERS

🔇 Additional comments (1)

.github/CODEOWNERS (1)

2-2: Verify “Require review from Code Owners” on the develop branch
The GitHub CLI check returned a 403 and null, so please manually confirm in the repository’s Branch Protection settings that the develop branch has “Require pull request reviews from Code Owners” enabled.

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

.github/CODEOWNERS (2)

5-5: Confirm scope: root-only vs any uv.lock

Unanchored pattern matches in any folder. If you intend to gate only the root lockfile, anchor it.

Apply this if root-only was intended:

-uv.lock @nvidia/nat-dep-approvers
+/uv.lock @nvidia/nat-dep-approvers

---

4-5: Optional: Cover other dep manifests if present

If the repo includes any of these, consider adding them to the same approver group: requirements*.txt, constraints*.txt, Pipfile, Pipfile.lock, poetry.lock, environment*.yml (Conda), conda-lock*.yaml.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6ce6229 and 9c793cb.

📒 Files selected for processing (1)

• .github/CODEOWNERS (1 hunks)

🔇 Additional comments (2)

.github/CODEOWNERS (2)

4-5: LGTM: Specific rule for uv.lock correctly overrides the default owners

Placement after the catch‑all and file‑specific pattern are both correct.

---

4-5: Verify team and branch protection settings
Team nat-dep-approvers was not found in the NVIDIA org (HTTP 404). Confirm the correct team slug, ensure it has write access to the repo, and verify that “Require review from Code Owners” is enabled on the develop branch.

[dagardner-nv]

/merge