Add GitHub Release Notes Template#808
Conversation
Signed-off-by: Will Killian <wkillian@nvidia.com>
WalkthroughAdds Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
.github/release.yml (3)
3-6: Don’t exclude Dependabot; instead, surface dependency bumps in a dedicated section.Excluding dependabot* removes useful dependency updates from release notes. Prefer a Dependencies category and keep bots included.
changelog: exclude: authors: - octocat - - dependabot[bot] - - dependabot-preview[bot] categories: + - title: Dependencies 📦 + labels: + - dependencies + - "chore(deps)" + - dep - title: Other Changes labels: - "*"Also applies to: 23-25
1-1: Process nits: fix PR “Closes” field and align with CHANGELOG policy.
- Add a real issue number to the “Closes” field before merge.
- Team norm reminder from learnings: if maintaining CHANGELOG.md manually, clarify whether autogenerated notes supplement or replace it to avoid divergence.
1-6: Optional: support a "skip-changelog" escape hatch — no matching label foundFile: .github/release.yml (lines 1–6). Checked repo labels via gh API — only "skip-ci" exists; no "skip-changelog" or "no-changelog". If you want a label-driven escape hatch, create a 'skip-changelog' or 'no-changelog' label and add it under changelog.exclude.labels in .github/release.yml.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/release.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-08-28T23:22:41.742Z
Learnt from: CR
PR: NVIDIA/NeMo-Agent-Toolkit#0
File: .cursor/rules/general.mdc:0-0
Timestamp: 2025-08-28T23:22:41.742Z
Learning: Applies to CHANGELOG.md : Add user‑visible changes to CHANGELOG.md under the appropriate section
Applied to files:
.github/release.yml
📚 Learning: 2025-08-28T23:22:41.742Z
Learnt from: CR
PR: NVIDIA/NeMo-Agent-Toolkit#0
File: .cursor/rules/general.mdc:0-0
Timestamp: 2025-08-28T23:22:41.742Z
Learning: Applies to CHANGELOG.md : Do not change the content of CHANGELOG.md except to add user‑visible changes under the appropriate section
Applied to files:
.github/release.yml
🔇 Additional comments (2)
.github/release.yml (2)
23-25: Catch‑all category is correctly configured.labels: ["*"] ensures nothing is dropped. Good.
8-22: Label mappings validated — no changes requiredAll labels referenced in .github/release.yml (breaking, feature request, improvement, bug, doc) exist in the repository; release sections will not be empty.
Signed-off-by: Will Killian <wkillian@nvidia.com>
|
/merge |
Description
This PR adds a
release.ymltemplate for NAT as outlined in GitHub documentation: https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notesCloses
By Submitting this PR I confirm:
Summary by CodeRabbit