Skip to content

Update RedisEditor to retrieve full document data from Redis when using get_memory tool#823

Merged
rapids-bot[bot] merged 1 commit intoNVIDIA:developfrom
thepatrickchin:redis-bugfix
Sep 19, 2025
Merged

Update RedisEditor to retrieve full document data from Redis when using get_memory tool#823
rapids-bot[bot] merged 1 commit intoNVIDIA:developfrom
thepatrickchin:redis-bugfix

Conversation

@thepatrickchin
Copy link
Member

Description

Updates RedisEditor search method to retrieve full document data from Redis. Previously, search results only included indexable fields including id, payload, score, user_id, tags, memory. Conversations and metadata fields would be lost when returning the search results. This bugfix will fetch and return the full document object using the document ID.

Closes #821

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

- previously documents returned in search results only included indexable fields including id, payload, score, user_id, tags, memory. Conversations and metadata fields would be lost when returning the search results
- solution was to fetch and return the full document object using the document ID

Signed-off-by: Patrick Chin <8509935+thepatrickchin@users.noreply.github.com>
@thepatrickchin thepatrickchin requested a review from a team as a code owner September 19, 2025 15:35
@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 19, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@willkill07 willkill07 added bug Something isn't working non-breaking Non-breaking change labels Sep 19, 2025
@willkill07
Copy link
Member

/ok to test 11e04eb

@willkill07
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 43754c6 into NVIDIA:develop Sep 19, 2025
17 checks passed
@thepatrickchin thepatrickchin deleted the redis-bugfix branch October 21, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get_memory tool omits metadata and conversation fields in Redis search results

2 participants