Avoid calling 'git lfs install' as CI already performs this#833
Merged
rapids-bot[bot] merged 1 commit intoNVIDIA:developfrom Sep 22, 2025
Merged
Conversation
Signed-off-by: David Gardner <dagardner@nvidia.com>
WalkthroughRemoved the git lfs install step from get_lfs_files in ci/scripts/common.sh. The function now directly runs git lfs fetch and git lfs pull when not using host git, changing the control flow within the CI script. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor CI as CI Runner
participant SH as common.sh:get_lfs_files
participant G as git (LFS)
rect rgb(240,245,255)
note over CI: Previous flow
CI->>SH: invoke get_lfs_files
SH->>G: git lfs install
SH->>G: git lfs fetch
SH->>G: git lfs pull
SH-->>CI: done
end
sequenceDiagram
autonumber
actor CI as CI Runner
participant SH as common.sh:get_lfs_files
participant G as git (LFS)
rect rgb(240,255,240)
note over CI: New flow
CI->>SH: invoke get_lfs_files
SH->>G: git lfs fetch
SH->>G: git lfs pull
SH-->>CI: done
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
willkill07
approved these changes
Sep 22, 2025
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
By Submitting this PR I confirm:
Summary by CodeRabbit