Skip to content

Declare pip as a direct dependency #871

Merged
rapids-bot[bot] merged 1 commit intoNVIDIA:developfrom
dagardner-nv:david-pip-dep
Sep 29, 2025
Merged

Declare pip as a direct dependency #871
rapids-bot[bot] merged 1 commit intoNVIDIA:developfrom
dagardner-nv:david-pip-dep

Conversation

@dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Sep 29, 2025

Description

  • Currently we declare pip as a dev dependency, however the nat workflow create depends on it.

Closes #864

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Summary by CodeRabbit

  • Chores
    • Elevated the pip requirement (pip>=24.3.1) from a dev-only constraint to a general installation dependency to standardize environments across all installs.
    • Improves reliability of package installation and reduces environment inconsistencies; no changes to app behavior.
    • Users with older pip versions may need to upgrade pip before installing to avoid setup issues.
    • No action needed if you already use pip>=24.3.1.

…kflow create' requires it

Signed-off-by: David Gardner <dagardner@nvidia.com>
@dagardner-nv dagardner-nv self-assigned this Sep 29, 2025
@dagardner-nv dagardner-nv requested review from a team as code owners September 29, 2025 19:17
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels Sep 29, 2025
@coderabbitai
Copy link

coderabbitai bot commented Sep 29, 2025

Walkthrough

Shifted the pip requirement from the dev dependency group to main dependencies in pyproject.toml, moving "pip>=24.3.1" into the primary dependencies and removing it from the dev group. No runtime code changes.

Changes

Cohort / File(s) Summary
Dependency management
pyproject.toml
Added pip>=24.3.1 to main dependencies; removed the same spec from the dev dependency group. Adjusts installation behavior so pip is required in general installs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "Declare pip as a direct dependency" is concise (37 characters), uses imperative mood, and is well within the 72-character limit specified in the requirements. The title accurately describes the main change in the changeset, which moves the pip dependency from the dev dependency group to the general dependencies list in pyproject.toml. The title directly corresponds to what the code changes accomplish and clearly summarizes the modification.
Linked Issues Check ✅ Passed The code changes directly address the objective from linked issue #864, which reports a FileNotFoundError when running nat workflow create after installing NAT via pip. The issue occurs because the pip executable is needed at runtime but was only declared as a dev dependency. By moving "pip>=24.3.1" from the dev dependency group to the main dependencies list in pyproject.toml, the PR ensures that pip will be available when NAT is installed from pip, resolving the runtime error. The change aligns perfectly with the requirement to make the pip executable available to NAT at runtime.
Out of Scope Changes Check ✅ Passed All changes in this PR are directly in scope and related to the linked issue #864. The PR makes a single, focused change to pyproject.toml by moving the pip dependency specification from the dev dependency group to the main dependencies list. This is exactly what is needed to resolve the runtime error described in issue #864 where the pip executable is not found. There are no modifications to runtime logic, control flow, or any other files that would be considered out of scope.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d0804b9 and 649babc.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*

⚙️ CodeRabbit configuration file

**/*: # Code Review Instructions

  • Ensure the code follows best practices and coding standards. - For Python code, follow
    PEP 20 and
    PEP 8 for style guidelines.
  • Check for security vulnerabilities and potential issues. - Python methods should use type hints for all parameters and return values.
    Example:
    def my_function(param1: int, param2: str) -> bool:
        pass
  • For Python exception handling, ensure proper stack trace preservation:
    • When re-raising exceptions: use bare raise statements to maintain the original stack trace,
      and use logger.error() (not logger.exception()) to avoid duplicate stack trace output.
    • When catching and logging exceptions without re-raising: always use logger.exception()
      to capture the full stack trace information.

Documentation Review Instructions - Verify that documentation and comments are clear and comprehensive. - Verify that the documentation doesn't contain any TODOs, FIXMEs or placeholder text like "lorem ipsum". - Verify that the documentation doesn't contain any offensive or outdated terms. - Verify that documentation and comments are free of spelling mistakes, ensure the documentation doesn't contain any

words listed in the ci/vale/styles/config/vocabularies/nat/reject.txt file, words that might appear to be
spelling mistakes but are listed in the ci/vale/styles/config/vocabularies/nat/accept.txt file are OK.

Misc. - All code (except .mdc files that contain Cursor rules) should be licensed under the Apache License 2.0,

and should contain an Apache License 2.0 header comment at the top of each file.

  • Confirm that copyright years are up-to date whenever a file is changed.

Files:

  • pyproject.toml
🔇 Additional comments (1)
pyproject.toml (1)

40-40: pip version verified and constraint style is acceptable.

The addition of pip>=24.3.1 to main dependencies is correct:

  • pip version 24.3.1 exists and is valid (latest is 25.2)
  • The >= constraint has precedent in the codebase (e.g., aioboto3>=11.0.0 on line 21)
  • Alphabetical ordering is maintained correctly
  • This appropriately addresses the runtime requirement

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🧪 Early access (Sonnet 4.5): enabled

We are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

  • Public repositories are always opted into early access features.
  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit eb08c6e into NVIDIA:develop Sep 29, 2025
17 checks passed
@dagardner-nv dagardner-nv deleted the david-pip-dep branch September 29, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No such file or directory: 'pip'

3 participants