Skip to content

Set the title warning to an error#918

Merged
rapids-bot[bot] merged 1 commit intoNVIDIA:release/1.3from
dagardner-nv:david-title-error
Oct 6, 2025
Merged

Set the title warning to an error#918
rapids-bot[bot] merged 1 commit intoNVIDIA:release/1.3from
dagardner-nv:david-title-error

Conversation

@dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Oct 6, 2025

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Summary by CodeRabbit

  • Chores
    • Updated pre-merge checks to treat PR title non-compliance as an error instead of a warning. Non-compliant titles will now block merging until corrected, improving consistency and enforcement in the review workflow. No changes to the requirements text or other settings. Applies to all new pull requests and updates, ensuring clearer feedback and stricter gatekeeping.

Signed-off-by: David Gardner <dagardner@nvidia.com>
@dagardner-nv dagardner-nv self-assigned this Oct 6, 2025
@dagardner-nv dagardner-nv requested a review from a team as a code owner October 6, 2025 16:02
@dagardner-nv dagardner-nv added improvement Improvement to existing functionality non-breaking Non-breaking change labels Oct 6, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 6, 2025

Walkthrough

Updated .coderabbit.yaml to change pre_merge_checks.title.mode from warning to error, altering pre-merge validation handling for title compliance. Other configuration fields remain unchanged.

Changes

Cohort / File(s) Summary
Config: pre_merge_checks severity
./.coderabbit.yaml
Set pre_merge_checks.title.mode from warning to error, escalating title non-compliance; no changes to requirements text or other fields.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Dev as Developer
  participant PR as Pull Request
  participant CR as CodeRabbit Pre-merge Checks

  Dev->>PR: Open/Update PR
  PR->>CR: Run pre_merge_checks

  rect rgba(200,200,255,0.25)
  note over CR: Title Compliance Check
  CR->>CR: Validate PR title
  end

  alt Previous: mode=warning
    CR-->>PR: Emit warning (non-blocking)
    PR-->>Dev: PR can proceed with warning
  else Current: mode=error
    CR-->>PR: Return error (blocking)
    PR-->>Dev: Merge blocked until title fixed
  end
Loading

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title uses an imperative verb, clearly describes the change to upgrade the title warning to an error, and is concise under the 72-character limit.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 36e0595 and 37885b5.

📒 Files selected for processing (1)
  • .coderabbit.yaml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 9cc7c9b into NVIDIA:release/1.3 Oct 6, 2025
17 checks passed
@dagardner-nv dagardner-nv deleted the david-title-error branch October 6, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement to existing functionality non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants