Attempt to fix wheel metadata#958
Merged
rapids-bot[bot] merged 9 commits intoNVIDIA:release/1.3from Oct 8, 2025
Merged
Conversation
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
…to david-lic-meta-wheel Signed-off-by: David Gardner <dagardner@nvidia.com>
|
Warning Rate limit exceeded@dagardner-nv has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 16 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughConvert many packages' pyproject.toml [project].license from a string to an inline table format (license = { text = "Apache-2.0" }); remove a few Changes
Sequence Diagram(s)(Skipped — changes are metadata and static files; no runtime/control-flow modifications to diagram.) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 20
♻️ Duplicate comments (10)
packages/nvidia_nat_all/LICENSE.md (1)
1-1: Same license pointer issue as noted earlier
See the compliance warning on packages/nvidia_nat_weave/LICENSE.md—this file needs the real license text too.packages/nvidia_nat_zep_cloud/LICENSE.md (1)
1-1: Same license pointer issue as noted earlier
Please apply the fix described for packages/nvidia_nat_weave/LICENSE.md here as well.packages/nvidia_nat_adk/LICENSE.md (1)
1-1: Same license pointer issue as noted earlier
This package also needs the actual Apache 2.0 text in LICENSE.md.packages/nvidia_nat_adk/LICENSE-3rd-party.txt (1)
1-1: Same third-party notice issue as noted earlier
Mirror the fix suggested for packages/nvidia_nat_semantic_kernel/LICENSE-3rd-party.txt here.packages/nvidia_nat_profiling/LICENSE.md (1)
1-1: Same license pointer issue as noted earlier
Ensure this LICENSE.md carries the full license text, matching the guidance for packages/nvidia_nat_weave/LICENSE.md.packages/nvidia_nat_crewai/LICENSE-3rd-party.txt (1)
1-1: Same license pointer concern as opentelemetryThis file has the identical relative-pointer problem noted for
packages/nvidia_nat_opentelemetry/LICENSE-3rd-party.txt; please address it there and apply the same fix here.packages/nvidia_nat_profiling/LICENSE-3rd-party.txt (1)
1-1: Same license pointer concern as opentelemetryThis file has the identical relative-pointer problem noted for
packages/nvidia_nat_opentelemetry/LICENSE-3rd-party.txt; please address it there and apply the same fix here.packages/nvidia_nat_phoenix/LICENSE-3rd-party.txt (1)
1-1: Same license pointer concern as opentelemetryThis file has the identical relative-pointer problem noted for
packages/nvidia_nat_opentelemetry/LICENSE-3rd-party.txt; please address it there and apply the same fix here.packages/nvidia_nat_opentelemetry/LICENSE.md (1)
1-1: Same license pointer concern as nvidia_nat_agno/LICENSE.mdThis file ships only a
../../LICENSE.mdpointer; please embed the real license text as noted earlier.packages/nvidia_nat_test/LICENSE.md (1)
1-1: Same license pointer concern as nvidia_nat_agno/LICENSE.mdThis file ships only a
../../LICENSE.mdpointer; please embed the real license text as noted earlier.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (74)
packages/compat/aiqtoolkit/pyproject.toml(1 hunks)packages/compat/aiqtoolkit_agno/pyproject.toml(1 hunks)packages/compat/aiqtoolkit_crewai/pyproject.toml(1 hunks)packages/compat/aiqtoolkit_langchain/pyproject.toml(1 hunks)packages/compat/aiqtoolkit_llama_index/pyproject.toml(1 hunks)packages/compat/aiqtoolkit_mem0ai/pyproject.toml(1 hunks)packages/compat/aiqtoolkit_semantic_kernel/pyproject.toml(1 hunks)packages/compat/aiqtoolkit_test/pyproject.toml(1 hunks)packages/compat/aiqtoolkit_weave/pyproject.toml(1 hunks)packages/compat/aiqtoolkit_zep_cloud/pyproject.toml(1 hunks)packages/nvidia_nat_adk/LICENSE-3rd-party.txt(1 hunks)packages/nvidia_nat_adk/LICENSE.md(1 hunks)packages/nvidia_nat_adk/pyproject.toml(1 hunks)packages/nvidia_nat_agno/LICENSE-3rd-party.txt(1 hunks)packages/nvidia_nat_agno/LICENSE.md(1 hunks)packages/nvidia_nat_agno/pyproject.toml(1 hunks)packages/nvidia_nat_all/LICENSE-3rd-party.txt(1 hunks)packages/nvidia_nat_all/LICENSE.md(1 hunks)packages/nvidia_nat_all/pyproject.toml(1 hunks)packages/nvidia_nat_crewai/LICENSE-3rd-party.txt(1 hunks)packages/nvidia_nat_crewai/LICENSE.md(1 hunks)packages/nvidia_nat_crewai/pyproject.toml(1 hunks)packages/nvidia_nat_data_flywheel/LICENSE-3rd-party.txt(1 hunks)packages/nvidia_nat_data_flywheel/LICENSE.md(1 hunks)packages/nvidia_nat_data_flywheel/pyproject.toml(1 hunks)packages/nvidia_nat_ingestion/LICENSE-3rd-party.txt(1 hunks)packages/nvidia_nat_ingestion/LICENSE.md(1 hunks)packages/nvidia_nat_ingestion/pyproject.toml(1 hunks)packages/nvidia_nat_langchain/LICENSE-3rd-party.txt(1 hunks)packages/nvidia_nat_langchain/LICENSE.md(1 hunks)packages/nvidia_nat_langchain/pyproject.toml(1 hunks)packages/nvidia_nat_llama_index/LICENSE-3rd-party.txt(1 hunks)packages/nvidia_nat_llama_index/LICENSE.md(1 hunks)packages/nvidia_nat_llama_index/pyproject.toml(1 hunks)packages/nvidia_nat_mcp/LICENSE-3rd-party.txt(1 hunks)packages/nvidia_nat_mcp/LICENSE.md(1 hunks)packages/nvidia_nat_mcp/pyproject.toml(1 hunks)packages/nvidia_nat_mem0ai/LICENSE-3rd-party.txt(1 hunks)packages/nvidia_nat_mem0ai/LICENSE.md(1 hunks)packages/nvidia_nat_mem0ai/pyproject.toml(1 hunks)packages/nvidia_nat_mysql/LICENSE-3rd-party.txt(1 hunks)packages/nvidia_nat_mysql/LICENSE.md(1 hunks)packages/nvidia_nat_mysql/pyproject.toml(1 hunks)packages/nvidia_nat_opentelemetry/LICENSE-3rd-party.txt(1 hunks)packages/nvidia_nat_opentelemetry/LICENSE.md(1 hunks)packages/nvidia_nat_opentelemetry/pyproject.toml(1 hunks)packages/nvidia_nat_phoenix/LICENSE-3rd-party.txt(1 hunks)packages/nvidia_nat_phoenix/LICENSE.md(1 hunks)packages/nvidia_nat_phoenix/pyproject.toml(1 hunks)packages/nvidia_nat_profiling/LICENSE-3rd-party.txt(1 hunks)packages/nvidia_nat_profiling/LICENSE.md(1 hunks)packages/nvidia_nat_profiling/pyproject.toml(1 hunks)packages/nvidia_nat_ragaai/LICENSE-3rd-party.txt(1 hunks)packages/nvidia_nat_ragaai/LICENSE.md(1 hunks)packages/nvidia_nat_ragaai/pyproject.toml(1 hunks)packages/nvidia_nat_redis/LICENSE-3rd-party.txt(1 hunks)packages/nvidia_nat_redis/LICENSE.md(1 hunks)packages/nvidia_nat_redis/pyproject.toml(1 hunks)packages/nvidia_nat_s3/LICENSE-3rd-party.txt(1 hunks)packages/nvidia_nat_s3/LICENSE.md(1 hunks)packages/nvidia_nat_s3/pyproject.toml(1 hunks)packages/nvidia_nat_semantic_kernel/LICENSE-3rd-party.txt(1 hunks)packages/nvidia_nat_semantic_kernel/LICENSE.md(1 hunks)packages/nvidia_nat_semantic_kernel/pyproject.toml(1 hunks)packages/nvidia_nat_test/LICENSE-3rd-party.txt(1 hunks)packages/nvidia_nat_test/LICENSE.md(1 hunks)packages/nvidia_nat_test/pyproject.toml(1 hunks)packages/nvidia_nat_weave/LICENSE-3rd-party.txt(1 hunks)packages/nvidia_nat_weave/LICENSE.md(1 hunks)packages/nvidia_nat_weave/pyproject.toml(1 hunks)packages/nvidia_nat_zep_cloud/LICENSE-3rd-party.txt(1 hunks)packages/nvidia_nat_zep_cloud/LICENSE.md(1 hunks)packages/nvidia_nat_zep_cloud/pyproject.toml(1 hunks)pyproject.toml(1 hunks)
🧰 Additional context used
📓 Path-based instructions (4)
**/*
⚙️ CodeRabbit configuration file
**/*: # Code Review Instructions
- Ensure the code follows best practices and coding standards. - For Python code, follow
PEP 20 and
PEP 8 for style guidelines.- Check for security vulnerabilities and potential issues. - Python methods should use type hints for all parameters and return values.
Example:def my_function(param1: int, param2: str) -> bool: pass- For Python exception handling, ensure proper stack trace preservation:
- When re-raising exceptions: use bare
raisestatements to maintain the original stack trace,
and uselogger.error()(notlogger.exception()) to avoid duplicate stack trace output.- When catching and logging exceptions without re-raising: always use
logger.exception()
to capture the full stack trace information.Documentation Review Instructions - Verify that documentation and comments are clear and comprehensive. - Verify that the documentation doesn't contain any TODOs, FIXMEs or placeholder text like "lorem ipsum". - Verify that the documentation doesn't contain any offensive or outdated terms. - Verify that documentation and comments are free of spelling mistakes, ensure the documentation doesn't contain any
words listed in the
ci/vale/styles/config/vocabularies/nat/reject.txtfile, words that might appear to be
spelling mistakes but are listed in theci/vale/styles/config/vocabularies/nat/accept.txtfile are OK.Misc. - All code (except .mdc files that contain Cursor rules) should be licensed under the Apache License 2.0,
and should contain an Apache License 2.0 header comment at the top of each file.
- Confirm that copyright years are up-to date whenever a file is changed.
Files:
packages/nvidia_nat_mysql/LICENSE.mdpackages/nvidia_nat_ragaai/pyproject.tomlpackages/nvidia_nat_llama_index/pyproject.tomlpackages/nvidia_nat_phoenix/LICENSE-3rd-party.txtpackages/nvidia_nat_weave/LICENSE.mdpackages/nvidia_nat_langchain/LICENSE.mdpackages/nvidia_nat_ragaai/LICENSE.mdpackages/nvidia_nat_zep_cloud/pyproject.tomlpackages/nvidia_nat_opentelemetry/LICENSE.mdpackages/nvidia_nat_opentelemetry/LICENSE-3rd-party.txtpackages/compat/aiqtoolkit_mem0ai/pyproject.tomlpackages/nvidia_nat_all/LICENSE-3rd-party.txtpackages/nvidia_nat_ingestion/LICENSE-3rd-party.txtpackages/compat/aiqtoolkit_weave/pyproject.tomlpackages/nvidia_nat_adk/pyproject.tomlpackages/nvidia_nat_test/LICENSE-3rd-party.txtpackages/nvidia_nat_ragaai/LICENSE-3rd-party.txtpackages/nvidia_nat_agno/LICENSE.mdpackages/nvidia_nat_profiling/LICENSE-3rd-party.txtpackages/nvidia_nat_redis/pyproject.tomlpackages/nvidia_nat_mcp/pyproject.tomlpackages/nvidia_nat_phoenix/LICENSE.mdpackages/nvidia_nat_weave/LICENSE-3rd-party.txtpackages/nvidia_nat_test/pyproject.tomlpackages/nvidia_nat_mysql/LICENSE-3rd-party.txtpackages/nvidia_nat_s3/LICENSE.mdpackages/compat/aiqtoolkit_zep_cloud/pyproject.tomlpackages/nvidia_nat_semantic_kernel/LICENSE-3rd-party.txtpackages/nvidia_nat_crewai/LICENSE-3rd-party.txtpackages/nvidia_nat_mem0ai/LICENSE.mdpackages/compat/aiqtoolkit_llama_index/pyproject.tomlpackages/nvidia_nat_redis/LICENSE-3rd-party.txtpackages/nvidia_nat_llama_index/LICENSE-3rd-party.txtpackages/nvidia_nat_zep_cloud/LICENSE-3rd-party.txtpackages/nvidia_nat_opentelemetry/pyproject.tomlpackages/nvidia_nat_profiling/LICENSE.mdpyproject.tomlpackages/compat/aiqtoolkit_test/pyproject.tomlpackages/nvidia_nat_mem0ai/LICENSE-3rd-party.txtpackages/compat/aiqtoolkit_semantic_kernel/pyproject.tomlpackages/nvidia_nat_agno/pyproject.tomlpackages/nvidia_nat_all/LICENSE.mdpackages/nvidia_nat_crewai/LICENSE.mdpackages/nvidia_nat_data_flywheel/pyproject.tomlpackages/nvidia_nat_semantic_kernel/LICENSE.mdpackages/nvidia_nat_llama_index/LICENSE.mdpackages/compat/aiqtoolkit/pyproject.tomlpackages/compat/aiqtoolkit_agno/pyproject.tomlpackages/nvidia_nat_agno/LICENSE-3rd-party.txtpackages/nvidia_nat_mcp/LICENSE.mdpackages/nvidia_nat_semantic_kernel/pyproject.tomlpackages/nvidia_nat_crewai/pyproject.tomlpackages/nvidia_nat_ingestion/pyproject.tomlpackages/nvidia_nat_all/pyproject.tomlpackages/nvidia_nat_redis/LICENSE.mdpackages/nvidia_nat_ingestion/LICENSE.mdpackages/nvidia_nat_zep_cloud/LICENSE.mdpackages/nvidia_nat_mcp/LICENSE-3rd-party.txtpackages/nvidia_nat_adk/LICENSE-3rd-party.txtpackages/nvidia_nat_data_flywheel/LICENSE-3rd-party.txtpackages/nvidia_nat_langchain/LICENSE-3rd-party.txtpackages/nvidia_nat_test/LICENSE.mdpackages/nvidia_nat_adk/LICENSE.mdpackages/nvidia_nat_s3/pyproject.tomlpackages/nvidia_nat_langchain/pyproject.tomlpackages/compat/aiqtoolkit_langchain/pyproject.tomlpackages/nvidia_nat_mem0ai/pyproject.tomlpackages/compat/aiqtoolkit_crewai/pyproject.tomlpackages/nvidia_nat_s3/LICENSE-3rd-party.txtpackages/nvidia_nat_profiling/pyproject.tomlpackages/nvidia_nat_weave/pyproject.tomlpackages/nvidia_nat_data_flywheel/LICENSE.mdpackages/nvidia_nat_mysql/pyproject.tomlpackages/nvidia_nat_phoenix/pyproject.toml
packages/**/*
⚙️ CodeRabbit configuration file
packages/**/*: - This directory contains optional plugin packages for the toolkit, each should contain apyproject.tomlfile. - Thepyproject.tomlfile should declare a dependency onnvidia-nator another package with a name starting
withnvidia-nat-. This dependency should be declared using~=<version>, and the version should be a two
digit version (ex:~=1.0).
- Not all packages contain Python code, if they do they should also contain their own set of tests, in a
tests/directory at the same level as thepyproject.tomlfile.
Files:
packages/nvidia_nat_mysql/LICENSE.mdpackages/nvidia_nat_ragaai/pyproject.tomlpackages/nvidia_nat_llama_index/pyproject.tomlpackages/nvidia_nat_phoenix/LICENSE-3rd-party.txtpackages/nvidia_nat_weave/LICENSE.mdpackages/nvidia_nat_langchain/LICENSE.mdpackages/nvidia_nat_ragaai/LICENSE.mdpackages/nvidia_nat_zep_cloud/pyproject.tomlpackages/nvidia_nat_opentelemetry/LICENSE.mdpackages/nvidia_nat_opentelemetry/LICENSE-3rd-party.txtpackages/compat/aiqtoolkit_mem0ai/pyproject.tomlpackages/nvidia_nat_all/LICENSE-3rd-party.txtpackages/nvidia_nat_ingestion/LICENSE-3rd-party.txtpackages/compat/aiqtoolkit_weave/pyproject.tomlpackages/nvidia_nat_adk/pyproject.tomlpackages/nvidia_nat_test/LICENSE-3rd-party.txtpackages/nvidia_nat_ragaai/LICENSE-3rd-party.txtpackages/nvidia_nat_agno/LICENSE.mdpackages/nvidia_nat_profiling/LICENSE-3rd-party.txtpackages/nvidia_nat_redis/pyproject.tomlpackages/nvidia_nat_mcp/pyproject.tomlpackages/nvidia_nat_phoenix/LICENSE.mdpackages/nvidia_nat_weave/LICENSE-3rd-party.txtpackages/nvidia_nat_test/pyproject.tomlpackages/nvidia_nat_mysql/LICENSE-3rd-party.txtpackages/nvidia_nat_s3/LICENSE.mdpackages/compat/aiqtoolkit_zep_cloud/pyproject.tomlpackages/nvidia_nat_semantic_kernel/LICENSE-3rd-party.txtpackages/nvidia_nat_crewai/LICENSE-3rd-party.txtpackages/nvidia_nat_mem0ai/LICENSE.mdpackages/compat/aiqtoolkit_llama_index/pyproject.tomlpackages/nvidia_nat_redis/LICENSE-3rd-party.txtpackages/nvidia_nat_llama_index/LICENSE-3rd-party.txtpackages/nvidia_nat_zep_cloud/LICENSE-3rd-party.txtpackages/nvidia_nat_opentelemetry/pyproject.tomlpackages/nvidia_nat_profiling/LICENSE.mdpackages/compat/aiqtoolkit_test/pyproject.tomlpackages/nvidia_nat_mem0ai/LICENSE-3rd-party.txtpackages/compat/aiqtoolkit_semantic_kernel/pyproject.tomlpackages/nvidia_nat_agno/pyproject.tomlpackages/nvidia_nat_all/LICENSE.mdpackages/nvidia_nat_crewai/LICENSE.mdpackages/nvidia_nat_data_flywheel/pyproject.tomlpackages/nvidia_nat_semantic_kernel/LICENSE.mdpackages/nvidia_nat_llama_index/LICENSE.mdpackages/compat/aiqtoolkit/pyproject.tomlpackages/compat/aiqtoolkit_agno/pyproject.tomlpackages/nvidia_nat_agno/LICENSE-3rd-party.txtpackages/nvidia_nat_mcp/LICENSE.mdpackages/nvidia_nat_semantic_kernel/pyproject.tomlpackages/nvidia_nat_crewai/pyproject.tomlpackages/nvidia_nat_ingestion/pyproject.tomlpackages/nvidia_nat_all/pyproject.tomlpackages/nvidia_nat_redis/LICENSE.mdpackages/nvidia_nat_ingestion/LICENSE.mdpackages/nvidia_nat_zep_cloud/LICENSE.mdpackages/nvidia_nat_mcp/LICENSE-3rd-party.txtpackages/nvidia_nat_adk/LICENSE-3rd-party.txtpackages/nvidia_nat_data_flywheel/LICENSE-3rd-party.txtpackages/nvidia_nat_langchain/LICENSE-3rd-party.txtpackages/nvidia_nat_test/LICENSE.mdpackages/nvidia_nat_adk/LICENSE.mdpackages/nvidia_nat_s3/pyproject.tomlpackages/nvidia_nat_langchain/pyproject.tomlpackages/compat/aiqtoolkit_langchain/pyproject.tomlpackages/nvidia_nat_mem0ai/pyproject.tomlpackages/compat/aiqtoolkit_crewai/pyproject.tomlpackages/nvidia_nat_s3/LICENSE-3rd-party.txtpackages/nvidia_nat_profiling/pyproject.tomlpackages/nvidia_nat_weave/pyproject.tomlpackages/nvidia_nat_data_flywheel/LICENSE.mdpackages/nvidia_nat_mysql/pyproject.tomlpackages/nvidia_nat_phoenix/pyproject.toml
packages/*/pyproject.toml
📄 CodeRabbit inference engine (.cursor/rules/general.mdc)
packages/*/pyproject.toml: Each package must contain a pyproject.toml
In packages, declare a dependency on nvidia-nat or packages starting with nvidia-nat-
Use ~= version constraints (e.g., ~=1.0) for dependencies
Files:
packages/nvidia_nat_ragaai/pyproject.tomlpackages/nvidia_nat_llama_index/pyproject.tomlpackages/nvidia_nat_zep_cloud/pyproject.tomlpackages/nvidia_nat_adk/pyproject.tomlpackages/nvidia_nat_redis/pyproject.tomlpackages/nvidia_nat_mcp/pyproject.tomlpackages/nvidia_nat_test/pyproject.tomlpackages/nvidia_nat_opentelemetry/pyproject.tomlpackages/nvidia_nat_agno/pyproject.tomlpackages/nvidia_nat_data_flywheel/pyproject.tomlpackages/nvidia_nat_semantic_kernel/pyproject.tomlpackages/nvidia_nat_crewai/pyproject.tomlpackages/nvidia_nat_ingestion/pyproject.tomlpackages/nvidia_nat_all/pyproject.tomlpackages/nvidia_nat_s3/pyproject.tomlpackages/nvidia_nat_langchain/pyproject.tomlpackages/nvidia_nat_mem0ai/pyproject.tomlpackages/nvidia_nat_profiling/pyproject.tomlpackages/nvidia_nat_weave/pyproject.tomlpackages/nvidia_nat_mysql/pyproject.tomlpackages/nvidia_nat_phoenix/pyproject.toml
{packages/*/pyproject.toml,uv.lock}
📄 CodeRabbit inference engine (.cursor/rules/general.mdc)
Add new dependencies to both pyproject.toml (alphabetically) and uv.lock via uv pip install --sync
Files:
packages/nvidia_nat_ragaai/pyproject.tomlpackages/nvidia_nat_llama_index/pyproject.tomlpackages/nvidia_nat_zep_cloud/pyproject.tomlpackages/nvidia_nat_adk/pyproject.tomlpackages/nvidia_nat_redis/pyproject.tomlpackages/nvidia_nat_mcp/pyproject.tomlpackages/nvidia_nat_test/pyproject.tomlpackages/nvidia_nat_opentelemetry/pyproject.tomlpackages/nvidia_nat_agno/pyproject.tomlpackages/nvidia_nat_data_flywheel/pyproject.tomlpackages/nvidia_nat_semantic_kernel/pyproject.tomlpackages/nvidia_nat_crewai/pyproject.tomlpackages/nvidia_nat_ingestion/pyproject.tomlpackages/nvidia_nat_all/pyproject.tomlpackages/nvidia_nat_s3/pyproject.tomlpackages/nvidia_nat_langchain/pyproject.tomlpackages/nvidia_nat_mem0ai/pyproject.tomlpackages/nvidia_nat_profiling/pyproject.tomlpackages/nvidia_nat_weave/pyproject.tomlpackages/nvidia_nat_mysql/pyproject.tomlpackages/nvidia_nat_phoenix/pyproject.toml
🧠 Learnings (2)
📚 Learning: 2025-09-23T18:39:15.023Z
Learnt from: CR
PR: NVIDIA/NeMo-Agent-Toolkit#0
File: .cursor/rules/general.mdc:0-0
Timestamp: 2025-09-23T18:39:15.023Z
Learning: Applies to LICENSE-3rd-party.txt : Maintain third-party licenses for binary assets when required
Applied to files:
packages/nvidia_nat_phoenix/LICENSE-3rd-party.txtpackages/nvidia_nat_opentelemetry/LICENSE-3rd-party.txtpackages/nvidia_nat_all/LICENSE-3rd-party.txtpackages/nvidia_nat_ingestion/LICENSE-3rd-party.txtpackages/nvidia_nat_test/LICENSE-3rd-party.txtpackages/nvidia_nat_ragaai/LICENSE-3rd-party.txtpackages/nvidia_nat_profiling/LICENSE-3rd-party.txtpackages/nvidia_nat_weave/LICENSE-3rd-party.txtpackages/nvidia_nat_mysql/LICENSE-3rd-party.txtpackages/nvidia_nat_semantic_kernel/LICENSE-3rd-party.txtpackages/nvidia_nat_crewai/LICENSE-3rd-party.txtpackages/nvidia_nat_redis/LICENSE-3rd-party.txtpackages/nvidia_nat_llama_index/LICENSE-3rd-party.txtpackages/nvidia_nat_zep_cloud/LICENSE-3rd-party.txtpackages/nvidia_nat_mem0ai/LICENSE-3rd-party.txtpackages/nvidia_nat_agno/LICENSE-3rd-party.txtpackages/nvidia_nat_mcp/LICENSE-3rd-party.txtpackages/nvidia_nat_adk/LICENSE-3rd-party.txtpackages/nvidia_nat_data_flywheel/LICENSE-3rd-party.txtpackages/nvidia_nat_langchain/LICENSE-3rd-party.txtpackages/nvidia_nat_s3/LICENSE-3rd-party.txt
📚 Learning: 2025-09-23T18:39:15.023Z
Learnt from: CR
PR: NVIDIA/NeMo-Agent-Toolkit#0
File: .cursor/rules/general.mdc:0-0
Timestamp: 2025-09-23T18:39:15.023Z
Learning: Applies to packages/*/pyproject.toml : In packages, declare a dependency on nvidia-nat or packages starting with nvidia-nat-
Applied to files:
packages/compat/aiqtoolkit_mem0ai/pyproject.tomlpackages/compat/aiqtoolkit_weave/pyproject.tomlpackages/nvidia_nat_adk/pyproject.tomlpackages/nvidia_nat_test/pyproject.tomlpackages/compat/aiqtoolkit_zep_cloud/pyproject.tomlpackages/compat/aiqtoolkit_llama_index/pyproject.tomlpackages/compat/aiqtoolkit_test/pyproject.tomlpackages/compat/aiqtoolkit_semantic_kernel/pyproject.tomlpackages/nvidia_nat_agno/pyproject.tomlpackages/nvidia_nat_data_flywheel/pyproject.tomlpackages/compat/aiqtoolkit/pyproject.tomlpackages/compat/aiqtoolkit_agno/pyproject.tomlpackages/nvidia_nat_ingestion/pyproject.tomlpackages/nvidia_nat_all/pyproject.tomlpackages/nvidia_nat_s3/pyproject.tomlpackages/nvidia_nat_langchain/pyproject.tomlpackages/compat/aiqtoolkit_crewai/pyproject.tomlpackages/nvidia_nat_profiling/pyproject.tomlpackages/nvidia_nat_mysql/pyproject.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: CI Pipeline / Check
🔇 Additional comments (8)
packages/compat/aiqtoolkit/pyproject.toml (1)
15-15: License metadata format change looks good.Switching to
{ text = "Apache-2.0" }aligns with the packaging goal for this PR.packages/compat/aiqtoolkit_zep_cloud/pyproject.toml (1)
15-15: Metadata update acknowledged.Consistent with the repository-wide license metadata change; looks good.
packages/nvidia_nat_redis/pyproject.toml (1)
30-30: Redis package metadata update looks correct.License field conversion matches the intended PyPI metadata fix.
pyproject.toml (1)
57-57: Top-level license metadata change confirmed.This keeps the root package aligned with the new
{ text = ... }convention and meets the PR objective.packages/nvidia_nat_s3/pyproject.toml (1)
30-30: S3 package license metadata update verified.Matches the intended formatting shift; all good.
packages/nvidia_nat_phoenix/pyproject.toml (1)
30-30: Phoenix package metadata matches new pattern.Change mirrors the rest of the workspace; nothing else needed.
packages/nvidia_nat_data_flywheel/pyproject.toml (1)
30-30: Data Flywheel metadata update confirmed.Consistent with the repo-wide license metadata adjustments.
packages/nvidia_nat_ingestion/pyproject.toml (1)
30-30: Ingestion package license field change looks good.Follows the standardized
{ text = "Apache-2.0" }format; no issues spotted.
willkill07
approved these changes
Oct 8, 2025
Signed-off-by: David Gardner <dagardner@nvidia.com>
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
ci/scripts/documentation_checks.sh(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
{scripts/**,ci/scripts/**}
📄 CodeRabbit inference engine (.cursor/rules/general.mdc)
Shell or utility scripts belong in scripts/ or ci/scripts/ and must not be mixed with library code
Files:
ci/scripts/documentation_checks.sh
**/*
⚙️ CodeRabbit configuration file
**/*: # Code Review Instructions
- Ensure the code follows best practices and coding standards. - For Python code, follow
PEP 20 and
PEP 8 for style guidelines.- Check for security vulnerabilities and potential issues. - Python methods should use type hints for all parameters and return values.
Example:def my_function(param1: int, param2: str) -> bool: pass- For Python exception handling, ensure proper stack trace preservation:
- When re-raising exceptions: use bare
raisestatements to maintain the original stack trace,
and uselogger.error()(notlogger.exception()) to avoid duplicate stack trace output.- When catching and logging exceptions without re-raising: always use
logger.exception()
to capture the full stack trace information.Documentation Review Instructions - Verify that documentation and comments are clear and comprehensive. - Verify that the documentation doesn't contain any TODOs, FIXMEs or placeholder text like "lorem ipsum". - Verify that the documentation doesn't contain any offensive or outdated terms. - Verify that documentation and comments are free of spelling mistakes, ensure the documentation doesn't contain any
words listed in the
ci/vale/styles/config/vocabularies/nat/reject.txtfile, words that might appear to be
spelling mistakes but are listed in theci/vale/styles/config/vocabularies/nat/accept.txtfile are OK.Misc. - All code (except .mdc files that contain Cursor rules) should be licensed under the Apache License 2.0,
and should contain an Apache License 2.0 header comment at the top of each file.
- Confirm that copyright years are up-to date whenever a file is changed.
Files:
ci/scripts/documentation_checks.sh
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: CI Pipeline / Check
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: David Gardner <96306125+dagardner-nv@users.noreply.github.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
license-filesentry, setuptools will do this for us by default.Licenseentry and not the newerLicense-ExpressionentryBy Submitting this PR I confirm:
Summary by CodeRabbit
Documentation
Chores
Notes