Skip to content

fix: Dockerfiles must not use any arg expansion on COPY --from lines#962

Merged
rapids-bot[bot] merged 1 commit intoNVIDIA:release/1.3from
willkill07:wkk_update-dockerfiles-with-hardcoded-uv-version
Oct 9, 2025
Merged

fix: Dockerfiles must not use any arg expansion on COPY --from lines#962
rapids-bot[bot] merged 1 commit intoNVIDIA:release/1.3from
willkill07:wkk_update-dockerfiles-with-hardcoded-uv-version

Conversation

@willkill07
Copy link
Member

@willkill07 willkill07 commented Oct 9, 2025

Description

Closes nvbugs-5561420, nvbugs-5563886

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Summary by CodeRabbit

  • Chores
    • Pinned the UV tool to version 0.8.15 across the main and example Dockerfiles to ensure consistent, reproducible builds.
    • Removed the UV_VERSION build argument; builds no longer accept or require this parameter. Existing build flows remain unchanged aside from the fixed version.

Signed-off-by: Will Killian <wkillian@nvidia.com>
@willkill07 willkill07 requested a review from a team as a code owner October 9, 2025 14:28
@willkill07 willkill07 added bug Something isn't working non-breaking Non-breaking change labels Oct 9, 2025
@willkill07 willkill07 self-assigned this Oct 9, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 9, 2025

Walkthrough

Pinned the uv base image to ghcr.io/astral-sh/uv:0.8.15 across multiple Dockerfiles and removed the UV_VERSION build argument and its usage. Other build args (e.g., NAT_VERSION) and remaining Dockerfile steps are unchanged.

Changes

Cohort / File(s) Summary of Changes
Core Dockerfile
docker/Dockerfile
Replaced dynamic uv image reference with ghcr.io/astral-sh/uv:0.8.15; removed ARG UV_VERSION and its use. Other args (e.g., NAT_VERSION) unchanged.
Example Dockerfiles
examples/evaluation_and_profiling/email_phishing_analyzer/Dockerfile, examples/frameworks/agno_personal_finance/Dockerfile, examples/getting_started/simple_calculator/Dockerfile, examples/getting_started/simple_web_query/Dockerfile
Removed ARG UV_VERSION and replaced COPY --from=ghcr.io/astral-sh/uv:${UV_VERSION} with COPY --from=ghcr.io/astral-sh/uv:0.8.15. No other changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

breaking

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title succinctly describes the main change to remove argument expansion from COPY --from lines in Dockerfiles, adheres to the 72-character limit, and uses an imperative-style prefix consistent with conventional commit guidelines.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 851d8f5 and 6720125.

📒 Files selected for processing (5)
  • docker/Dockerfile (1 hunks)
  • examples/evaluation_and_profiling/email_phishing_analyzer/Dockerfile (1 hunks)
  • examples/frameworks/agno_personal_finance/Dockerfile (1 hunks)
  • examples/getting_started/simple_calculator/Dockerfile (1 hunks)
  • examples/getting_started/simple_web_query/Dockerfile (1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*

⚙️ CodeRabbit configuration file

**/*: # Code Review Instructions

  • Ensure the code follows best practices and coding standards. - For Python code, follow
    PEP 20 and
    PEP 8 for style guidelines.
  • Check for security vulnerabilities and potential issues. - Python methods should use type hints for all parameters and return values.
    Example:
    def my_function(param1: int, param2: str) -> bool:
        pass
  • For Python exception handling, ensure proper stack trace preservation:
    • When re-raising exceptions: use bare raise statements to maintain the original stack trace,
      and use logger.error() (not logger.exception()) to avoid duplicate stack trace output.
    • When catching and logging exceptions without re-raising: always use logger.exception()
      to capture the full stack trace information.

Documentation Review Instructions - Verify that documentation and comments are clear and comprehensive. - Verify that the documentation doesn't contain any TODOs, FIXMEs or placeholder text like "lorem ipsum". - Verify that the documentation doesn't contain any offensive or outdated terms. - Verify that documentation and comments are free of spelling mistakes, ensure the documentation doesn't contain any

words listed in the ci/vale/styles/config/vocabularies/nat/reject.txt file, words that might appear to be
spelling mistakes but are listed in the ci/vale/styles/config/vocabularies/nat/accept.txt file are OK.

Misc. - All code (except .mdc files that contain Cursor rules) should be licensed under the Apache License 2.0,

and should contain an Apache License 2.0 header comment at the top of each file.

  • Confirm that copyright years are up-to date whenever a file is changed.

Files:

  • examples/getting_started/simple_calculator/Dockerfile
  • examples/getting_started/simple_web_query/Dockerfile
  • examples/evaluation_and_profiling/email_phishing_analyzer/Dockerfile
  • docker/Dockerfile
  • examples/frameworks/agno_personal_finance/Dockerfile
examples/**/*

⚙️ CodeRabbit configuration file

examples/**/*: - This directory contains example code and usage scenarios for the toolkit, at a minimum an example should
contain a README.md or file README.ipynb.

  • If an example contains Python code, it should be placed in a subdirectory named src/ and should
    contain a pyproject.toml file. Optionally, it might also contain scripts in a scripts/ directory.
  • If an example contains YAML files, they should be placed in a subdirectory named configs/. - If an example contains sample data files, they should be placed in a subdirectory named data/, and should
    be checked into git-lfs.

Files:

  • examples/getting_started/simple_calculator/Dockerfile
  • examples/getting_started/simple_web_query/Dockerfile
  • examples/evaluation_and_profiling/email_phishing_analyzer/Dockerfile
  • examples/frameworks/agno_personal_finance/Dockerfile
🔇 Additional comments (1)
docker/Dockerfile (1)

27-27: No residual UV_VERSION references detected.

Ripgrep searches (including hidden files) found zero occurrences—build scripts and docs are clean, no no-op ARG needed.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai bot added the breaking Breaking change label Oct 9, 2025
@willkill07 willkill07 removed the breaking Breaking change label Oct 9, 2025
@willkill07
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 1ab4d94 into NVIDIA:release/1.3 Oct 9, 2025
17 checks passed
@willkill07 willkill07 deleted the wkk_update-dockerfiles-with-hardcoded-uv-version branch October 23, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants