feat: introducing the experimental package and refactoring test structure#433
feat: introducing the experimental package and refactoring test structure#433
experimental package and refactoring test structure#433Conversation
experimental package and refactoring test structure
446bad7 to
2d58504
Compare
|
@ko3n1g Tried excluding the test files via Manifest.in/exclude_package_data, but both don't seem to work when building a sdist wheel or simply |
odelalleau
left a comment
There was a problem hiding this comment.
Looks mostly good to me, just a few questions below, and one suggestion: I think it'd be better to have tests of experimental features under a dedicated folder, so that we can easily identify them. Either under tests/functional/experimental, or tests/experimental, or tests/functional_experimental for instance.
@odelalleau Makes sense! Please see 2893053 |
odelalleau
left a comment
There was a problem hiding this comment.
@odelalleau Makes sense! Please see 2893053
Looking good, thanks!
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
for more information, see https://pre-commit.ci Signed-off-by: NeMo-Aligner CI <nemo-aligner-ci@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
aba6608 to
36bd74e
Compare
What does this PR do ?
Introduces experimental directory structure for code and docs. As part of the restructuring, the tests are moved closer to the source to reduce the repetition of directory structure.
Before
Proposal
these can be filtered out when we publish to pypi(Needs more investigation)