Skip to content
This repository was archived by the owner on Nov 19, 2025. It is now read-only.

Conversation

@ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Jan 3, 2025

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

@ko3n1g ko3n1g merged commit 2ed0405 into r0.6.0 Jan 3, 2025
7 checks passed
@ko3n1g ko3n1g deleted the ko3n1g-patch-2 branch January 3, 2025 18:55
SahilJain314 pushed a commit to SahilJain314/NeMo-Aligner that referenced this pull request Jan 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants