Skip to content
This repository was archived by the owner on Nov 19, 2025. It is now read-only.

fix: Generate version number#474

Merged
ko3n1g merged 2 commits intomainfrom
ko3n1g/fix/version-numbers
Jan 3, 2025
Merged

fix: Generate version number#474
ko3n1g merged 2 commits intomainfrom
ko3n1g/fix/version-numbers

Conversation

@ko3n1g
Copy link
Copy Markdown
Collaborator

@ko3n1g ko3n1g commented Jan 3, 2025

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g added the r0.6.0 creates cherry-pick PR after merge (add before Run CICD label) label Jan 3, 2025
@ko3n1g ko3n1g requested a review from terrykong January 3, 2025 19:15
Comment thread nemo_aligner/package_info.py
@ko3n1g ko3n1g requested a review from terrykong January 3, 2025 19:33
@ko3n1g ko3n1g added Skip CICD and removed Skip CICD labels Jan 3, 2025
@ko3n1g ko3n1g enabled auto-merge (squash) January 3, 2025 19:38
Comment thread nemo_aligner/package_info.py Outdated
Co-authored-by: Terry Kong <terryk@nvidia.com>
@ko3n1g ko3n1g added Skip CICD and removed Skip CICD labels Jan 3, 2025
@ko3n1g ko3n1g requested a review from terrykong January 3, 2025 19:40
@ko3n1g ko3n1g merged commit de10571 into main Jan 3, 2025
@ko3n1g ko3n1g deleted the ko3n1g/fix/version-numbers branch January 3, 2025 19:46
ko3n1g added a commit that referenced this pull request Jan 3, 2025
Signed-off-by: oliver könig <okoenig@nvidia.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

r0.6.0 creates cherry-pick PR after merge (add before Run CICD label) Skip CICD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants