Skip to content

ci: set nightly tag git identity#40

Merged
willkill07 merged 2 commits into
NVIDIA:mainfrom
willkill07:wkk_fix-nightly-alpha-tag-identity
May 3, 2026
Merged

ci: set nightly tag git identity#40
willkill07 merged 2 commits into
NVIDIA:mainfrom
willkill07:wkk_fix-nightly-alpha-tag-identity

Conversation

@willkill07
Copy link
Copy Markdown
Member

@willkill07 willkill07 commented May 3, 2026

Summary

  • Configure a GitHub Actions bot identity before creating the annotated nightly alpha tag.
  • Keep the existing PAT-backed tag push path so tag CI is still triggered.

Root Cause

The scheduled nightly alpha tag run failed because git tag --annotate requires a committer identity, but the runner had no local user.name or user.email configured.

Validation

  • YAML load for all workflow files
  • uv run pre-commit run --files .github/workflows/nightly-alpha-tag.yaml
  • git diff --check

Breaking Changes

None.

Summary by CodeRabbit

  • Chores
    • Updated the automated release tagging configuration to improve consistency in nightly build processes.

Signed-off-by: Will Killian <wkillian@nvidia.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 7a232c33-bab1-41e4-ab7c-e6bdbf312729

📥 Commits

Reviewing files that changed from the base of the PR and between 61e175e and 056c8c1.

📒 Files selected for processing (1)
  • .github/workflows/nightly-alpha-tag.yaml
📜 Recent review details
🧰 Additional context used
📓 Path-based instructions (4)
.github/workflows/**/*.{yml,yaml}

📄 CodeRabbit inference engine (.agents/skills/maintain-ci/SKILL.md)

.github/workflows/**/*.{yml,yaml}: Put permissions: on each job that needs token access in GitHub Actions workflows
Avoid workflow-level permissions unless the repository intentionally centralizes them and the inheritance tradeoff is documented
Keep third-party actions pinned to full commit SHAs and preserve the readable version comment after the SHA
Prefer action-native or ecosystem-native caching over generic actions/cache in GitHub Actions workflows
Use lockfiles or dependency manifests to drive cache invalidation in GitHub Actions workflows
Keep deploy and publish permissions isolated to the jobs that need them
Read both caller and callee when a workflow uses workflow_call in GitHub Actions
Put release-tag validation in the earliest practical caller job when the pipeline has tag-based publish behavior
Keep release-tag policy aligned with RELEASING.md: raw SemVer tags only, no leading v
contents: read is the default minimum for checkout-based build, test, docs, and packaging jobs
pull-requests: read is required for PR metadata lookup jobs in GitHub Actions workflows
pages: write and id-token: write should be limited to Pages deployment jobs and any caller that invokes them through a reusable workflow
For reusable workflows, the caller must grant every permission the called jobs require and the callee cannot elevate beyond what the caller provides
Prefer astral-sh/setup-uv cache support with cache-dependency-glob anchored to uv.lock for Python dependency caching
Prefer Swatinem/rust-cache with explicit shared-key and workspaces instead of ad hoc target-directory caching
Avoid caching generated outputs that can hide stale behavior unless the repo already relies on them deliberately
Ensure each job has the minimum permissions it needs during GitHub Actions CI review
Ensure reusable workflow callers grant only the scopes their callees require
Ensure every external action is pinned to a full SHA in GitHub Actions workflows
Ensure cache ...

Files:

  • .github/workflows/nightly-alpha-tag.yaml
{.github/workflows/**/*.{yml,yaml},.gitlab-ci.yml}

📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)

Keep CI workflow package name references consistent with local package configurations

Files:

  • .github/workflows/nightly-alpha-tag.yaml
{.github/**/*.{yml,yaml},*.patch,scripts/**/*,*.sh,*.bat,Dockerfile*}

📄 CodeRabbit inference engine (.agents/skills/rename-surfaces/SKILL.md)

Update CI configuration, patch files, and build scripts with new functional identifiers after rename operations

Files:

  • .github/workflows/nightly-alpha-tag.yaml
{.github/**,.gitlab-ci.yml,.pre-commit-config.yaml,justfile,scripts/**}

⚙️ CodeRabbit configuration file

{.github/**,.gitlab-ci.yml,.pre-commit-config.yaml,justfile,scripts/**}: Review automation changes for reproducibility, pinned versions where appropriate, secret handling, and consistency with the documented validation matrix.
Pay attention to commands that need generated native artifacts, FFI libraries, or platform-specific environment variables.

Files:

  • .github/workflows/nightly-alpha-tag.yaml
🔇 Additional comments (1)
.github/workflows/nightly-alpha-tag.yaml (1)

58-59: Good fix for annotated-tag identity requirement.

Setting user.name and user.email before git tag --annotate correctly addresses the failure mode while keeping permission scope unchanged.


Walkthrough

The nightly alpha tag workflow now configures Git user identity (github-actions[bot] with corresponding noreply email address) before creating and pushing the annotated tag, ensuring proper authorship attribution.

Changes

Workflow Configuration

Layer / File(s) Summary
Git Identity Setup
.github/workflows/nightly-alpha-tag.yaml
Adds git config user.name and git config user.email commands to establish the committer identity before tag creation and push.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title follows Conventional Commits format with 'ci' type and imperative summary, is under 72 characters, and directly describes the workflow change.
Description check ✅ Passed The description provides clear context with summary, root cause, and validation steps, but lacks the structured template sections from repository requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get your free trial and get 200 agent minutes per Slack user (a $50 value).


Review rate limit: 9/10 reviews remaining, refill in 6 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size:XS PR is extra small ci labels May 3, 2026
@willkill07 willkill07 marked this pull request as ready for review May 3, 2026 00:49
@willkill07 willkill07 requested a review from a team as a code owner May 3, 2026 00:49
@willkill07 willkill07 merged commit ac3bbc0 into NVIDIA:main May 3, 2026
51 checks passed
@willkill07 willkill07 deleted the wkk_fix-nightly-alpha-tag-identity branch May 3, 2026 01:55
@willkill07 willkill07 self-assigned this May 3, 2026
@willkill07 willkill07 added this to the 0.2.0 milestone May 3, 2026
@willkill07 willkill07 added the Maintenance CI or Build or general repository maintenance label May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintenance CI or Build or general repository maintenance size:XS PR is extra small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant