Skip to content

fix(rust): python rust tests need isolation#43

Merged
willkill07 merged 1 commit into
NVIDIA:mainfrom
willkill07:wkk_fix/windows-python-env-guard
May 3, 2026
Merged

fix(rust): python rust tests need isolation#43
willkill07 merged 1 commit into
NVIDIA:mainfrom
willkill07:wkk_fix/windows-python-env-guard

Conversation

@willkill07
Copy link
Copy Markdown
Member

What changed

  • Serialized the post-guard environment cleanup in the Python coverage tests with lock_python_test().
  • Kept the absent-runtime-owner assertion under the same mutex used by the Python test guard.

Why

Windows Python CI was intermittently failing because the test released the Python test mutex before clearing and asserting process-wide NEMO_FLOW_RUNTIME_OWNER / NEMO_FLOW_BINDING_KIND state. Another parallel test could observe or mutate those process-wide variables in that gap.

Validation

  • cargo test -p nemo-flow-python test_python_test_guard --lib -- --nocapture
  • Earlier local validation also passed: cargo test -p nemo-flow-python --lib and just test-python

Signed-off-by: Will Killian <wkillian@nvidia.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 3, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • crates/python/tests/coverage/coverage_tests.rs is excluded by !**/coverage/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 6f650e16-cd9e-41a6-839d-92ff3059ca0b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size:XS PR is extra small lang:rust PR changes/introduces Rust code labels May 3, 2026
@willkill07 willkill07 changed the title [codex] fix python test env guard isolation @coderabbitai May 3, 2026
@willkill07 willkill07 marked this pull request as ready for review May 3, 2026 02:24
@willkill07 willkill07 requested a review from a team as a code owner May 3, 2026 02:24
@willkill07 willkill07 changed the title @coderabbitai fix(rust): python rust tests need isolation May 3, 2026
@github-actions github-actions Bot added the fix label May 3, 2026
@willkill07 willkill07 merged commit e4d3ab2 into NVIDIA:main May 3, 2026
38 checks passed
@willkill07 willkill07 deleted the wkk_fix/windows-python-env-guard branch May 3, 2026 02:38
@willkill07 willkill07 self-assigned this May 3, 2026
@willkill07 willkill07 added this to the 0.2.0 milestone May 3, 2026
@willkill07 willkill07 added the Bug issue describes bug; PR fixes bug label May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug issue describes bug; PR fixes bug lang:rust PR changes/introduces Rust code size:XS PR is extra small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant