Skip to content

ci: narrow review path filters#44

Merged
willkill07 merged 2 commits into
NVIDIA:mainfrom
willkill07:wkk_fix/ci-review-filters
May 3, 2026
Merged

ci: narrow review path filters#44
willkill07 merged 2 commits into
NVIDIA:mainfrom
willkill07:wkk_fix/ci-review-filters

Conversation

@willkill07
Copy link
Copy Markdown
Member

@willkill07 willkill07 commented May 3, 2026

Summary

  • Narrow CodeRabbit coverage ignores to generated Node and WASM coverage output directories.
  • Refine CI path filters so Rust-only test changes do not trigger binding tests or packaging.
  • Keep binding filters focused on source, package metadata, and language-specific test surfaces.

Why

The previous filters treated existing Rust test files under coverage/test directories as broader binding or shared runtime changes, which made CI and CodeRabbit review more eager than intended.

Validation

  • uv run pre-commit run --files .github/ci-path-filters.yml .github/workflows/ci_pipe.yml .github/workflows/ci.yaml
  • YAML parse for .github/ci-path-filters.yml, .github/workflows/ci_pipe.yml, and .github/workflows/ci.yaml
  • Local filter simulation for representative Rust test, binding source, and Node/WASM JS test paths

Summary by CodeRabbit

  • Chores
    • Refined CI trigger paths to improve workflow efficiency across language-specific projects.
    • Updated code review configuration to exclude coverage directories from processing.

Signed-off-by: Will Killian <wkillian@nvidia.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 3, 2026

Walkthrough

Two configuration files are updated to refine processing scope: CodeRabbit review filters exclude specific coverage directories, and GitHub CI path filters narrow triggers to explicit subproject paths for build artifacts and source code instead of broad directory globs.

Changes

CodeRabbit Review Filters

Layer / File(s) Summary
Coverage Exclusions
.coderabbit.yaml
Path filters expanded with !crates/node/coverage/** and !crates/wasm/coverage/** exclusions to prevent CodeRabbit from processing language-specific coverage output directories.

GitHub CI Path Filters

Layer / File(s) Summary
Shared Build Triggers
.github/ci-path-filters.yml (lines 10–16)
shared filters narrowed from broad crate globs to explicit manifest and source paths: crates/adaptive/ and crates/core/ with Cargo.toml and src/** entries, plus justfile and rust-toolchain.toml.
Documentation Triggers
.github/ci-path-filters.yml (lines 17–21)
docs filters restricted to crates/adaptive/src/** and crates/core/src/** instead of whole crate directories, retaining markdown files.
Language-Specific Triggers
.github/ci-path-filters.yml (lines 38–68)
go, node, python, and wasm filters expanded from broad crates/<name>/** globs to explicit per-subproject paths including manifest files (Cargo.toml, package.json, pyproject.toml), source directories, build artifacts, and test/script files.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed Description provides clear Summary, Why, and Validation sections explaining the changes and rationale. However, it lacks the structured template sections (Overview checklist, Details, Where to start, Related Issues) and related issue references.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title follows Conventional Commits format with type 'ci' and concise summary, is under 72 characters, uses lowercase, and accurately describes the main change of narrowing path filters.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size:S PR is small fix labels May 3, 2026
@willkill07 willkill07 marked this pull request as ready for review May 3, 2026 02:56
@willkill07 willkill07 requested a review from a team as a code owner May 3, 2026 02:56
@willkill07 willkill07 changed the title fix(ci): narrow review path filters ci: narrow review path filters May 3, 2026
@github-actions github-actions Bot added ci and removed fix labels May 3, 2026
@willkill07 willkill07 merged commit deb0213 into NVIDIA:main May 3, 2026
53 checks passed
@willkill07 willkill07 deleted the wkk_fix/ci-review-filters branch May 3, 2026 03:16
@willkill07 willkill07 self-assigned this May 3, 2026
@willkill07 willkill07 added this to the 0.2.0 milestone May 3, 2026
@willkill07 willkill07 added the Maintenance CI or Build or general repository maintenance label May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintenance CI or Build or general repository maintenance size:S PR is small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant