Skip to content

ci: fix GitLab npm artifactory publish config#47

Merged
willkill07 merged 1 commit into
NVIDIA:mainfrom
willkill07:wkk_fix-npm-artifactory-npm-config
May 3, 2026
Merged

ci: fix GitLab npm artifactory publish config#47
willkill07 merged 1 commit into
NVIDIA:mainfrom
willkill07:wkk_fix-npm-artifactory-npm-config

Conversation

@willkill07
Copy link
Copy Markdown
Member

@willkill07 willkill07 commented May 3, 2026

Overview

Fix the GitLab publish:artifactory:npm job for npm 11 / Node 24 by removing legacy npm config writes that are no longer accepted.

  • I confirm this contribution is my own work, or I have the right to submit it under this project's license.
  • I searched existing issues and open pull requests, and this does not duplicate existing work.

Details

  • Remove registry-scoped email and always-auth writes from the Artifactory npm publish setup.
  • Keep the Artifactory registry and registry-scoped _auth configuration used by npm publish.
  • Validation: reproduced npm 11 rejecting always-auth, verified the remaining npm config commands with npm 11.11.0, ran git diff --check, and commit hooks passed.

Where should the reviewer start?

.gitlab-ci.yml, in the publish:artifactory:npm job.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • Relates to: none

Summary by CodeRabbit

  • Chores
    • Updated npm registry authentication configuration in the CI/CD pipeline to use base64-encoded credentials for improved security during artifact publishing.

Signed-off-by: Will Killian <wkillian@nvidia.com>
@willkill07 willkill07 requested a review from a team as a code owner May 3, 2026 16:11
@github-actions github-actions Bot added the size:XS PR is extra small label May 3, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 972e311b-a85b-4a20-8581-dc9c8da9d5bc

📥 Commits

Reviewing files that changed from the base of the PR and between 6b04c28 and 2b8a56c.

📒 Files selected for processing (1)
  • .gitlab-ci.yml
💤 Files with no reviewable changes (1)
  • .gitlab-ci.yml

Walkthrough

The publish:artifactory:npm GitLab CI job now authenticates to the npm registry using base64-encoded credentials passed via the :_auth configuration, replacing the previous email and always-auth settings. The registry URL is explicitly set prior to authentication.

Changes

NPM Registry Authentication

Layer / File(s) Summary
Credential Encoding
.gitlab-ci.yml
Base64-encodes NEMO_FLOW_CI_ARTIFACTORY_USER and NEMO_FLOW_CI_ARTIFACTORY_KEY into npm_auth variable.
Registry Configuration
.gitlab-ci.yml
Sets npm registry URL via npm config set registry, then configures authentication via npm config set "${registry_key}:_auth" with the encoded credentials.
Legacy Configuration Removal
.gitlab-ci.yml
Removes "${registry_key}:email" and "${registry_key}:always-auth" npm config settings.
Publishing
.gitlab-ci.yml
Unchanged npm publish commands for consolidated packages and WASM artifacts remain intact.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed Title follows Conventional Commits format with 'ci' type and concise imperative summary under 72 characters.
Description check ✅ Passed Description includes all required template sections: Overview with confirmation checkboxes, detailed change explanation, reviewer guidance, and related issues reference.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Review rate limit: 9/10 reviews remaining, refill in 6 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@willkill07 willkill07 changed the title Fix npm Artifactory publish config ci: fix GitLab npm artifactory publish config May 3, 2026
@willkill07 willkill07 self-assigned this May 3, 2026
@github-actions github-actions Bot added the ci label May 3, 2026
@coderabbitai coderabbitai Bot removed the ci label May 3, 2026
@github-actions github-actions Bot added the ci label May 3, 2026
@willkill07 willkill07 merged commit e7e6eb4 into NVIDIA:main May 3, 2026
21 checks passed
@willkill07 willkill07 added this to the 0.2.0 milestone May 4, 2026
@willkill07 willkill07 deleted the wkk_fix-npm-artifactory-npm-config branch May 6, 2026 18:40
@willkill07 willkill07 added the Maintenance CI or Build or general repository maintenance label May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintenance CI or Build or general repository maintenance size:XS PR is extra small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant