ci: install sphinx rustdoc generator#52
Conversation
Signed-off-by: Will Killian <wkillian@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
🧰 Additional context used📓 Path-based instructions (4).github/workflows/**/*.{yml,yaml}📄 CodeRabbit inference engine (.agents/skills/maintain-ci/SKILL.md)
Files:
{.github/workflows/**/*.{yml,yaml},.gitlab-ci.yml}📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
Files:
{.github/**/*.{yml,yaml},*.patch,scripts/**/*,*.sh,*.bat,Dockerfile*}📄 CodeRabbit inference engine (.agents/skills/rename-surfaces/SKILL.md)
Files:
{.github/**,.gitlab-ci.yml,.pre-commit-config.yaml,justfile,scripts/**}⚙️ CodeRabbit configuration file
Files:
🧠 Learnings (1)📚 Learning: 2026-05-03T04:23:07.497ZApplied to files:
🔇 Additional comments (1)
WalkthroughThe documentation CI workflow now installs ChangesCI Workflow Tool Installation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Review rate limit: 9/10 reviews remaining, refill in 6 minutes. Comment |
Overview
Install the Rust documentation generator required by
sphinxcontrib-rustin the documentation CI job sojust docs-linkcheckcan generate Rust API docs before Sphinx link checking.Details
sphinx-rustdocgen@1.0.1to the existingtaiki-e/install-actiontool list in.github/workflows/ci_docs.yml.justfiledocs recipes are unchanged.1.0.1to match the currently lockedsphinxcontrib-rustPython package version used by the docs dependency group.sphinxcontrib-rustincludes asetup.pyinstall hook for buildingsphinx-rustdocgen, butuv syncbuilds and installs a wheel from the sdist rather than runningsetup.py install; wheel installation does not execute that custom install command, so CI must provide the executable explicitly.Validation:
ruby -e 'require "yaml"; YAML.load_file(".github/workflows/ci_docs.yml"); puts "yaml-ok"'passed.git diff --check -- .github/workflows/ci_docs.ymlpassed.uv run pre-commit run --files .github/workflows/ci_docs.ymlpassed.NEMO_FLOW_DOCS_DEPS_READY=1 just docs-linkcheckpassed locally. Local environment already hadsphinx-rustdocgen; the workflow change ensures CI has the same required executable before running the same command.Where should the reviewer start?
Start with
.github/workflows/ci_docs.yml, where the documentation tool install step now installs bothjustandsphinx-rustdocgen.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit
Release Notes