ci: improve workflow linting and job names#55
Conversation
Signed-off-by: Will Killian <wkillian@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🧰 Additional context used📓 Path-based instructions (4).github/workflows/**/*.{yml,yaml}📄 CodeRabbit inference engine (.agents/skills/maintain-ci/SKILL.md)
Files:
{.github/workflows/**/*.{yml,yaml},.gitlab-ci.yml}📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
Files:
{.github/**/*.{yml,yaml},*.patch,scripts/**/*,*.sh,*.bat,Dockerfile*}📄 CodeRabbit inference engine (.agents/skills/rename-surfaces/SKILL.md)
Files:
{.github/**,.gitlab-ci.yml,.pre-commit-config.yaml,justfile,scripts/**}⚙️ CodeRabbit configuration file
Files:
🔇 Additional comments (3)
WalkthroughRenames CI job IDs/display names across language-specific workflows to ChangesCI Workflow & Linting updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Review rate limit: 8/10 reviews remaining, refill in 6 minutes and 53 seconds. Comment |
Signed-off-by: Will Killian <wkillian@nvidia.com>
Overview
Add actionlint to pre-commit and make CI job display names clearer in the GitHub Actions sidebar.
Details
rhysd/actionlintpre-commit hook for workflow files, local action metadata, and.github/actionlint.yamlchanges.Test (linux-amd64)instead of duplicate platform-only leaves.github.event.pull_request.Where should the reviewer start?
Start with
.pre-commit-config.yamlfor the new actionlint hook, then.github/workflows/ci_node.ymlfor the matrix job naming pattern applied across CI workflows.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit