Skip to content

ci: fix Codecov ignore paths#56

Merged
willkill07 merged 1 commit intoNVIDIA:mainfrom
willkill07:wkk_ci-codecov-ignore-paths
May 4, 2026
Merged

ci: fix Codecov ignore paths#56
willkill07 merged 1 commit intoNVIDIA:mainfrom
willkill07:wkk_ci-codecov-ignore-paths

Conversation

@willkill07
Copy link
Copy Markdown
Member

@willkill07 willkill07 commented May 4, 2026

Overview

Update Codecov ignore patterns so repo-root coverage paths are excluded correctly.

  • I confirm this contribution is my own work, or I have the right to submit it under this project's license.
  • I searched existing issues and open pull requests, and this does not duplicate existing work.

Details

  • Replace root-level Codecov globs that compiled with a leading directory requirement.
  • Use folder-prefix ignores for Node native bridge coverage, WebAssembly Rust source coverage, third-party files, target artifacts, and Python dSYM output.
  • Preserve the existing WebAssembly wrapper coverage reporting path.

Where should the reviewer start?

Start with codecov.yml, especially the ignore section. Codecov validation now compiles crates/wasm/src/ to ^crates/wasm/src/.*, matching the paths shown in Codecov.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • Relates to: none

Summary by CodeRabbit

  • Chores
    • Updated code coverage configuration to refine path exclusion patterns for improved accuracy in coverage analysis.

Signed-off-by: Will Killian <wkillian@nvidia.com>
@willkill07 willkill07 requested a review from a team as a code owner May 4, 2026 02:22
@github-actions github-actions Bot added size:S PR is small ci PR alters/improves CI labels May 4, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 5a1a0655-8658-490c-8e2a-5578448b1284

📥 Commits

Reviewing files that changed from the base of the PR and between 7b7b5d9 and 1c7f958.

📒 Files selected for processing (1)
  • codecov.yml
📜 Recent review details
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{rs,py,js,ts,tsx,jsx,go,sh,yaml,yml,toml,json,md,txt}

📄 CodeRabbit inference engine (AGENTS.md)

Keep SPDX headers on source, docs, scripts, and configuration files. The project is Apache-2.0.

Files:

  • codecov.yml
🔇 Additional comments (2)
codecov.yml (2)

113-123: Repo-root ignore normalization looks correct.

These path updates correctly anchor ignores to repository-root coverage paths and avoid unintended nested-path matching.


126-126: WASM source exclusion scope is aligned with intent.

Ignoring crates/wasm/src/ is consistent with excluding Rust wrapper internals while keeping wrapper JS coverage reporting.


Walkthrough

Updated codecov.yml coverage ignore patterns by removing leading **/ glob prefixes from several directory exclusions (third_party/, crates/node/src/, crates/node/coverage/, target/, python/nemo_flow/...) and broadening the WebAssembly exclusion from a specific *.rs file pattern to the entire crates/wasm/src/ directory.

Changes

Codecov Configuration Update

Layer / File(s) Summary
Ignore Patterns
codecov.yml
Simplified and standardized path exclusion globs by removing leading **/ prefixes from directory-level patterns and converting WebAssembly coverage ignore from file-specific (**/*.rs) to directory-level (crates/wasm/src/).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed Title follows Conventional Commits format with correct type (ci), clear scope (Codecov ignore paths), imperative mood, and is 28 characters—well under the 72-character limit.
Description check ✅ Passed Description includes all required sections with substantive content: Overview explains the purpose, Details lists specific changes, Where to start guides reviewers, and Related Issues is completed. Checkboxes are marked.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Review rate limit: 9/10 reviews remaining, refill in 6 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@willkill07 willkill07 self-assigned this May 4, 2026
@willkill07 willkill07 added this to the 0.2.0 milestone May 4, 2026
@willkill07 willkill07 merged commit ef60fb6 into NVIDIA:main May 4, 2026
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci PR alters/improves CI size:S PR is small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant