ci: use cargo env token for artifactory publish#74
Conversation
Signed-off-by: Will Killian <wkillian@nvidia.com>
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📜 Recent review details🧰 Additional context used📓 Path-based instructions (2){.github/workflows/*.{yml,yaml},.gitlab-ci.yml}📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
Files:
{.github/**,.gitlab-ci.yml,.pre-commit-config.yaml,justfile,scripts/**}⚙️ CodeRabbit configuration file
Files:
🧠 Learnings (2)📚 Learning: 2026-04-15T18:16:52.951ZApplied to files:
📚 Learning: 2026-05-01T13:41:07.485ZApplied to files:
🔇 Additional comments (1)
WalkthroughThe ChangesCargo Artifactory Authentication
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/merge |
Overview
Fix the scheduled Cargo Artifactory publish job after Cargo 1.93 rejected the deprecated command-line token path for the private sparse registry. The job now exposes the existing Artifactory key through Cargo's per-registry token environment variable before publishing.
Details
CARGO_REGISTRIES_ARTIFACTORY_TOKENfromNEMO_FLOW_CI_ARTIFACTORY_KEYinpublish:artifactory:cargo.cargo publish --tokenflag so Cargo reads the Artifactory token through its registry credential environment path.Validation:
ruby -e 'require "yaml"; YAML.load_file(".gitlab-ci.yml"); puts "yaml-ok"'publish:artifactory:cargoscript block and checked it withbash -ngit diff --check.gitlab-ci.ymlWhere should the reviewer start?
Start with
.gitlab-ci.yml, specifically thepublish:artifactory:cargojob lines that configure the Cargo registry token and invokecargo publish.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit