feat: add ATOF JSONL exporter#88
Merged
Merged
Conversation
Signed-off-by: Will Killian <wkillian@nvidia.com>
AnuradhaKaruppiah
approved these changes
May 12, 2026
Member
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds a native filesystem-backed ATOF JSONL exporter that registers as a NeMo Flow event subscriber and writes one raw ATOF
EventJSON object per line.Details
nemo_flow::observability::atof::{AtofExporter, AtofExporterConfig, AtofExporterMode}with append/overwrite modes, default current-directory output, generated UTC filenames, registration, deregistration, flush, and shutdown.Where should the reviewer start?
Start with
crates/core/src/observability/atof.rsfor the exporter behavior, then reviewcrates/core/tests/unit/observability/atof_tests.rsand the FFI/Python/Node/Go binding additions for API parity.Validation run locally:
cargo fmt --allgit diff --checkjust test-rustjust test-pythonjust test-nodejust test-gojust test-wasmjust docscargo test -p nemo-flow observability::atof::tests -- --nocapturelycheeskipped after it reported two unrelated generated Rust API doc links underdocs/reference/api/rust/_generated/nemo-flow-adaptive/...;just docspassed.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)