fix: preserve Hermes error-path export consistency#229
Merged
rapids-bot[bot] merged 4 commits intoJun 5, 2026
Merged
Conversation
Signed-off-by: mnajafian-nv <mnajafian@nvidia.com>
Signed-off-by: mnajafian-nv <mnajafian@nvidia.com>
WalkthroughThis PR updates Rust crate license attributions to reflect Apache-2.0-only licensing and adds comprehensive observability coverage for Hermes API request error handling via OpenInference span metadata repositioning and integration tests that validate error event propagation, fidelity tracking, and metadata serialization across ATOF and ATIF observability pipelines. ChangesLicense Attribution Updates
Hermes API Error Observability
Possibly related PRs
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
2 tasks
Signed-off-by: mnajafian-nv <mnajafian@nvidia.com>
willkill07
approved these changes
Jun 5, 2026
Member
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR tightens Hermes error-path observability consistency by adding exporter-visible
api_request_errorcoverage for ATOF, ATIF, and OpenInference, and by fixing OpenInference metadata so mixed-fidelity Hermes spans reflect the completed event rather than the request start.Details
api_request_errorexports a lossy error-path LLM end event with the expectedapi_call_id, status, retry fields, error payload, and fidelity metadata.api_request_errorproduces an exportable agent step with the expected error response fields and observed-event fidelity markers.api_request_errorproduces JSON output, JSON mime type, and final-event fidelity metadata on the finished LLM span.Validated with:
cargo test -p nemo-relay-cli serve_listener_hermes_api_request_error_writes_lossy_atof_error_event -- --nocapturecargo test -p nemo-relay-cli hermes_api_request_error_writes_atif_error_step_and_fidelity -- --nocapturecargo test -p nemo-relay hermes_api_request_error_emits_openinference_json_output_and_metadata -- --nocapturecargo fmt --all --checkuv run pre-commit run --all-filesWhere should the reviewer start?
Start in
crates/core/src/observability/openinference.rsfor the metadata handling fix, then reviewcrates/cli/tests/coverage/server_tests.rsfor the Hermes ATOF error-path regression,crates/cli/tests/coverage/session_tests.rsfor the ATIF error-path regression, andcrates/core/tests/unit/observability/openinference_tests.rsfor the OpenInference mixed-fidelity error-path coverage.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)