Skip to content

feat: Add Deep Agents integration#90

Merged
rapids-bot[bot] merged 41 commits into
NVIDIA:release/0.2from
dagardner-nv:david-deepagents-int-p2
May 14, 2026
Merged

feat: Add Deep Agents integration#90
rapids-bot[bot] merged 41 commits into
NVIDIA:release/0.2from
dagardner-nv:david-deepagents-int-p2

Conversation

@dagardner-nv
Copy link
Copy Markdown
Contributor

@dagardner-nv dagardner-nv commented May 12, 2026

Overview

  • Primary entry point for end-users is the add_nemo_flow_integration method, which adds NeMo Flow middleware to the agent and subagents (if any).
  • Emit a mark when skills are loaded and HITL events
  • langgraph is promoted from a transitive dep to a direct-dep in the langchain extra since python/nemo_flow/integrations/langchain/_serialization.py now imports from langgraph
  • Adds work-around for installing OpenSSL on Windows-Arm CI runners
  • I confirm this contribution is my own work, or I have the right to submit it under this project's license.
  • I searched existing issues and open pull requests, and this does not duplicate existing work.

Details

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • Closes #

Summary by CodeRabbit

  • New Features

    • Deep Agents integration: observability for agent runs, tool calls, filesystem/sandbox operations, human-in-the-loop events, backend instrumentation, and middleware marks.
  • Documentation

    • Added Deep Agents integration README with setup, usage, and observed-event examples.
  • Tests

    • New integration and end-to-end tests covering middleware, backend instrumentation, sandbox behavior, and HITL flows; added shared test fixture.
  • Chores

    • Added optional Deep Agents dependency group and regenerated third‑party attributions/licenses.
  • CI

    • Updated CI and dev sync steps to include Deep Agents extras and platform-specific setup.

Review Change Stack

Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
… interupts

Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
@dagardner-nv dagardner-nv self-assigned this May 12, 2026
@dagardner-nv dagardner-nv added lang:python PR changes/introduces Python code Feature a new feature labels May 12, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 12, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

Adds a Deep Agents observability integration: event utilities, middleware, backend wrappers, LangGraph callback handler, package wiring (add_nemo_flow_integration), docs, tests, and updated attributions and CI/build syncs.

Changes

Deep Agents NeMo Flow Integration

Layer / File(s) Summary
Observability event data and emission
python/nemo_flow/integrations/deepagents/_events.py
Tool/backend categorization; JSON-safe summarization; builders for tool/backend event payloads; unified emit_mark to send standardized NeMo Flow marks.
Backend observability wrapper
python/nemo_flow/integrations/deepagents/backend.py
NemoFlowDeepAgentsBackend and NemoFlowDeepAgentsSandboxBackend proxy filesystem and execute methods, emitting start/error/end marks; observe_backend factory selects appropriate wrapper and validates sandbox timeouts.
LangGraph callback handler
python/nemo_flow/integrations/deepagents/callbacks.py
NemoFlowDeepAgentsCallbackHandler correlates Graph Interrupt/Resume events for HITL, tracks pending keys, and emits human_in_the_loop marks with phase and payload metadata.
Tool call middleware
python/nemo_flow/integrations/deepagents/middleware.py
NemoFlowDeepAgentsMiddleware emits skill/configured marks and wraps sync/async tool calls to emit start/error/end marks with normalized args, tool kind, and result/error payloads.
Package integration and helper
python/nemo_flow/integrations/deepagents/__init__.py
add_nemo_flow_integration merges kwargs/overrides, normalizes skills/subagent summaries, optionally instruments subagents, wraps backends via observe_backend, injects middleware, and re-exports integration symbols.
Integration documentation
python/nemo_flow/integrations/deepagents/README.md
New README with setup, usage example, and enumerated observable events captured by the integration.
Test fixtures and integration tests
python/tests/conftest.py, python/tests/integrations/deepagents/test_deepagents_integration.py
Shared subscribed_events fixture and comprehensive tests covering middleware, callback HITL handling, backend observation (sync/async), sandbox behavior, wiring, and an end-to-end agent test.
Dependencies and license attributions
pyproject.toml, ATTRIBUTIONS-Python.md
Adds deepagents optional-dependency (includes nemo-flow[langgraph]); regenerates attributions with many new/updated entries and license formatting adjustments.
CI and build sync updates
.github/workflows/*, justfile
Pre-commit/CI/justfile uv sync now includes langgraph and deepagents extras; CI Test job adds Windows ARM64 vcpkg OpenSSL provisioning step.
Existing test module updates
python/tests/integrations/langchain/test_middleware.py, python/tests/integrations/langgraph/test_langgraph_integration.py
Moves subscribed_events fixture to shared conftest, updates BaseChatModel import path, and removes unused Iterator import.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 16.48% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive PR description provides overview and confirms contributor obligations but lacks concrete implementation details, file references, testing approach, and related issue tracking. Add details about what was implemented (files, design decisions), where reviewers should start, and fill in the related issue number. Describe the Deep Agents integration strategy and any non-obvious implementation choices.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed Title follows Conventional Commits format with 'feat' type and concise summary under 72 characters.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the size:XL PR is extra large label May 12, 2026
Signed-off-by: David Gardner <dagardner@nvidia.com>
[skip ci]

Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
@dagardner-nv
Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 12, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Signed-off-by: David Gardner <dagardner@nvidia.com>
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ATTRIBUTIONS-Python.md`:
- Around line 645-659: Several attribution blocks (e.g., the "## anthropic
(0.101.0)" section and its LICENSE code fence) violate MD022/MD031/MD040; update
the generator/template that emits these blocks to ensure a blank line before and
after each heading and before/after fenced code blocks, and emit fenced code
blocks with an explicit language (e.g., use ```text for LICENSE contents) so
lint rules are satisfied; then re-generate the affected sections (including
other listed ranges) and run the repo formatter on changed Markdown files (per
the project rule for **/*.{py,js,ts,tsx,go,rs,md}) to ensure consistent
formatting.

In `@python/nemo_flow/integrations/deepagents/middleware.py`:
- Around line 122-139: The method _emit_tool_mark is missing an explicit return
type annotation; update its signature to include a return type of None (e.g.,
def _emit_tool_mark(... ) -> None:) so the function's void nature is explicit
for linters and type checkers; locate the _emit_tool_mark method in
middleware.py and add the -> None annotation to its signature without changing
the body.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 1b49494b-9580-43bf-8ffc-d78d6a068946

📥 Commits

Reviewing files that changed from the base of the PR and between 3e09970 and aa3b66e.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (12)
  • ATTRIBUTIONS-Python.md
  • pyproject.toml
  • python/nemo_flow/integrations/deepagents/README.md
  • python/nemo_flow/integrations/deepagents/__init__.py
  • python/nemo_flow/integrations/deepagents/_events.py
  • python/nemo_flow/integrations/deepagents/backend.py
  • python/nemo_flow/integrations/deepagents/callbacks.py
  • python/nemo_flow/integrations/deepagents/middleware.py
  • python/tests/conftest.py
  • python/tests/integrations/deepagents/test_deepagents_integration.py
  • python/tests/integrations/langchain/test_middleware.py
  • python/tests/integrations/langgraph/test_langgraph_integration.py
💤 Files with no reviewable changes (1)
  • python/tests/integrations/langgraph/test_langgraph_integration.py
📜 Review details
🧰 Additional context used
📓 Path-based instructions (29)
**/*.{md,rst,html,txt}

📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-brand-terminology.md)

**/*.{md,rst,html,txt}: Always spell NVIDIA in all caps. Do not use Nvidia, nvidia, nVidia, nVIDIA, or NV.
Use an NVIDIA before a noun because the name starts with an 'en' sound.
Do not add a registered trademark symbol after NVIDIA when referring to the company.
Use trademark symbols with product names only when the document type or legal guidance requires them.
Verify official capitalization, spacing, and hyphenation for product names.
Precede NVIDIA product names with NVIDIA on first mention when it is natural and accurate.
Do not rewrite product names for grammar or title-case rules.
Preserve third-party product names according to the owner's spelling.
Include the company name and full model qualifier on first use when it helps identify the model.
Preserve the official capitalization and punctuation of model names.
Use shorter family names only after the full name is established.
Spell out a term on first use and put the acronym in parentheses unless the acronym is widely understood by the intended audience.
Use the acronym on later mentions after it has been defined.
For long documents, reintroduce the full term if readers might lose context.
Form plurals of acronyms with s, not an apostrophe, such as GPUs.
In headings, common acronyms can remain abbreviated. Spell out the term in the first or second sentence of the body.
Common terms such as CPU, GPU, PC, API, and UI usually do not need to be spelled out for developer audiences.

Files:

  • python/nemo_flow/integrations/deepagents/README.md
  • ATTRIBUTIONS-Python.md
**/*.{md,rst,html}

📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-brand-terminology.md)

Link the first mention of a product name when the destination helps the reader.

Files:

  • python/nemo_flow/integrations/deepagents/README.md
  • ATTRIBUTIONS-Python.md
**/*.{md,rst,txt}

📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-guide.md)

**/*.{md,rst,txt}: Spell NVIDIA in all caps. Do not use Nvidia, nvidia, or NV.
Format commands, code elements, expressions, package names, file names, and paths as inline code.
Use descriptive link text. Avoid raw URLs and weak anchors such as 'here' or 'read more.'
Use title case consistently for technical documentation headings.
Introduce code blocks, lists, tables, and images with complete sentences.
Write procedures as imperative steps. Keep steps parallel and split long procedures into smaller tasks.
Prefer active voice, present tense, short sentences, contractions, and plain English.
Use can for possibility and reserve may for permission.
Use after for temporal relationships instead of once.
Prefer refer to over see when the wording points readers to another resource.
Avoid culture-specific idioms, unnecessary Latinisms, jokes, and marketing exaggeration in technical documentation.
Spell out months in body text, avoid ordinal dates, and use clear time zones.
Spell out whole numbers from zero through nine unless they are technical values, parameters, versions, or UI values.
Use numerals for 10 or greater and include commas in thousands.
Do not add trademark symbols to learning-oriented documentation unless the source, platform, or legal guidance explicitly requires them.
Do not add trademark symbols to NeMo Flow learning documentation by default.
Do not rewrite API names, package names, command flags, or code literals for style reasons.

Files:

  • python/nemo_flow/integrations/deepagents/README.md
  • ATTRIBUTIONS-Python.md
**/*.{md,markdown,rst}

📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-technical-docs.md)

**/*.{md,markdown,rst}: Use title case consistently in technical documentation headings
Avoid quotation marks, ampersands, and exclamation marks in headings
Keep product, event, research, and whitepaper names in their official title case
Use title case for table headers
Do not force social-media sentence case into technical docs
Use monospace formatting for code elements, commands, parameters, package names, and expressions
Use monospace formatting for directories, file names, and paths
Use angle brackets inside monospace for variables inside paths, such as /home/<username>/.login
Use quotation marks for error messages and strings in documentation
Use bold formatting for UI buttons, menus, fields, and labels in documentation
Use angle brackets between UI labels for menu paths, such as File > Save As
Use italics for new terms on first use in documentation
Use italics for publication titles in documentation
Use plain text formatting for keyboard shortcuts in documentation
Prefer [NVIDIA/NeMo](link) format for GitHub repository references over generic phrases like 'the GitHub repo'
Introduce every code block with a complete sentence
Do not make a code block complete the grammar of the previous sentence
Do not continue a sentence after a code block
Use syntax highlighting when the format supports it for code blocks
Avoid the word 'snippet' unless the surrounding docs already use it as a term of art
Keep inline method, function, and class references consistent with nearby docs, omitting empty parentheses for prose readability when no call is shown
Use descriptive anchor text that matches the destination title when possible for links
Avoid raw URLs in running text in documentation
Avoid generic link anchors such as 'here,' 'this page,' and 'read more' in documentation
Include the acronym in link text if a linked term includes an acronym
Do not link long sentences or multiple sentences in documentation
Avoid links that pull readers away from a procedure unles...

Files:

  • python/nemo_flow/integrations/deepagents/README.md
  • ATTRIBUTIONS-Python.md
**/*.{html,md}

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Include SPDX license headers in HTML and Markdown files using HTML comment syntax

Files:

  • python/nemo_flow/integrations/deepagents/README.md
  • ATTRIBUTIONS-Python.md
**/README.md

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Update relevant crate or package README when that surface changed

Relevant package or crate README.md files must be updated when examples or binding guidance changes

Files:

  • python/nemo_flow/integrations/deepagents/README.md
**/*.md

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Run Markdown link checking via lychee for README.md, CONTRIBUTING.md, and docs/ through pre-commit hooks

Files:

  • python/nemo_flow/integrations/deepagents/README.md
  • ATTRIBUTIONS-Python.md
**/*.{md,markdown,py,sh,bash,js,ts,java,cpp,go,rust}

📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)

Keep package names, repo references, and build commands current in documentation

Files:

  • python/nemo_flow/integrations/deepagents/README.md
  • python/tests/integrations/langchain/test_middleware.py
  • python/tests/conftest.py
  • python/nemo_flow/integrations/deepagents/callbacks.py
  • python/nemo_flow/integrations/deepagents/_events.py
  • python/nemo_flow/integrations/deepagents/__init__.py
  • python/nemo_flow/integrations/deepagents/backend.py
  • python/nemo_flow/integrations/deepagents/middleware.py
  • ATTRIBUTIONS-Python.md
  • python/tests/integrations/deepagents/test_deepagents_integration.py
**/*.{md,markdown,py,sh,bash}

📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)

Keep stable user-facing wrappers at scripts/ root in docs and examples; only point at namespaced helper paths when documenting internal maintenance work

Files:

  • python/nemo_flow/integrations/deepagents/README.md
  • python/tests/integrations/langchain/test_middleware.py
  • python/tests/conftest.py
  • python/nemo_flow/integrations/deepagents/callbacks.py
  • python/nemo_flow/integrations/deepagents/_events.py
  • python/nemo_flow/integrations/deepagents/__init__.py
  • python/nemo_flow/integrations/deepagents/backend.py
  • python/nemo_flow/integrations/deepagents/middleware.py
  • ATTRIBUTIONS-Python.md
  • python/tests/integrations/deepagents/test_deepagents_integration.py
**/*.{md,markdown,py,sh,bash,js,ts,example}

📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)

Example commands must match current package names and paths

Files:

  • python/nemo_flow/integrations/deepagents/README.md
  • python/tests/integrations/langchain/test_middleware.py
  • python/tests/conftest.py
  • python/nemo_flow/integrations/deepagents/callbacks.py
  • python/nemo_flow/integrations/deepagents/_events.py
  • python/nemo_flow/integrations/deepagents/__init__.py
  • python/nemo_flow/integrations/deepagents/backend.py
  • python/nemo_flow/integrations/deepagents/middleware.py
  • ATTRIBUTIONS-Python.md
  • python/tests/integrations/deepagents/test_deepagents_integration.py
**/{integrations,integration,*-integration}/**

📄 CodeRabbit inference engine (.agents/skills/contribute-integration/SKILL.md)

**/{integrations,integration,*-integration}/**: Keep NeMo Flow optional in framework integrations
Preserve the framework's original behavior when NeMo Flow is absent
Wrap tool and LLM paths at the correct framework boundary
Integration pattern must follow docs/integrate-frameworks/adding-scopes.md

Files:

  • python/nemo_flow/integrations/deepagents/README.md
  • python/tests/integrations/langchain/test_middleware.py
  • python/nemo_flow/integrations/deepagents/callbacks.py
  • python/nemo_flow/integrations/deepagents/_events.py
  • python/nemo_flow/integrations/deepagents/__init__.py
  • python/nemo_flow/integrations/deepagents/backend.py
  • python/nemo_flow/integrations/deepagents/middleware.py
  • python/tests/integrations/deepagents/test_deepagents_integration.py
{docs/**,examples/**,crates/adaptive/**,python/nemo_flow/**,go/nemo_flow/**,**/{example,component}.{ts,tsx,js,rs,py,go}}

📄 CodeRabbit inference engine (.agents/skills/maintain-optimizer/SKILL.md)

Any new adaptive component kind must have documentation, examples, and binding coverage across all supported languages

Files:

  • python/nemo_flow/integrations/deepagents/README.md
  • python/nemo_flow/integrations/deepagents/callbacks.py
  • python/nemo_flow/integrations/deepagents/_events.py
  • python/nemo_flow/integrations/deepagents/__init__.py
  • python/nemo_flow/integrations/deepagents/backend.py
  • python/nemo_flow/integrations/deepagents/middleware.py
**/*.{md,txt,rst}

📄 CodeRabbit inference engine (.agents/skills/review-doc-style/SKILL.md)

**/*.{md,txt,rst}: Ensure commands, package names, file paths, and APIs in documentation are correct and not stale; flag incorrect or outdated information as blocking issues
Ensure examples and procedures in documentation will execute successfully with current APIs and commands
Use consistent user-facing terminology throughout documentation that matches current repo terminology
Capitalize NVIDIA correctly in all documentation and public-facing text
Format code, commands, paths, and filenames as inline code (monospace) in documentation
Use descriptive anchor text for links instead of bare URLs or weak labels like 'here' in documentation
Prefer active voice, present tense, short sentences, and plain English in documentation
Structure documentation procedures as imperative steps that are easy to scan and not too long for a single sequence
Prefer 'after' instead of 'once' for temporal references in documentation
Use 'can' instead of 'may' when describing possibility (rather than permission) in documentation
Avoid ambiguous numeric dates and ordinal dates in documentation body text

Files:

  • python/nemo_flow/integrations/deepagents/README.md
  • ATTRIBUTIONS-Python.md
{README.md,docs/index.md,**/README.md}

📄 CodeRabbit inference engine (.agents/skills/review-doc-style/SKILL.md)

Update entry-point documentation (README.md, docs/index.md, package READMEs, binding-level source READMEs) whenever public behavior changes

Files:

  • python/nemo_flow/integrations/deepagents/README.md
**/*.{py,js,ts,tsx,go,rs,md}

📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)

Format changed files with the language-native formatter before the final lint/test pass

Files:

  • python/nemo_flow/integrations/deepagents/README.md
  • python/tests/integrations/langchain/test_middleware.py
  • python/tests/conftest.py
  • python/nemo_flow/integrations/deepagents/callbacks.py
  • python/nemo_flow/integrations/deepagents/_events.py
  • python/nemo_flow/integrations/deepagents/__init__.py
  • python/nemo_flow/integrations/deepagents/backend.py
  • python/nemo_flow/integrations/deepagents/middleware.py
  • ATTRIBUTIONS-Python.md
  • python/tests/integrations/deepagents/test_deepagents_integration.py
python/nemo_flow/**/*

⚙️ CodeRabbit configuration file

python/nemo_flow/**/*: Review Python wrapper changes for typed API consistency, contextvars-based scope isolation, async behavior, and parity with the native extension.
Stubs and runtime implementations should stay aligned.

Files:

  • python/nemo_flow/integrations/deepagents/README.md
  • python/nemo_flow/integrations/deepagents/callbacks.py
  • python/nemo_flow/integrations/deepagents/_events.py
  • python/nemo_flow/integrations/deepagents/__init__.py
  • python/nemo_flow/integrations/deepagents/backend.py
  • python/nemo_flow/integrations/deepagents/middleware.py
**/*.toml

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Include SPDX license headers in TOML files using TOML comment syntax

Files:

  • pyproject.toml
{Cargo.toml,setup.py,setup.cfg,pyproject.toml,go.mod,go.sum,package.json,package-lock.json,yarn.lock,pom.xml,*.gradle}

📄 CodeRabbit inference engine (.agents/skills/rename-surfaces/SKILL.md)

Update repository manifest files (Cargo.toml, setup.py, go.mod, package.json, etc.) with new package/crate names during rename operations

Files:

  • pyproject.toml
{Cargo.toml,pyproject.toml,go/nemo_flow/go.mod,package.json,package-lock.json,crates/node/package.json}

📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)

Maintain consistent package names, import paths, and module names across Rust, Python, Go, Node, and WebAssembly workspaces in NeMo Flow

Files:

  • pyproject.toml
**/*.py

📄 CodeRabbit inference engine (.agents/skills/test-python-binding/SKILL.md)

Format changed Python wrapper and test files with uv run ruff format python

**/*.py: Use Ruff with rule sets E, F, W, I for Python linting
Use Ruff formatter for Python code with line length 120 and double quotes
Use ty for Python type checking
Use snake_case naming convention for Python code
Include SPDX license headers in all Python source files using Python comment syntax

Files:

  • python/tests/integrations/langchain/test_middleware.py
  • python/tests/conftest.py
  • python/nemo_flow/integrations/deepagents/callbacks.py
  • python/nemo_flow/integrations/deepagents/_events.py
  • python/nemo_flow/integrations/deepagents/__init__.py
  • python/nemo_flow/integrations/deepagents/backend.py
  • python/nemo_flow/integrations/deepagents/middleware.py
  • python/tests/integrations/deepagents/test_deepagents_integration.py
**/test_*.py

📄 CodeRabbit inference engine (.agents/skills/test-python-binding/SKILL.md)

Run focused pytest first when you know the affected area using pytest -k "<pattern>"

Files:

  • python/tests/integrations/langchain/test_middleware.py
  • python/tests/integrations/deepagents/test_deepagents_integration.py
**/*.{rs,py,go,js,ts,tsx}

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Use SONAR_IGNORE_START / SONAR_IGNORE_END markers only for documented false positives that cannot be resolved in code; keep ignored blocks small, add explanatory comments, and require reviewer sign-off

Files:

  • python/tests/integrations/langchain/test_middleware.py
  • python/tests/conftest.py
  • python/nemo_flow/integrations/deepagents/callbacks.py
  • python/nemo_flow/integrations/deepagents/_events.py
  • python/nemo_flow/integrations/deepagents/__init__.py
  • python/nemo_flow/integrations/deepagents/backend.py
  • python/nemo_flow/integrations/deepagents/middleware.py
  • python/tests/integrations/deepagents/test_deepagents_integration.py
**/*.{js,ts,tsx,jsx,py,rs,go,java,c,cpp,h,cc,cxx,cs,rb,php,swift,kt}

📄 CodeRabbit inference engine (.agents/skills/prepare-pr/SKILL.md)

Changed files must be formatted with the language-native formatter

Files:

  • python/tests/integrations/langchain/test_middleware.py
  • python/tests/conftest.py
  • python/nemo_flow/integrations/deepagents/callbacks.py
  • python/nemo_flow/integrations/deepagents/_events.py
  • python/nemo_flow/integrations/deepagents/__init__.py
  • python/nemo_flow/integrations/deepagents/backend.py
  • python/nemo_flow/integrations/deepagents/middleware.py
  • python/tests/integrations/deepagents/test_deepagents_integration.py
python/**/*.py

📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)

python/**/*.py: If Python language surface changed, always run Python test target even when Rust core did not change
For Python changes, use uv run ruff format python to format Python files

Files:

  • python/tests/integrations/langchain/test_middleware.py
  • python/tests/conftest.py
  • python/nemo_flow/integrations/deepagents/callbacks.py
  • python/nemo_flow/integrations/deepagents/_events.py
  • python/nemo_flow/integrations/deepagents/__init__.py
  • python/nemo_flow/integrations/deepagents/backend.py
  • python/nemo_flow/integrations/deepagents/middleware.py
  • python/tests/integrations/deepagents/test_deepagents_integration.py
**/*.{rs,py,js,ts,tsx,go}

📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)

During iteration, prefer uv run pre-commit run --files <changed files...> for targeted validation

Files:

  • python/tests/integrations/langchain/test_middleware.py
  • python/tests/conftest.py
  • python/nemo_flow/integrations/deepagents/callbacks.py
  • python/nemo_flow/integrations/deepagents/_events.py
  • python/nemo_flow/integrations/deepagents/__init__.py
  • python/nemo_flow/integrations/deepagents/backend.py
  • python/nemo_flow/integrations/deepagents/middleware.py
  • python/tests/integrations/deepagents/test_deepagents_integration.py
{crates/**/tests/**,python/tests/**,go/nemo_flow/**/*_test.go}

⚙️ CodeRabbit configuration file

{crates/**/tests/**,python/tests/**,go/nemo_flow/**/*_test.go}: Tests should cover the behavior promised by the changed API surface, including error paths and cross-request isolation where relevant.
Prefer assertions on lifecycle events, scope stacks, middleware ordering, and binding parity over shallow smoke tests.

Files:

  • python/tests/integrations/langchain/test_middleware.py
  • python/tests/conftest.py
  • python/tests/integrations/deepagents/test_deepagents_integration.py
python/nemo_flow/**/*.py

📄 CodeRabbit inference engine (.agents/skills/add-binding-feature/SKILL.md)

Use snake_case naming convention for Python API implementations and wrappers

Files:

  • python/nemo_flow/integrations/deepagents/callbacks.py
  • python/nemo_flow/integrations/deepagents/_events.py
  • python/nemo_flow/integrations/deepagents/__init__.py
  • python/nemo_flow/integrations/deepagents/backend.py
  • python/nemo_flow/integrations/deepagents/middleware.py
{README*,CHANGELOG*,docs/**/*.{md,rst,txt},examples/**/*,*.md}

📄 CodeRabbit inference engine (.agents/skills/rename-surfaces/SKILL.md)

Update documentation, examples, and getting-started guides with new package/module/crate names after rename operations

Files:

  • ATTRIBUTIONS-Python.md
**/{tests,test}/**/*{integration,smoke}*.py

📄 CodeRabbit inference engine (.agents/skills/contribute-integration/SKILL.md)

Relevant integration tests or smoke path must pass before contribution

Files:

  • python/tests/integrations/deepagents/test_deepagents_integration.py
🪛 markdownlint-cli2 (0.22.1)
ATTRIBUTIONS-Python.md

[warning] 647-647: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)


[warning] 651-651: Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)


[warning] 651-651: Fenced code blocks should have a language specified

(MD040, fenced-code-language)


[warning] 1524-1524: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)


[warning] 1528-1528: Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)


[warning] 1528-1528: Fenced code blocks should have a language specified

(MD040, fenced-code-language)


[warning] 1601-1601: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)


[warning] 1605-1605: Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)


[warning] 1605-1605: Fenced code blocks should have a language specified

(MD040, fenced-code-language)


[warning] 1910-1910: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)


[warning] 1914-1914: Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)


[warning] 1914-1914: Fenced code blocks should have a language specified

(MD040, fenced-code-language)


[warning] 1958-1958: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)


[warning] 1962-1962: Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)


[warning] 1962-1962: Fenced code blocks should have a language specified

(MD040, fenced-code-language)


[warning] 2261-2261: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)


[warning] 2265-2265: Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)


[warning] 2265-2265: Fenced code blocks should have a language specified

(MD040, fenced-code-language)


[warning] 2471-2471: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)


[warning] 2475-2475: Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)


[warning] 2475-2475: Fenced code blocks should have a language specified

(MD040, fenced-code-language)


[warning] 2501-2501: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)


[warning] 2505-2505: Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)


[warning] 2505-2505: Fenced code blocks should have a language specified

(MD040, fenced-code-language)


[warning] 2759-2759: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)


[warning] 2763-2763: Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)


[warning] 2763-2763: Fenced code blocks should have a language specified

(MD040, fenced-code-language)


[warning] 2969-2969: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)


[warning] 2973-2973: Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)


[warning] 2973-2973: Fenced code blocks should have a language specified

(MD040, fenced-code-language)


[warning] 3715-3715: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)


[warning] 3719-3719: Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)


[warning] 3719-3719: Fenced code blocks should have a language specified

(MD040, fenced-code-language)


[warning] 3829-3829: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)


[warning] 3833-3833: Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)


[warning] 3833-3833: Fenced code blocks should have a language specified

(MD040, fenced-code-language)


[warning] 3869-3869: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)


[warning] 3873-3873: Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)


[warning] 3873-3873: Fenced code blocks should have a language specified

(MD040, fenced-code-language)


[warning] 5507-5507: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)


[warning] 5511-5511: Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)


[warning] 5511-5511: Fenced code blocks should have a language specified

(MD040, fenced-code-language)


[warning] 5540-5540: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)


[warning] 5544-5544: Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)


[warning] 5544-5544: Fenced code blocks should have a language specified

(MD040, fenced-code-language)


[warning] 5573-5573: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)


[warning] 5577-5577: Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)


[warning] 5577-5577: Fenced code blocks should have a language specified

(MD040, fenced-code-language)


[warning] 7238-7238: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)


[warning] 7242-7242: Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)


[warning] 7242-7242: Fenced code blocks should have a language specified

(MD040, fenced-code-language)


[warning] 9317-9317: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)


[warning] 9321-9321: Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)


[warning] 9321-9321: Fenced code blocks should have a language specified

(MD040, fenced-code-language)


[warning] 9383-9383: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)


[warning] 9387-9387: Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)


[warning] 9387-9387: Fenced code blocks should have a language specified

(MD040, fenced-code-language)

🪛 Ruff (0.15.12)
python/nemo_flow/integrations/deepagents/callbacks.py

[warning] 20-20: Dynamically typed expressions (typing.Any) are disallowed in *args

(ANN401)


[warning] 20-20: Dynamically typed expressions (typing.Any) are disallowed in **kwargs

(ANN401)


[warning] 57-57: Dynamically typed expressions (typing.Any) are disallowed in value

(ANN401)


[warning] 70-70: Dynamically typed expressions (typing.Any) are disallowed in interrupt

(ANN401)


[warning] 76-76: Dynamically typed expressions (typing.Any) are disallowed in value

(ANN401)


[warning] 86-86: Dynamically typed expressions (typing.Any) are disallowed in value

(ANN401)

python/nemo_flow/integrations/deepagents/_events.py

[warning] 72-72: Dynamically typed expressions (typing.Any) are disallowed in value

(ANN401)


[warning] 85-85: Too many return statements (7 > 6)

(PLR0911)


[warning] 85-85: Dynamically typed expressions (typing.Any) are disallowed in value

(ANN401)


[warning] 114-114: Dynamically typed expressions (typing.Any) are disallowed in result

(ANN401)


[warning] 147-147: Dynamically typed expressions (typing.Any) are disallowed in result

(ANN401)


[warning] 187-187: Do not catch blind exception: Exception

(BLE001)

python/nemo_flow/integrations/deepagents/__init__.py

[warning] 21-21: Dynamically typed expressions (typing.Any) are disallowed in **overrides

(ANN401)


[warning] 74-74: Dynamically typed expressions (typing.Any) are disallowed in subagent

(ANN401)


[warning] 74-74: Dynamically typed expressions (typing.Any) are disallowed in _instrument_subagent

(ANN401)


[warning] 92-92: Dynamically typed expressions (typing.Any) are disallowed in subagent

(ANN401)


[warning] 111-111: Dynamically typed expressions (typing.Any) are disallowed in value

(ANN401)

python/nemo_flow/integrations/deepagents/backend.py

[warning] 41-41: Dynamically typed expressions (typing.Any) are disallowed in __getattr__

(ANN401)


[warning] 170-170: Dynamically typed expressions (typing.Any) are disallowed in _call_sync

(ANN401)


[warning] 200-200: Dynamically typed expressions (typing.Any) are disallowed in _call_async

(ANN401)


[warning] 237-237: Async function definition with a timeout parameter

(ASYNC109)


[warning] 247-247: Avoid specifying long messages outside the exception class

(TRY003)


[warning] 251-251: Dynamically typed expressions (typing.Any) are disallowed in backend

(ANN401)

python/nemo_flow/integrations/deepagents/middleware.py

[warning] 44-44: Unused method argument: state

(ARG002)


[warning] 44-44: Dynamically typed expressions (typing.Any) are disallowed in state

(ANN401)


[warning] 44-44: Unused method argument: runtime

(ARG002)


[warning] 44-44: Dynamically typed expressions (typing.Any) are disallowed in runtime

(ANN401)


[warning] 48-48: Unused method argument: state

(ARG002)


[warning] 48-48: Dynamically typed expressions (typing.Any) are disallowed in state

(ANN401)


[warning] 48-48: Unused method argument: runtime

(ARG002)


[warning] 48-48: Dynamically typed expressions (typing.Any) are disallowed in runtime

(ANN401)


[warning] 115-118: Use ternary operator tool_args = raw_args if isinstance(raw_args, Mapping) else {"value": raw_args} instead of if-else-block

Replace if-else-block with tool_args = raw_args if isinstance(raw_args, Mapping) else {"value": raw_args}

(SIM108)


[warning] 122-122: Missing return type annotation for private function _emit_tool_mark

Add return type annotation: None

(ANN202)


[warning] 129-129: Dynamically typed expressions (typing.Any) are disallowed in result

(ANN401)

python/tests/integrations/deepagents/test_deepagents_integration.py

[warning] 32-32: Dynamically typed expressions (typing.Any) are disallowed in func

(ANN401)


[warning] 32-32: Dynamically typed expressions (typing.Any) are disallowed in args

(ANN401)


[warning] 32-32: Unused function argument: kwargs

(ARG001)


[warning] 32-32: Dynamically typed expressions (typing.Any) are disallowed in **kwargs

(ANN401)


[warning] 32-32: Dynamically typed expressions (typing.Any) are disallowed in execute_side_effect

(ANN401)


[warning] 142-142: Unused function argument: request

(ARG001)


[warning] 143-143: Avoid specifying long messages outside the exception class

(TRY003)


[warning] 145-146: Use a single with statement with multiple contexts instead of nested with statements

(SIM117)

🔇 Additional comments (50)
python/tests/integrations/langchain/test_middleware.py (1)

15-15: Import update is clean and low-risk.

No concerns with this change in the test module.

pyproject.toml (1)

87-90: Optional dependency group addition looks correct.

The new deepagents extra is well-scoped and appropriately version-bounded.

ATTRIBUTIONS-Python.md (1)

1956-1964: ⚡ Quick win

No action needed. The deepagents 0.5.9 package is correctly attributed with the MIT license in the file. The note about no license file in the locked artifact is contextual information indicating the license is sourced from package metadata rather than a bundled file—a common pattern. The attribution is complete and compliant.

python/tests/conftest.py (1)

18-30: LGTM!

The fixture implementation is clean and follows pytest best practices. Using uuid4() for subscriber names prevents collisions in parallel test runs, and the yield-based teardown ensures deregistration even if tests fail.

python/nemo_flow/integrations/deepagents/README.md (2)

6-49: LGTM!

The setup instructions and usage example are clear and well-structured. The code blocks are properly introduced with complete sentences, following documentation guidelines.


51-67: LGTM!

The feature documentation clearly describes the integration's observability scope and remote async subagent limitations.

python/nemo_flow/integrations/deepagents/_events.py (6)

34-69: LGTM!

The categorization helpers correctly map Deep Agents tool and backend names to semantic categories with appropriate fallbacks.


72-82: LGTM!

The json_safe function correctly handles nested structures and edge cases, with appropriate fallback to repr() for non-JSON-serializable values.


85-107: LGTM!

The summarize_value function appropriately handles different value types and extracts relevant attributes from message-like objects for observability payloads.


110-138: LGTM!

The tool_event_data builder correctly extracts relevant fields from tool arguments and includes optional result/error information.


141-161: LGTM!

The backend_event_data builder provides consistent payload structure for backend method calls.


164-188: LGTM!

The broad exception catch at line 187 is appropriate for observability code. It ensures mark emission failures never disrupt application flow while preserving diagnostic information via debug logging.

python/nemo_flow/integrations/deepagents/callbacks.py (7)

20-22: LGTM!

The initialization correctly sets up the HITL tracking state and delegates to the parent handler.


24-36: LGTM!

The mark emission logic correctly distinguishes HITL interrupts from other graph interrupts, with safe state tracking using discard().


38-45: LGTM!

The HITL mark emission correctly wraps the shared emit_mark utility with appropriate metadata.


47-54: LGTM!

The key generation correctly handles the checkpoint namespace as a sequence while properly excluding string types.


56-60: LGTM!

The string normalization helper is straightforward and correct.


62-67: LGTM!

The HITL interrupt detection correctly validates the interrupts collection and delegates to payload checking.


69-89: LGTM!

The HITL payload detection correctly validates the nested Deep Agents human-in-the-loop structure with appropriate type guards.

python/nemo_flow/integrations/deepagents/middleware.py (5)

29-42: LGTM!

The initialization correctly stores configuration and converts sequences to lists for safe mutation.


44-50: LGTM!

The lifecycle hooks correctly emit configuration marks. The unused state and runtime parameters are part of the middleware protocol signature.


52-68: LGTM!

The synchronous tool wrapper correctly emits lifecycle marks with proper error handling that preserves exceptions.


70-86: LGTM!

The async tool wrapper mirrors the sync implementation with correct await handling.


88-109: LGTM!

The configuration mark emission correctly builds a payload from available configuration and only emits when data is present.

python/nemo_flow/integrations/deepagents/backend.py (8)

32-42: LGTM!

The wrapper initialization and delegation pattern correctly implements the transparent proxy pattern with __wrapped__ and __getattr__.


44-98: LGTM!

The filesystem method wrappers correctly delegate to the instrumented call helpers with appropriate sync/async handling.


100-110: LGTM!

The file transfer methods are correctly implemented.


112-161: LGTM!

The convenience methods correctly wrap the base methods with appropriate event name overrides, and single-file download correctly extracts the first result.


163-191: LGTM!

The synchronous call wrapper correctly emits lifecycle marks with proper error handling.


193-221: LGTM!

The async call wrapper mirrors the sync implementation with correct await handling.


224-248: LGTM!

The sandbox backend wrapper correctly preserves the sandbox protocol while adding observability. The timeout validation at line 246-247 prevents invalid configurations from being passed to backends that don't support per-command timeouts.


251-257: LGTM!

The factory function correctly selects the appropriate wrapper based on the backend's protocol support, avoiding double-wrapping.

python/nemo_flow/integrations/deepagents/__init__.py (8)

16-36: LGTM!

The function correctly merges kwargs and overrides, and processes configuration sequences with appropriate helpers.


37-48: LGTM!

The backend instrumentation logic correctly handles already-wrapped backends and conditional wrapping based on the instrument_backend flag.


50-60: LGTM!

The middleware injection correctly uses the deduplication helper to avoid adding duplicate middleware.


62-65: LGTM!

The subagent instrumentation correctly applies instrumentation conditionally and returns the modified kwargs.


68-71: LGTM!

The middleware deduplication correctly prevents adding duplicate NeMo Flow middleware instances.


74-89: LGTM!

The subagent instrumentation correctly preserves non-dict subagents while adding middleware to dict-based subagents.


92-108: LGTM!

The subagent summary builder correctly handles both mapping and object-style subagents, extracting relevant metadata for observability.


111-118: LGTM!

The sequence normalization helper correctly handles strings, sequences, and other values, converting them to a consistent string sequence format.

python/tests/integrations/deepagents/test_deepagents_integration.py (10)

30-41: LGTM!

The mock fixture correctly handles both sync and async tool execution. The unused kwargs parameter is part of the side effect signature.


44-69: LGTM!

The test fixtures and helper functions are well-structured and provide clean assertion utilities.


72-109: LGTM!

The parametrized test provides excellent coverage of different Deep Agents tool categories with appropriate assertions on mark structure and metadata.


112-134: LGTM!

The async tool call test correctly validates async tool wrapping with appropriate mark assertions.


137-152: LGTM!

The error handling test correctly validates that error marks are emitted before re-raising exceptions.


155-171: LGTM!

The configuration mark test correctly validates that middleware emits configured skills, subagents, and backend information.


174-214: LGTM!

The HITL test comprehensively validates human-in-the-loop interrupt detection and mark emission with correct payload structure.


217-243: LGTM!

The fallback test correctly validates that non-HITL interrupts emit generic LangGraph marks without Deep Agents-specific metadata.


246-291: LGTM!

The backend instrumentation tests provide good coverage of both sync and async backend operations with appropriate mark assertions.


294-341: LGTM!

The sandbox protocol and integration wiring tests provide comprehensive validation of backend wrapping and kwargs transformation logic.

Comment thread ATTRIBUTIONS-Python.md
Comment thread python/nemo_flow/integrations/deepagents/middleware.py Outdated
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
…nts-int-p2

Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
…nts-int-p2

Signed-off-by: David Gardner <dagardner@nvidia.com>
willkill07
willkill07 previously approved these changes May 13, 2026
Copy link
Copy Markdown
Member

@willkill07 willkill07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is great!

The only feedback I have is related to what is a mark vs what is a scope. If we already capture downstream scopes (tool) then I don't know what the full added value of the mark is.

A CI/Justfile enhancement:

  1. ensure each langchain/langgraph/deepagents test has an appropriate mark (e.g. integration-langchain
  2. add a new python_integration_langchain group to .github/ci-path-filters.yml
  3. Update ci.yml and ci_python.yml to pass through the new group from path filters
  4. test-python should be minimal. split out test-langchain to encompass all LC compatible tests
  5. Add a conditional step in ci_python to call just test-langchain

This way:

  • LC deps are only installed if needed
  • Tests are only run if needed

Comment thread python/nemo_flow/integrations/deepagents/backend.py Outdated
Comment thread python/nemo_flow/integrations/deepagents/backend.py Outdated
Comment thread python/nemo_flow/integrations/deepagents/middleware.py Outdated
…nts-int-p2

Signed-off-by: David Gardner <dagardner@nvidia.com>
Salonijain27
Salonijain27 previously approved these changes May 14, 2026
Copy link
Copy Markdown
Collaborator

@Salonijain27 Salonijain27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from a dependency point of view

@dagardner-nv dagardner-nv changed the base branch from main to release/0.2 May 14, 2026 15:52
@dagardner-nv dagardner-nv dismissed stale reviews from Salonijain27 and willkill07 May 14, 2026 15:52

The base branch was changed.

…deepagents-int-p2

[skip ci]

Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
…removing redundant scopes

Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
…_outputs just creates a stack problem later

Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
[skip ci]

Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
…deepagents-int-p2

Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
@dagardner-nv dagardner-nv requested a review from willkill07 May 14, 2026 22:14
Copy link
Copy Markdown
Collaborator

@Salonijain27 Salonijain27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from a dependency point of view

@willkill07
Copy link
Copy Markdown
Member

/merge

@rapids-bot rapids-bot Bot merged commit 5c88adb into NVIDIA:release/0.2 May 14, 2026
66 checks passed
willkill07 added a commit that referenced this pull request May 15, 2026
* fix: address outstanding sonar issues (#104)

#### Overview

Addresses the open Sonar maintainability findings reported on `release/0.2` by reducing Rust cognitive complexity and replacing duplicated Go test literals.

- [x] I confirm this contribution is my own work, or I have the right to submit it under this project's license.
- [x] I searched existing issues and open pull requests, and this does not duplicate existing work.

#### Details

- Split observability doctor and plugin editor control-flow into smaller helper functions.
- Split OpenAI Responses request encoding overlays into focused helper functions.
- Added constants for duplicated Go observability test literals.

#### Where should the reviewer start?

Start with `crates/core/src/codec/openai_responses.rs`, then review the smaller CLI refactors in `crates/cli/src/doctor.rs` and `crates/cli/src/plugins.rs`.

#### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

- Relates to: none




## Summary by CodeRabbit

* **Refactor**
  * Enhanced code organization in observability component checking, plugin configuration editing, and OpenAI response encoding for improved internal structure and maintainability.

* **Tests**
  * Standardized error message formatting in observability plugin tests for improved consistency and clearer diagnostic output during test failures.



[![Review Change Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/NVIDIA/NeMo-Flow/pull/104)

Authors:
  - Will Killian (https://github.com/willkill07)

Approvers:
  - Ajay Thorve (https://github.com/AjayThorve)

URL: #104

* test: isolate CLI config override tests (#105)

#### Overview

Isolates CLI config override unit tests from developer-level NeMo Flow configuration discovered through the normal user config path.

- [x] I confirm this contribution is my own work, or I have the right to submit it under this project's license.
- [x] I searched existing issues and open pull requests, and this does not duplicate existing work.

#### Details

- Adds a temp-scoped explicit config path helper for config tests that require no implicit user or project config discovery.
- Updates the affected override tests to use that explicit path instead of relying on ambient process configuration.

#### Where should the reviewer start?

Start with `crates/cli/tests/coverage/config_tests.rs`, especially the tests around CLI plugin config overrides.

#### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

- Relates to: none




## Summary by CodeRabbit

* **Tests**
  * Enhanced test infrastructure for configuration resolution by improving test isolation and setup processes.



[![Review Change Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/NVIDIA/NeMo-Flow/pull/105)

Authors:
  - Will Killian (https://github.com/willkill07)

Approvers:
  - Ajay Thorve (https://github.com/AjayThorve)

URL: #105

* chore: keep OpenClaw dependency in lockstep (#107)

#### Overview

Keep the OpenClaw plugin package dependency on `nemo-flow-node` aligned with the package version emitted by repository versioning and packaging workflows.

- [x] I confirm this contribution is my own work, or I have the right to submit it under this project's license.
- [x] I searched existing issues and open pull requests, and this does not duplicate existing work.

#### Details

- Change `nemo-flow-openclaw` to depend on the exact checked-in `nemo-flow-node` version.
- Add a `justfile` helper that updates package dependency versions in both `package.json` and `package-lock.json`.
- Wire the dependency update into `set-version`, `package-node`, and `package-openclaw` so prerelease package builds keep the Node and OpenClaw versions together.
- Align OpenClaw non-tag CI package version suffixing with the Node package workflow.

Validation run:

- `just set-version 0.2.0-alpha.20260514`, verified OpenClaw's `nemo-flow-node` dependency updated without dependency success logs, then restored with `just set-version 0.2.0`.
- `npm install --workspace=nemo-flow-node --ignore-scripts`
- `npm install --workspace=nemo-flow-openclaw --ignore-scripts`
- `npm run typecheck --workspace=nemo-flow-openclaw`
- `npm run pack:check --workspace=nemo-flow-openclaw`
- `just --list`
- `git diff --check`
- Commit-time pre-commit hooks passed for the staged files.

#### Where should the reviewer start?

Start with `justfile`, especially the new package dependency version helper and its calls from `set_node_package_versions`, `package-node`, and `package-openclaw`.

#### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

- Relates to: none




## Summary by CodeRabbit

## Release Notes

* **Chores**
  * Refined OpenClaw package versioning format for improved clarity
  * Pinned nemo-flow-node dependency to a stable version for enhanced reliability
  * Improved build and packaging tooling to ensure consistent dependency alignment



[![Review Change Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/NVIDIA/NeMo-Flow/pull/107)

Authors:
  - Will Killian (https://github.com/willkill07)

Approvers:
  - https://github.com/Salonijain27

URL: #107

* refactor: improve CLI coverage structure (#108)

#### Overview

Refactors the CLI coverage-heavy interactive setup/plugin editors so testable logic lives in focused helper modules, then adds coverage around the extracted behavior and related CLI paths.

- [x] I confirm this contribution is my own work, or I have the right to submit it under this project's license.
- [x] I searched existing issues and open pull requests, and this does not duplicate existing work.

#### Details

- Split plugin config file handling and Observability editor state helpers out of `plugins.rs` into testable modules.
- Split setup config/model/file helper logic out of `setup.rs` into `setup/model.rs`.
- Added focused coverage for CLI setup, plugin editing models, doctor formatting/check helpers, completion install helpers, server gateway forwarding paths, and CLI smoke behavior.
- Updated Codecov component reporting from Gateway Runtime to CLI, set the CLI target to 88%, and excluded only the remaining TTY prompt shells.
- Added module guidance so future testable logic does not go back into the interactive prompt files.

#### Where should the reviewer start?

Start with `crates/cli/src/plugins.rs` and `crates/cli/src/setup.rs` to see the orchestration-only boundary, then review `crates/cli/src/plugins/editor_model.rs`, `crates/cli/src/plugins/config_io.rs`, and `crates/cli/src/setup/model.rs` for the extracted testable logic.

Validation run locally:

- `cargo fmt --all`
- `cargo test -p nemo-flow-cli` with isolated `XDG_CONFIG_HOME`
- `cargo clippy --workspace --all-targets -- -D warnings`
- `just test-rust` with isolated `XDG_CONFIG_HOME`
- `cargo llvm-cov --package nemo-flow-cli --summary-only ...`
- commit hook pre-commit checks, including cargo fmt, cargo clippy, and cargo check

#### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

- Relates to: none


## Summary by CodeRabbit

* **New Features**
  * Plugin config preview, validation, and safer save/merge behavior; clearer scope selection and Hermes hook handling in setup.

* **Chores / Refactor**
  * Reorganized CLI internals into smaller, testable modules to make interactive editors and the setup wizard more reliable.

* **Tests**
  * Added extensive CLI unit and integration tests covering agents, doctor, completions, plugin editor TTY behavior, setup flows, and gateway/server forwarding.

* **Chores**
  * Updated Codecov to include CLI coverage and exclude interactive prompt loops.

Signed-off-by: Will Killian <wkillian@nvidia.com>

* ci: fold OpenClaw checks into Node workflow (#106)

#### Overview

Fold OpenClaw validation into the existing Node.js CI workflow as a conditional step, and make `just test-openclaw` run the live smoke coverage path.

- [x] I confirm this contribution is my own work, or I have the right to submit it under this project's license.
- [x] I searched existing issues and open pull requests, and this does not duplicate existing work.

#### Details

- Add a `run_openclaw` input to the reusable Node.js workflow.
- Run OpenClaw integration checks as a conditional step across the full Node test matrix.
- Remove the separate OpenClaw workflow call and workflow file.
- Keep OpenClaw package artifact creation inside the existing Node package job while leaving Node package steps gated by `run_package`.
- Add the live smoke test path to `just test-openclaw` and document the target in contributor testing guidance.

#### Where should the reviewer start?

Start with `.github/workflows/ci_node.yml`, especially the conditional OpenClaw test step in the Node test job and the package-job gating.

#### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

- Relates to: none


<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit

* **Tests**
  * Added live-run OpenClaw smoke tests and a helper script to run them.
  * OpenClaw integration checks now run conditionally inside the Node.js test flow.
  * Test suites updated to use compiled test artifacts and adjusted import paths.

* **Chores**
  * Removed standalone OpenClaw CI job; its checks and optional packaging were folded into the Node.js workflow and gated by inputs.
  * OpenClaw packaging and artifact upload are now conditional.

* **Documentation**
  * Testing guide and integration README updated with live-test target and artifact locations.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

* feat: update OpenClaw patch to use new config shape (#111)

#### Overview

This PR updates the OpenClaw patch to be aligned with `main`

- [x] I confirm this contribution is my own work, or I have the right to submit it under this project's license.
- [x] I searched existing issues and open pull requests, and this does not duplicate existing work.

#### Details

<!-- Describe the changes made in this PR. -->

#### Where should the reviewer start?

<!-- Point to the most important file, test, or design decision. -->

#### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

- Closes #

* feat: Add Deep Agents integration (#90)

#### Overview
* Primary entry point for end-users is the `add_nemo_flow_integration` method, which adds NeMo Flow middleware to the agent and subagents (if any).
* Emit a mark when skills are loaded and HITL events
* `langgraph` is promoted from a transitive dep to a direct-dep in the `langchain` extra since `python/nemo_flow/integrations/langchain/_serialization.py` now imports from `langgraph`
* Adds work-around for installing OpenSSL on Windows-Arm CI runners

- [x] I confirm this contribution is my own work, or I have the right to submit it under this project's license.
- [x] I searched existing issues and open pull requests, and this does not duplicate existing work.

#### Details



#### Where should the reviewer start?



#### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

- Closes #



## Summary by CodeRabbit

* **New Features**
  * Deep Agents integration: observability for agent runs, tool calls, filesystem/sandbox operations, human-in-the-loop events, backend instrumentation, and middleware marks.

* **Documentation**
  * Added Deep Agents integration README with setup, usage, and observed-event examples.

* **Tests**
  * New integration and end-to-end tests covering middleware, backend instrumentation, sandbox behavior, and HITL flows; added shared test fixture.

* **Chores**
  * Added optional Deep Agents dependency group and regenerated third‑party attributions/licenses.

* **CI**
  * Updated CI and dev sync steps to include Deep Agents extras and platform-specific setup.



[![Review Change Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/NVIDIA/NeMo-Flow/pull/90)

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Will Killian (https://github.com/willkill07)
  - https://github.com/Salonijain27

URL: #90

* chore: refresh dependency locks (#112)

#### Overview

Refresh dependency locks and runtime compatibility wiring for the `release/0.2` branch.

- [x] I confirm this contribution is my own work, or I have the right to submit it under this project license.
- [x] I searched existing issues and open pull requests, and this does not duplicate existing work.

#### Details

- Updates Python optional integration constraints and lockfile entries for the release branch.
- Updates OpenClaw peer compatibility to `2026.5.12` and syncs the local hook type mirror with the current session end reasons.
- Adjusts Rust reqwest/rustls provider configuration and OTLP HTTP client selection so TLS and exporter initialization remain stable while unused optional transport packages stay out of the lockfile.
- Makes Node attribution generation lockfile-driven so platform-gated optional packages are listed consistently across CI and local machines.
- Pulls Node license text from integrity-checked locked npm artifacts when packages are not installed on the current platform.
- Regenerates Python and Node attribution files from the refreshed lockfiles.

Validation run:
- `cargo test -p nemo-flow-cli`
- `cargo check -p nemo-flow --features otel`
- `cargo check -p nemo-flow --features otel,openinference`
- `cargo test -p nemo-flow http_config_exports_scope_push_pop_and_marks_without_tokio_runtime -- --nocapture`
- `npm test --workspace integrations/openclaw`
- `uv run --extra langgraph --extra langchain-nvidia pytest python/tests/integrations/langchain python/tests/integrations/langgraph third_party/langgraph_tests`
- `npm audit --ignore-scripts`
- `cargo fmt --all --check`
- `pre-commit run --files scripts/licensing/attributions_lockfile_md.py ATTRIBUTIONS-Node.md package-lock.json`
- signed commit pre-commit suite

#### Where should the reviewer start?

Start with `scripts/licensing/attributions_lockfile_md.py`, `crates/cli/src/tls.rs`, `crates/core/Cargo.toml`, and `integrations/openclaw/package.json` to review the generator, runtime, and integration compatibility changes before the regenerated lockfile and attribution diffs.

#### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

- Relates to: none


## Summary by CodeRabbit

* **Dependencies**
  * Bumped several Python packages (langchain, langchain-core, langgraph, langgraph-*, urllib3) and raised OpenClaw compatibility to 2026.5.12.
* **New Features**
  * Added "shutdown" and "restart" as session termination reasons.
* **Chores**
  * Ensure TLS/crypto provider is initialized before network operations across CLI and services.
* **Documentation**
  * Refreshed third‑party attributions and improved license extraction for Node/Python packages.



[![Review Change Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/NVIDIA/NeMo-Flow/pull/112)

Authors:
  - Will Killian (https://github.com/willkill07)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)
  - https://github.com/Salonijain27

URL: #112

* fix: support Cursor CLI hook config (#109)

#### Overview

Fix Cursor CLI hook configuration so current `cursor-agent` builds can execute NeMo Flow hook commands, and document the remaining Cursor CLI hook coverage limits.

- [x] I confirm this contribution is my own work, or I have the right to submit it under this project's license.
- [x] I searched existing issues and open pull requests, and this does not duplicate existing work.

#### Details

- Generate Cursor `.cursor/hooks.json` entries as direct command entries with top-level `"version": 1`.
- Preserve that Cursor-compatible shape when `nemo-flow run -- cursor-agent` temporarily patches project hooks.
- Update `nemo-flow doctor cursor` to reject nested Cursor hook groups and missing or non-`1` top-level version fields.
- Trim nullable fields from Cursor permission responses.
- Update Cursor integration docs and packaged hooks to state the CLI limitation plainly: current Cursor CLI hook coverage is narrower than Cursor IDE hook coverage.

#### Where should the reviewer start?

Start with `crates/cli/src/installer.rs` for the hook-shape change, then `crates/cli/src/doctor.rs` for validation of user-managed Cursor hook files.

#### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

- Closes https://linear.app/nvidia/issue/NMF-122/fix-cursor-cli-hook-config-and-document-stream-json-limitation



## Summary by CodeRabbit

* **Refactor**
  * Standardized Cursor hook JSON to require a top-level version (1) and direct command entries; merged/generated hook files now enforce this shape.

* **New Features**
  * Added stricter validation for Cursor hook files with clear, actionable status messages and test coverage.

* **Bug Fixes**
  * Cursor hook responses/endpoints no longer include legacy message fields.

* **Documentation**
  * Expanded Cursor integration and troubleshooting guidance, plus CLI verification steps.



[![Review Change Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/NVIDIA/NeMo-Flow/pull/109)

Authors:
  - Ajay Thorve (https://github.com/AjayThorve)

Approvers:
  - Will Killian (https://github.com/willkill07)

URL: #109

---------

Signed-off-by: Will Killian <wkillian@nvidia.com>
Co-authored-by: Will Killian <2007799+willkill07@users.noreply.github.com>
Co-authored-by: David Gardner <96306125+dagardner-nv@users.noreply.github.com>
Co-authored-by: Ajay Thorve <AjayThorve@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature a new feature lang:python PR changes/introduces Python code size:XL PR is extra large

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants