Skip to content

KO ITN fixes (MRC updates)#390

Merged
tbartley94 merged 8 commits intoNVIDIA:ko_itn_staging_v1from
bbae0312:ko_itn_staging_v1
Mar 4, 2026
Merged

KO ITN fixes (MRC updates)#390
tbartley94 merged 8 commits intoNVIDIA:ko_itn_staging_v1from
bbae0312:ko_itn_staging_v1

Conversation

@bbae0312
Copy link

@bbae0312 bbae0312 commented Mar 4, 2026

What does this PR do ?

This PR updates Korean ITN with:

  • Fixes for number parsing (cardinal, ordinal, fraction, measure, money, time)
  • Initial MRC review updates

Before your PR is "Ready for review"

Pre checks:

  • Have you signed your commits? Use git commit -s to sign.
  • Do all unittests finish successfully before sending PR?
    1. pytest or (if your machine does not have GPU) pytest --cpu from the root folder (given you marked your test cases accordingly @pytest.mark.run_only_on('CPU')).
    2. Sparrowhawk tests bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
  • If you are adding a new feature: Have you added test cases for both pytest and Sparrowhawk here.
  • Have you added __init__.py for every folder and subfolder, including data folder which has .TSV files?
  • Have you followed codeQL results and removed unused variables and imports (report is at the bottom of the PR in github review box) ?
  • Have you added the correct license header Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. to all newly added Python files?
  • If you copied nemo_text_processing/text_normalization/en/graph_utils.py your header's second line should be Copyright 2015 and onwards Google, Inc.. See an example here.
  • Remove import guards (try import: ... except: ...) if not already done.
  • If you added a new language or a new feature please update the NeMo documentation (lives in different repo).
  • Have you added your language support to tools/text_processing_deployment/pynini_export.py.

PR Type:

  • New Feature
  • Bugfix
  • Documentation
  • Test

If you haven't finished some of the above items you can still open "Draft" PR.

bbae0312 and others added 6 commits February 17, 2026 15:20
Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>
Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>
Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>
Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>
@bbae0312 bbae0312 changed the title KO TN fixes (MRC updates) KO ITN fixes (MRC updates) Mar 4, 2026
bbae0312 and others added 2 commits March 4, 2026 09:08
Signed-off-by: Jinwoo Bae <34386414+bbae0312@users.noreply.github.com>
@tbartley94 tbartley94 self-requested a review March 4, 2026 17:23
@bbae0312
Copy link
Author

bbae0312 commented Mar 4, 2026

Both pytest and Sparrowhawk tests passed locally.

@tbartley94 tbartley94 merged commit fc715c8 into NVIDIA:ko_itn_staging_v1 Mar 4, 2026
2 checks passed
bbae0312 added a commit to bbae0312/NeMo-text-processing that referenced this pull request Mar 5, 2026
* Korean ITN fixes

Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix KO ITN decimal and money graph cleanup

Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>

* Fix KO ITN decimal-money ambiguity

Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix Korean ITN rules based on the feedback

Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>
tbartley94 pushed a commit that referenced this pull request Mar 5, 2026
* Korean ITN fixes



* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix KO ITN decimal and money graph cleanup



* Fix KO ITN decimal-money ambiguity



* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix Korean ITN rules based on the feedback



* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>
bbae0312 added a commit to bbae0312/NeMo-text-processing that referenced this pull request Mar 6, 2026
* Korean ITN fixes

Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix KO ITN decimal and money graph cleanup

Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>

* Fix KO ITN decimal-money ambiguity

Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix Korean ITN rules based on the feedback

Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>
bbae0312 added a commit to bbae0312/NeMo-text-processing that referenced this pull request Mar 6, 2026
* Korean ITN fixes

Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix KO ITN decimal and money graph cleanup

Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>

* Fix KO ITN decimal-money ambiguity

Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix Korean ITN rules based on the feedback

Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
bbae0312 added a commit to bbae0312/NeMo-text-processing that referenced this pull request Mar 6, 2026
* Korean ITN fixes



* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix KO ITN decimal and money graph cleanup



* Fix KO ITN decimal-money ambiguity



* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix Korean ITN rules based on the feedback



* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants