Skip to content

electronic class changes with another PR to resolve merge conflicts with main#408

Merged
mgrafu merged 2 commits intoNVIDIA:staging/hi_tn_electronicsfrom
shrpawar-alt:hi-tn-electronic
Apr 15, 2026
Merged

electronic class changes with another PR to resolve merge conflicts with main#408
mgrafu merged 2 commits intoNVIDIA:staging/hi_tn_electronicsfrom
shrpawar-alt:hi-tn-electronic

Conversation

@shrpawar-alt
Copy link
Copy Markdown

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Before your PR is "Ready for review"

Pre checks:

  • Have you signed your commits? Use git commit -s to sign.
  • Do all unittests finish successfully before sending PR?
    1. pytest or (if your machine does not have GPU) pytest --cpu from the root folder (given you marked your test cases accordingly @pytest.mark.run_only_on('CPU')).
    2. Sparrowhawk tests bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
  • If you are adding a new feature: Have you added test cases for both pytest and Sparrowhawk here.
  • Have you added __init__.py for every folder and subfolder, including data folder which has .TSV files?
  • Have you followed codeQL results and removed unused variables and imports (report is at the bottom of the PR in github review box) ?
  • Have you added the correct license header Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. to all newly added Python files?
  • If you copied nemo_text_processing/text_normalization/en/graph_utils.py your header's second line should be Copyright 2015 and onwards Google, Inc.. See an example here.
  • Remove import guards (try import: ... except: ...) if not already done.
  • If you added a new language or a new feature please update the NeMo documentation (lives in different repo).
  • Have you added your language support to tools/text_processing_deployment/pynini_export.py.

PR Type:

  • New Feature
  • Bugfix
  • Documentation
  • Test

If you haven't finished some of the above items you can still open "Draft" PR.

shrpawar-alt and others added 2 commits April 7, 2026 11:01
Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com>
@shrpawar-alt shrpawar-alt marked this pull request as ready for review April 7, 2026 11:11
Comment thread nemo_text_processing/text_normalization/hi/data/address/letters.tsv
@mgrafu mgrafu changed the base branch from main to staging/hi_tn_electronics April 7, 2026 15:19
Comment thread tests/nemo_text_processing/hi/test_sparrowhawk_normalization.sh
@mgrafu mgrafu merged commit 9205987 into NVIDIA:staging/hi_tn_electronics Apr 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants