Skip to content

Package setup refactoring#289

Merged
okuchaiev merged 22 commits intomasterfrom
package_setup_refactoring
Jan 24, 2020
Merged

Package setup refactoring#289
okuchaiev merged 22 commits intomasterfrom
package_setup_refactoring

Conversation

@DEKHTIARJonathan
Copy link
Collaborator

Important Package Refactoring of the collection additional repositories

Project Update:

  • Added nemo/package_info.py contains all the core information of the package, including version
  • Added Changelog.md, please start using it ;)

To install:

  • pip install nemo_toolkit # Core Only
  • pip install nemo_toolkit[nlp] # Core + NLP
  • pip install nemo_toolkit[nlp,asr] # Core + NLP + ASR
  • pip install nemo_toolkit[all] # Absolutely everything

To be noted:

When using pip install -e, you have to use quotes for dev purposes: pip install -e ".[nlp]"

@DEKHTIARJonathan DEKHTIARJonathan force-pushed the package_setup_refactoring branch from 7d468d4 to 39a9c0d Compare January 23, 2020 22:42
@okuchaiev
Copy link
Collaborator

could you please sign your commits https://github.com/NVIDIA/NeMo/pull/289/checks?check_run_id=406125737

Copy link
Collaborator

@okuchaiev okuchaiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please sign your commits so that DCO passes.
Also, please autoformat it so that PEP8 passes, otherwise our CI can't run: http://10.110.42.104:8080/blue/organizations/jenkins/NeMo/detail/PR-289/2/pipeline/22

@lgtm-com
Copy link

lgtm-com bot commented Jan 23, 2020

This pull request introduces 16 alerts and fixes 23 when merging 39a9c0d into b986859 - view on LGTM.com

new alerts:

  • 15 for 'import *' may pollute namespace
  • 1 for Unused import

fixed alerts:

  • 15 for 'import *' may pollute namespace
  • 7 for Module is imported with 'import' and 'import from'
  • 1 for Unused import

@DEKHTIARJonathan
Copy link
Collaborator Author

OIC yeah I need a GPG key ...

@okuchaiev
Copy link
Collaborator

no, you don't need a GPG key. To sign them when you are commiting do "git commit -s" this is different from "git commit -S". DCO's bot output tells you how to sign commited commits.

@blisc
Copy link
Collaborator

blisc commented Jan 23, 2020

Can you move README.md back into nemo/ since we already have the repo README as part of README.rst

@blisc
Copy link
Collaborator

blisc commented Jan 23, 2020

What is requirements/requirements_test.txt?

@blisc
Copy link
Collaborator

blisc commented Jan 23, 2020

Q: nemo_tts requires nemo_asr. Inside requirements_tts.txt, there is a line that says nemo_asr, I am assuming that this no longer works, how do we work around this?

Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
@DEKHTIARJonathan DEKHTIARJonathan force-pushed the package_setup_refactoring branch from 39a9c0d to 5751f51 Compare January 24, 2020 00:34
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
@lgtm-com
Copy link

lgtm-com bot commented Jan 24, 2020

This pull request introduces 16 alerts and fixes 23 when merging b597f23 into b986859 - view on LGTM.com

new alerts:

  • 15 for 'import *' may pollute namespace
  • 1 for Unused import

fixed alerts:

  • 15 for 'import *' may pollute namespace
  • 7 for Module is imported with 'import' and 'import from'
  • 1 for Unused import

DEKHTIARJonathan added 2 commits January 23, 2020 17:00
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
@DEKHTIARJonathan
Copy link
Collaborator Author

Q: nemo_tts requires nemo_asr. Inside requirements_tts.txt, there is a line that says nemo_asr, I am assuming that this no longer works, how do we work around this?

I'll modified this, thanks I did't see :)

@lgtm-com
Copy link

lgtm-com bot commented Jan 24, 2020

This pull request introduces 16 alerts and fixes 23 when merging f2af2e0 into b986859 - view on LGTM.com

new alerts:

  • 15 for 'import *' may pollute namespace
  • 1 for Unused import

fixed alerts:

  • 15 for 'import *' may pollute namespace
  • 7 for Module is imported with 'import' and 'import from'
  • 1 for Unused import

DEKHTIARJonathan added 5 commits January 23, 2020 17:16
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
@lgtm-com
Copy link

lgtm-com bot commented Jan 24, 2020

This pull request introduces 16 alerts and fixes 23 when merging b22ed44 into b986859 - view on LGTM.com

new alerts:

  • 15 for 'import *' may pollute namespace
  • 1 for Unused import

fixed alerts:

  • 15 for 'import *' may pollute namespace
  • 7 for Module is imported with 'import' and 'import from'
  • 1 for Unused import

DEKHTIARJonathan added 3 commits January 23, 2020 17:45
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
@lgtm-com
Copy link

lgtm-com bot commented Jan 24, 2020

This pull request introduces 16 alerts and fixes 23 when merging c84db65 into b986859 - view on LGTM.com

new alerts:

  • 15 for 'import *' may pollute namespace
  • 1 for Unused import

fixed alerts:

  • 15 for 'import *' may pollute namespace
  • 7 for Module is imported with 'import' and 'import from'
  • 1 for Unused import

Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
@lgtm-com
Copy link

lgtm-com bot commented Jan 24, 2020

This pull request introduces 16 alerts and fixes 23 when merging a2bb05e into b986859 - view on LGTM.com

new alerts:

  • 15 for 'import *' may pollute namespace
  • 1 for Unused import

fixed alerts:

  • 15 for 'import *' may pollute namespace
  • 7 for Module is imported with 'import' and 'import from'
  • 1 for Unused import

Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
@lgtm-com
Copy link

lgtm-com bot commented Jan 24, 2020

This pull request introduces 16 alerts and fixes 23 when merging e8eca31 into b986859 - view on LGTM.com

new alerts:

  • 15 for 'import *' may pollute namespace
  • 1 for Unused import

fixed alerts:

  • 15 for 'import *' may pollute namespace
  • 7 for Module is imported with 'import' and 'import from'
  • 1 for Unused import

Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
@lgtm-com
Copy link

lgtm-com bot commented Jan 24, 2020

This pull request introduces 16 alerts and fixes 23 when merging 192cb30 into b986859 - view on LGTM.com

new alerts:

  • 15 for 'import *' may pollute namespace
  • 1 for Unused import

fixed alerts:

  • 15 for 'import *' may pollute namespace
  • 7 for Module is imported with 'import' and 'import from'
  • 1 for Unused import

Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
@lgtm-com
Copy link

lgtm-com bot commented Jan 24, 2020

This pull request introduces 23 alerts and fixes 28 when merging e424323 into 52bb24d - view on LGTM.com

new alerts:

  • 15 for 'import *' may pollute namespace
  • 7 for Syntax error
  • 1 for Unused import

fixed alerts:

  • 15 for 'import *' may pollute namespace
  • 7 for Module is imported with 'import' and 'import from'
  • 6 for Unused import

DEKHTIARJonathan added 3 commits January 24, 2020 11:34
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
@lgtm-com
Copy link

lgtm-com bot commented Jan 24, 2020

This pull request introduces 17 alerts and fixes 17 when merging 2400e8d into 2c50777 - view on LGTM.com

new alerts:

  • 15 for 'import *' may pollute namespace
  • 1 for Unused import
  • 1 for Syntax error

fixed alerts:

  • 15 for 'import *' may pollute namespace
  • 1 for Unused import
  • 1 for Module is imported with 'import' and 'import from'

DEKHTIARJonathan added 2 commits January 24, 2020 12:55
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
@lgtm-com
Copy link

lgtm-com bot commented Jan 24, 2020

This pull request introduces 18 alerts and fixes 19 when merging 946c159 into 2c50777 - view on LGTM.com

new alerts:

  • 15 for 'import *' may pollute namespace
  • 2 for Unused import
  • 1 for Module is imported with 'import' and 'import from'

fixed alerts:

  • 15 for 'import *' may pollute namespace
  • 3 for Unused import
  • 1 for Module is imported with 'import' and 'import from'

Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>
@lgtm-com
Copy link

lgtm-com bot commented Jan 24, 2020

This pull request introduces 18 alerts and fixes 19 when merging 54a933a into 2c50777 - view on LGTM.com

new alerts:

  • 15 for 'import *' may pollute namespace
  • 2 for Unused import
  • 1 for Module is imported with 'import' and 'import from'

fixed alerts:

  • 15 for 'import *' may pollute namespace
  • 3 for Unused import
  • 1 for Module is imported with 'import' and 'import from'

@okuchaiev okuchaiev merged commit ad829a9 into master Jan 24, 2020
blisc added a commit that referenced this pull request Jan 24, 2020
@DEKHTIARJonathan DEKHTIARJonathan deleted the package_setup_refactoring branch January 24, 2020 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants