Conversation
7d468d4 to
39a9c0d
Compare
|
could you please sign your commits https://github.com/NVIDIA/NeMo/pull/289/checks?check_run_id=406125737 |
okuchaiev
left a comment
There was a problem hiding this comment.
Can you please sign your commits so that DCO passes.
Also, please autoformat it so that PEP8 passes, otherwise our CI can't run: http://10.110.42.104:8080/blue/organizations/jenkins/NeMo/detail/PR-289/2/pipeline/22
|
This pull request introduces 16 alerts and fixes 23 when merging 39a9c0d into b986859 - view on LGTM.com new alerts:
fixed alerts:
|
|
OIC yeah I need a GPG key ... |
|
no, you don't need a GPG key. To sign them when you are commiting do "git commit -s" this is different from "git commit -S". DCO's bot output tells you how to sign commited commits. |
|
Can you move README.md back into nemo/ since we already have the repo README as part of README.rst |
|
What is requirements/requirements_test.txt? |
|
Q: nemo_tts requires nemo_asr. Inside requirements_tts.txt, there is a line that says nemo_asr, I am assuming that this no longer works, how do we work around this? |
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
39a9c0d to
5751f51
Compare
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
|
This pull request introduces 16 alerts and fixes 23 when merging b597f23 into b986859 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
I'll modified this, thanks I did't see :) |
|
This pull request introduces 16 alerts and fixes 23 when merging f2af2e0 into b986859 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
|
This pull request introduces 16 alerts and fixes 23 when merging b22ed44 into b986859 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
|
This pull request introduces 16 alerts and fixes 23 when merging c84db65 into b986859 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
|
This pull request introduces 16 alerts and fixes 23 when merging a2bb05e into b986859 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
|
This pull request introduces 16 alerts and fixes 23 when merging e8eca31 into b986859 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
|
This pull request introduces 16 alerts and fixes 23 when merging 192cb30 into b986859 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
|
This pull request introduces 23 alerts and fixes 28 when merging e424323 into 52bb24d - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
|
This pull request introduces 17 alerts and fixes 17 when merging 2400e8d into 2c50777 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
Signed-off-by: DEKHTIARJonathan <contact@jonathandekhtiar.eu>
|
This pull request introduces 18 alerts and fixes 19 when merging 946c159 into 2c50777 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>
|
This pull request introduces 18 alerts and fixes 19 when merging 54a933a into 2c50777 - view on LGTM.com new alerts:
fixed alerts:
|
Important Package Refactoring of the collection additional repositories
Project Update:
nemo/package_info.pycontains all the core information of the package, including versionTo install:
pip install nemo_toolkit# Core Onlypip install nemo_toolkit[nlp]# Core + NLPpip install nemo_toolkit[nlp,asr]# Core + NLP + ASRpip install nemo_toolkit[all]# Absolutely everythingTo be noted:
When using
pip install -e, you have to use quotes for dev purposes:pip install -e ".[nlp]"