docs: use CUDA base image for GPU smoke test in spark-install#1226
docs: use CUDA base image for GPU smoke test in spark-install#1226latenighthackathon wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe GPU smoke-test Docker command in documentation now uses the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
✨ Thanks for submitting this pull request, which proposes a way to improve the documentation for the GPU smoke test in spark-install. This could help users verify their GPU configuration more accurately. Possibly related open issues: |
d418150 to
5ef06c5
Compare
|
@latenighthackathon thanks ! pls update your branch, add a sign-off in your PR description, otherwise this looks good for approval |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
7d1f4c8 to
f86b936
Compare
|
@prekshivyas @wscurran Thanks for the review! I've rebased onto latest Cheers! |
prekshivyas
left a comment
There was a problem hiding this comment.
Correct — ubuntu image doesn't have nvidia-smi. CUDA base image is the standard for GPU validation. @latenighthackathon can you rebase onto main?
3e75050 to
521dff6
Compare
|
@prekshivyas Rebased onto latest Cheers! |
|
@latenighthackathon is it okay if you can give us access to update branches on your fork ? |
The ubuntu image does not include nvidia-smi, so the GPU verification command always fails even when GPUs are correctly configured. Switch to nvidia/cuda:12.8.0-base-ubuntu24.04 which includes nvidia-smi. Closes NVIDIA#1166 Signed-off-by: latenighthackathon <latenighthackathon@users.noreply.github.com>
0dc82c3 to
3e9b2bb
Compare
Summary
ubuntuwithnvidia/cuda:12.8.0-base-ubuntu24.04in the GPU verification commandRelated Issue
Closes #1166
Changes
The GPU smoke test in
spark-install.mduses theubuntuDocker image, which does not includenvidia-smi. The command always fails even when GPUs are correctly configured, making it useless as a validation step.Switched to
nvidia/cuda:12.8.0-base-ubuntu24.04which includesnvidia-smiand correctly validates GPU access through the NVIDIA container runtime.Testing
nvidia/cuda:12.8.0-base-ubuntu24.04exists on Docker HubChecklist
Signed-off-by: latenighthackathon latenighthackathon@users.noreply.github.com
Summary by CodeRabbit