fix(onboard): persist model and provider to registry after sandbox creation

[BenediktSchackenberg]

Problem

After nemoclaw onboard, nemoclaw list shows model: unknown provider: unknown for all sandboxes. The registry has model: null and provider: null even though onboard correctly displayed the configured values.

Root cause

registry.updateSandbox(sandboxName, { model, provider }) was called at line 3643 (Step 4: inference setup) — before registry.registerSandbox() at line 2827 (Step 6: create sandbox). Since updateSandbox() silently returns false when the entry doesn't exist (registry.ts:177), the values were never persisted.

Fix

Added a registry.updateSandbox(sandboxName, { model, provider }) call immediately after createSandbox() returns. At that point the registry entry is guaranteed to exist.

Testing

• nemoclaw onboard → nemoclaw list now shows the correct model and provider
• ~/.nemoclaw/sandboxes.json stores the configured values instead of null

Fixes #1881

Signed-off-by: Benedikt Schackenberg 6381261+BenediktSchackenberg@users.noreply.github.com

Summary by CodeRabbit

• Bug Fixes

  • Ensures sandbox model and provider settings are persisted immediately after sandbox creation so configurations are reliably saved during onboarding.

• Tests

  • Added a regression test to verify the onboarding flow persists settings in the correct sequence to prevent future regressions.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a6d6935a-ffa7-465f-a122-23c651daa496

📥 Commits

Reviewing files that changed from the base of the PR and between 5a5298d and 1ed078a.

📒 Files selected for processing (1)

• test/onboard.test.ts

---

📝 Walkthrough

Walkthrough

A one-line fix in the onboard flow calls registry.updateSandbox(sandboxName, { model, provider }) immediately after createSandbox(...) returns, ensuring the sandbox registry entry persists model and provider values. A regression test asserting call order was added.

Changes

Cohort / File(s)	Summary
Sandbox Onboarding Flow src/lib/onboard.ts	Inserted immediate registry.updateSandbox(sandboxName, { model, provider }) call right after createSandbox(...) returns to persist model/provider after the registry entry exists.
Tests — Onboard call-order test/onboard.test.ts	Added a regression test that reads src/lib/onboard.ts and asserts that the createSandbox(...) call appears before registry.updateSandbox(sandboxName, { model, provider }), failing if order is incorrect or snippets missing.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through code with nimble paws,
Found where the sandbox lost its cause,
One tiny nudge — a call placed near,
Now model and provider appear! 🥕✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and concisely summarizes the main change: persisting model and provider to the registry after sandbox creation, which directly addresses the bug fix.
Linked Issues check	✅ Passed	The changes directly address issue #1881 by adding the required registry.updateSandbox() call after createSandbox() to ensure model and provider are persisted, plus a regression test to prevent reoccurrence.
Out of Scope Changes check	✅ Passed	All changes are scope-focused: the production fix adds four lines to persist model/provider after sandbox creation, and the test file adds regression coverage with no extraneous modifications.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Fixes a registry persistence bug in the onboarding flow where the selected inference model and provider were not being saved for newly created sandboxes, causing nemoclaw list to display unknown.

Changes:

• Persist model and provider to the sandbox registry immediately after createSandbox() returns (i.e., after the registry entry is guaranteed to exist).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Add a regression test to ensure model/provider are persisted after sandbox creation. Since this bug was caused by calling registry.updateSandbox before registry.registerSandbox existed, a unit test (similar to the existing source-order regex assertions in test/onboard.test.ts) should assert that the onboard flow calls registry.updateSandbox(sandboxName, { model, provider }) after createSandbox(...) returns, so future refactors don’t reintroduce the silent no-op behavior.

[BenediktSchackenberg]

Added a source-order regression test in test/onboard.test.ts: asserts that registry.updateSandbox(sandboxName, { model, provider }) appears after createSandbox() in the source. This prevents the bug from being silently reintroduced. 107/107 tests pass.