Skip to content

fix(e2e): set alternate dashboard port for multi-sandbox test#2124

Merged
ericksoa merged 1 commit intomainfrom
fix/e2e-multi-sandbox-port-collision
Apr 21, 2026
Merged

fix(e2e): set alternate dashboard port for multi-sandbox test#2124
ericksoa merged 1 commit intomainfrom
fix/e2e-multi-sandbox-port-collision

Conversation

@ericksoa
Copy link
Copy Markdown
Contributor

@ericksoa ericksoa commented Apr 21, 2026

Summary

Test plan

  • Nightly E2E sandbox-operations-e2e job passes (TC-SBX-10, TC-SBX-11)

Fixes regression from #2086.

Summary by CodeRabbit

  • Tests
    • Updated test infrastructure configuration for sandbox operations.

Note: This release contains no user-facing changes. Updates are limited to internal testing procedures.

PR #2086 added a port-collision guard in ensureDashboardForward() that
throws when a second sandbox tries to claim the same dashboard port.
TC-SBX-10 onboards sandbox B without overriding CHAT_UI_URL, hitting
the new guard.  Use port 18790 for the second sandbox.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ae9b99b0-803f-4cbb-8b5d-c5e664f999e5

📥 Commits

Reviewing files that changed from the base of the PR and between e15f4dc and ee37fdc.

📒 Files selected for processing (1)
  • test/e2e/test-sandbox-operations.sh

📝 Walkthrough

Walkthrough

The test-sandbox-operations.sh file was modified to set the CHAT_UI_URL environment variable inline when invoking the onboard_sandbox function for sandbox B, ensuring the function receives a specific URL during the multi_sandbox_metadata test execution.

Changes

Cohort / File(s) Summary
Test Configuration
test/e2e/test-sandbox-operations.sh
Modified onboard_sandbox invocation to set CHAT_UI_URL="http://127.0.0.1:18790" inline for sandbox B onboarding in the multi_sandbox_metadata test.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A URL finds its place,
In sandbox B's embrace,
Chat flows through ports so fine,
Tests dance on line 127,
Where rabbits debug with delight! 🐰✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: fixing an e2e test by setting an alternate dashboard port for multi-sandbox testing, which directly matches the changeset modification.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/e2e-multi-sandbox-port-collision

Comment @coderabbitai help to get the list of available commands and usage tips.

@ericksoa ericksoa merged commit 86bce0c into main Apr 21, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant